Re: [PATCH v4 6/7] selftests/ftrace: Add test case for synthetic event dynamic strings

[Masami Hiramatsu <mhiramat@kernel.org>]

On Sun,  4 Oct 2020 17:14:08 -0500
Tom Zanussi <zanussi@kernel.org> wrote:

> Add a selftest that defines and traces a synthetic event that uses a
> dynamic string event field.
> 
> Signed-off-by: Tom Zanussi <zanussi@kernel.org>

This looks good to me.

Acked-by: Masami Hiramatsu <mhiramat@kernel.org>

Thank you!
> ---
>  .../trigger-synthetic-event-dynstring.tc      | 31 +++++++++++++++++++
>  1 file changed, 31 insertions(+)
>  create mode 100644 tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-synthetic-event-dynstring.tc
> 
> diff --git a/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-synthetic-event-dynstring.tc b/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-synthetic-event-dynstring.tc
> new file mode 100644
> index 000000000000..3d65c856eca3
> --- /dev/null
> +++ b/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-synthetic-event-dynstring.tc
> @@ -0,0 +1,31 @@
> +#!/bin/sh
> +# SPDX-License-Identifier: GPL-2.0
> +# description: event trigger - test inter-event histogram trigger trace action with dynamic string param
> +# requires: set_event synthetic_events events/sched/sched_process_exec/hist "char name[]' >> synthetic_events":README
> +
> +fail() { #msg
> +    echo $1
> +    exit_fail
> +}
> +
> +echo "Test create synthetic event"
> +
> +echo 'ping_test_latency u64 lat; char filename[]' > synthetic_events
> +if [ ! -d events/synthetic/ping_test_latency ]; then
> +    fail "Failed to create ping_test_latency synthetic event"
> +fi
> +
> +echo "Test create histogram for synthetic event using trace action and dynamic strings"
> +echo "Test histogram dynamic string variables,simple expression support and trace action"
> +
> +echo 'hist:key=pid:filenamevar=filename:ts0=common_timestamp.usecs' > events/sched/sched_process_exec/trigger
> +echo 'hist:key=pid:lat=common_timestamp.usecs-$ts0:onmatch(sched.sched_process_exec).ping_test_latency($lat,$filenamevar) if comm == "ping"' > events/sched/sched_process_exit/trigger
> +echo 'hist:keys=filename,lat:sort=filename,lat' > events/synthetic/ping_test_latency/trigger
> +
> +ping $LOCALHOST -c 5
> +
> +if ! grep -q "ping" events/synthetic/ping_test_latency/hist; then
> +    fail "Failed to create dynamic string trace action inter-event histogram"
> +fi
> +
> +exit 0
> -- 
> 2.17.1
> 


-- 
Masami Hiramatsu <mhiramat@kernel.org>