From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
To: "Jonathan Corbet" <corbet@lwn.net>,
Linux Doc Mailing List <linux-doc@vger.kernel.org>
Cc: linux-kernel@vger.kernel.org, Matthew Wilcox <willy@infradead.org>
Subject: Re: [PATCH v3] script: add a script for checking doc problems with external functions
Date: Thu, 8 Oct 2020 12:29:31 +0200 [thread overview]
Message-ID: <20201008122931.369b628d@coco.lan> (raw)
In-Reply-To: <c256819190b2691f62c515c4aa82033a8d35c8f0.1602077410.git.mchehab+huawei@kernel.org>
Em Wed, 7 Oct 2020 15:31:10 +0200
Mauro Carvalho Chehab <mchehab+huawei@kernel.org> escreveu:
> While not all EXPORT_SYMBOL*() symbols should be documented,
> it seems useful to have a tool which would help to check what
> symbols aren't documented.
>
> This is a first step on this direction. The tool has some
> limitations. Yet, it could be useful for maintainers to check
> about missing documents on their subsystems.
./scripts/check_docs_external_symbols drivers/gpu/drm/ took 102.04 seconds
It took more than an hour to run on a Xeon workstation for
the complete Kernel tree.
So, I'm sending a followup patch that makes it a lot better by using
one perl thread per CPU thread.
Before such patch, running this command:
$ /usr/bin/time --format='%C took %e seconds' ./scripts/check_docs_external_symbols drivers/gpu/drm/
It takes:
./scripts/check_docs_external_symbols drivers/gpu/drm/ took 1218.96 seconds
After the patch:
./scripts/check_docs_external_symbols drivers/gpu/drm/ took 102.04 seconds
measured on a machine with a machine with a Xeon(R) W-2133 CPU @ 3.60GHz
(12 CPU threads), with normal HDD.
> Suggested-by: Matthew Wilcox <willy@infradead.org>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Thanks,
Mauro
next prev parent reply other threads:[~2020-10-08 10:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-07 11:29 [PATCH v2] script: add a script for checking doc problems with external functions Mauro Carvalho Chehab
2020-10-07 11:56 ` Mauro Carvalho Chehab
2020-10-07 13:31 ` [PATCH v3] " Mauro Carvalho Chehab
2020-10-08 10:29 ` Mauro Carvalho Chehab [this message]
2020-10-08 10:30 ` [PATCH] scripts: check_docs_external_symbols: speed up its execution Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201008122931.369b628d@coco.lan \
--to=mchehab+huawei@kernel.org \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.