From: Florian Westphal <fw@strlen.de>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf] selftests: netfilter: extend nfqueue test case
Date: Thu, 8 Oct 2020 18:20:50 +0200 [thread overview]
Message-ID: <20201008162050.GA5723@breakpoint.cc> (raw)
In-Reply-To: <20201008154459.17410-1-fw@strlen.de>
Florian Westphal <fw@strlen.de> wrote:
> +static void sleep_ms(uint32_t delay)
> +{
> + struct timespec ts = { .tv_nsec = delay * 1000llu * 1000llu };
> +
> + nanosleep(&ts, NULL);
This doesn't work if delay is larger than 1s.
Not triggered by current test case, but better to avoid this.
I will send a v2 later.
prev parent reply other threads:[~2020-10-08 16:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 15:44 [PATCH nf] selftests: netfilter: extend nfqueue test case Florian Westphal
2020-10-08 16:20 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201008162050.GA5723@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.