From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 8 Oct 2020 18:44:40 +0200 From: Gerald Schaefer Subject: Re: [PATCH 08/13] s390/pci: Remove races against pte updates Message-ID: <20201008184440.4c3bebed@thinkpad> In-Reply-To: <20201007164426.1812530-9-daniel.vetter@ffwll.ch> References: <20201007164426.1812530-1-daniel.vetter@ffwll.ch> <20201007164426.1812530-9-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable List-ID: To: Daniel Vetter Cc: DRI Development , LKML , kvm@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-media@vger.kernel.org, linux-s390@vger.kernel.org, Daniel Vetter , Jason Gunthorpe , Dan Williams , Kees Cook , Andrew Morton , John Hubbard , =?UTF-8?B?SsOpcsO0bWU=?= Glisse , Jan Kara , Niklas Schnelle On Wed, 7 Oct 2020 18:44:21 +0200 Daniel Vetter wrote: > Way back it was a reasonable assumptions that iomem mappings never > change the pfn range they point at. But this has changed: >=20 > - gpu drivers dynamically manage their memory nowadays, invalidating > ptes with unmap_mapping_range when buffers get moved >=20 > - contiguous dma allocations have moved from dedicated carvetouts to > cma regions. This means if we miss the unmap the pfn might contain > pagecache or anon memory (well anything allocated with GFP_MOVEABLE) >=20 > - even /dev/mem now invalidates mappings when the kernel requests that > iomem region when CONFIG_IO_STRICT_DEVMEM is set, see 3234ac664a87 > ("/dev/mem: Revoke mappings when a driver claims the region") >=20 > Accessing pfns obtained from ptes without holding all the locks is > therefore no longer a good idea. Fix this. >=20 > Since zpci_memcpy_from|toio seems to not do anything nefarious with > locks we just need to open code get_pfn and follow_pfn and make sure > we drop the locks only after we've done. The write function also needs > the copy_from_user move, since we can't take userspace faults while > holding the mmap sem. >=20 > Signed-off-by: Daniel Vetter > Cc: Jason Gunthorpe > Cc: Dan Williams > Cc: Kees Cook > Cc: Andrew Morton > Cc: John Hubbard > Cc: J=C3=A9r=C3=B4me Glisse > Cc: Jan Kara > Cc: Dan Williams > Cc: linux-mm@kvack.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-samsung-soc@vger.kernel.org > Cc: linux-media@vger.kernel.org > Cc: Niklas Schnelle > Cc: Gerald Schaefer > Cc: linux-s390@vger.kernel.org > --- > arch/s390/pci/pci_mmio.c | 98 +++++++++++++++++++++++----------------- > 1 file changed, 57 insertions(+), 41 deletions(-) Looks good, thanks. Also survived some basic function test. Only some minor nitpick, see below. Reviewed-by: Gerald Schaefer >=20 > diff --git a/arch/s390/pci/pci_mmio.c b/arch/s390/pci/pci_mmio.c > index 401cf670a243..4d194cb09372 100644 > --- a/arch/s390/pci/pci_mmio.c > +++ b/arch/s390/pci/pci_mmio.c > @@ -119,33 +119,15 @@ static inline int __memcpy_toio_inuser(void __iomem= *dst, > return rc; > } > =20 > -static long get_pfn(unsigned long user_addr, unsigned long access, > - unsigned long *pfn) > -{ > - struct vm_area_struct *vma; > - long ret; > - > - mmap_read_lock(current->mm); > - ret =3D -EINVAL; > - vma =3D find_vma(current->mm, user_addr); > - if (!vma) > - goto out; > - ret =3D -EACCES; > - if (!(vma->vm_flags & access)) > - goto out; > - ret =3D follow_pfn(vma, user_addr, pfn); > -out: > - mmap_read_unlock(current->mm); > - return ret; > -} > - > SYSCALL_DEFINE3(s390_pci_mmio_write, unsigned long, mmio_addr, > const void __user *, user_buffer, size_t, length) > { > u8 local_buf[64]; > void __iomem *io_addr; > void *buf; > - unsigned long pfn; > + struct vm_area_struct *vma; > + pte_t *ptep; > + spinlock_t *ptl; > long ret; > =20 > if (!zpci_is_enabled()) > @@ -158,7 +140,7 @@ SYSCALL_DEFINE3(s390_pci_mmio_write, unsigned long, m= mio_addr, > * We only support write access to MIO capable devices if we are on > * a MIO enabled system. Otherwise we would have to check for every > * address if it is a special ZPCI_ADDR and would have to do > - * a get_pfn() which we don't need for MIO capable devices. Currently > + * a pfn lookup which we don't need for MIO capable devices. Currently > * ISM devices are the only devices without MIO support and there is no > * known need for accessing these from userspace. > */ > @@ -176,21 +158,37 @@ SYSCALL_DEFINE3(s390_pci_mmio_write, unsigned long,= mmio_addr, > } else > buf =3D local_buf; > =20 > - ret =3D get_pfn(mmio_addr, VM_WRITE, &pfn); > + ret =3D -EFAULT; > + if (copy_from_user(buf, user_buffer, length)) > + goto out_free; > + > + mmap_read_lock(current->mm); > + ret =3D -EINVAL; > + vma =3D find_vma(current->mm, mmio_addr); > + if (!vma) > + goto out_unlock_mmap; > + ret =3D -EACCES; > + if (!(vma->vm_flags & VM_WRITE)) > + goto out_unlock_mmap; > + if (!(vma->vm_flags & (VM_IO | VM_PFNMAP))) > + goto out_unlock_mmap; That check for VM_IO | VM_PFNMAP was previously hidden inside follow_pfn(), and that would have returned -EINVAL in this case. With your change, we now return -EACCES. Not sure how important that is, but it feels wrong. Maybe move the VM_IO | VM_PFNMAP check up, before the ret =3D -EACCES? [...] > @@ -306,22 +306,38 @@ SYSCALL_DEFINE3(s390_pci_mmio_read, unsigned long, = mmio_addr, > buf =3D local_buf; > } > =20 > - ret =3D get_pfn(mmio_addr, VM_READ, &pfn); > + mmap_read_lock(current->mm); > + ret =3D -EINVAL; > + vma =3D find_vma(current->mm, mmio_addr); > + if (!vma) > + goto out_unlock_mmap; > + ret =3D -EACCES; > + if (!(vma->vm_flags & VM_WRITE)) > + goto out_unlock_mmap; > + if (!(vma->vm_flags & (VM_IO | VM_PFNMAP))) > + goto out_unlock_mmap; Same here with VM_IO | VM_PFNMAP and -EINVAL. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA049C433DF for ; Thu, 8 Oct 2020 16:46:47 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 384D421D7D for ; Thu, 8 Oct 2020 16:46:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CejojfPK"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="Wg15T8U9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 384D421D7D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=E54gVhKzBMsCYm3y3n6y7hM7HAk5VDQxN4/Fgv1DvVs=; b=CejojfPKigL4e1eIw/0jNASLl UY1C62RUckJJM+4IxwhzhrDPssy1j05dimeah7x8F9emHA5VsUCceIJIc84Va8UWqxw/pKFtpSqCe /lpMTMZdUSJEPSntS4U5WsbIfA35BrLaNHCGZ4O4Pcyn8/2AK2+XYUXI6MSse8X/YZ975SG/zdvPL oVgk1NrDWC1JQtff801eU+mNttrC3LtqbmyCoSKR3tKFdmLH2snFi455/HPWCetdAvtcgQfc0WyP5 a0qOdfkZ91PHqFMViNsTnTzkskLKKz8QzJxVK97HcAnIs7EQHuRE3rWKjcccOc/PhO+/buOeDG7HZ hqXH5fRtg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQZ2Q-0004kz-4n; Thu, 08 Oct 2020 16:45:06 +0000 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5] helo=mx0a-001b2d01.pphosted.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQZ2J-0004hg-8e for linux-arm-kernel@lists.infradead.org; Thu, 08 Oct 2020 16:45:02 +0000 Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 098GWc25119610; Thu, 8 Oct 2020 12:44:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=pp1; bh=DOjfJtmqn0RgphxiIiG0Kv2UKoYLCpYcT9ErIqcce6E=; b=Wg15T8U9KQDXgs4QwB8A79tlx7vkXl3sj9pFh/1cOPLlDjrtMPxkA1D6agqTMMOzRLf7 NUnasH/5LgKXjRmsfdo8cPf3xCzwhbuxs2Z8DTZRnSWg8WMLVLxLDsVASnHBlnfZGWD5 nrHVw4Mrev3JAPk1tZjw4hdG2ZoVozDpaXbDoW6prAYwvRRF53bIbj4IQ+PJoDUQZgJ/ f6GjUgeB+MO2nhKeRhvObJsiHly0uBtE1AQCa31NxixXKdyjB9iU/pTGQ4Mz3rer6W96 eRSBZOyfkkXDhLNgYJTHugguwBIeLDnByF/lWwzsCaKdh5SLKVgxMPNkdzNTGJCVQ2v3 1g== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 34263q8xd7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 08 Oct 2020 12:44:48 -0400 Received: from m0098416.ppops.net (m0098416.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 098GgIad150220; Thu, 8 Oct 2020 12:44:47 -0400 Received: from ppma03fra.de.ibm.com (6b.4a.5195.ip4.static.sl-reverse.com [149.81.74.107]) by mx0b-001b2d01.pphosted.com with ESMTP id 34263q8xbq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 08 Oct 2020 12:44:47 -0400 Received: from pps.filterd (ppma03fra.de.ibm.com [127.0.0.1]) by ppma03fra.de.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 098Gclfr009991; Thu, 8 Oct 2020 16:44:45 GMT Received: from b06avi18626390.portsmouth.uk.ibm.com (b06avi18626390.portsmouth.uk.ibm.com [9.149.26.192]) by ppma03fra.de.ibm.com with ESMTP id 33xgx7tw34-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 08 Oct 2020 16:44:45 +0000 Received: from b06wcsmtp001.portsmouth.uk.ibm.com (b06wcsmtp001.portsmouth.uk.ibm.com [9.149.105.160]) by b06avi18626390.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 098GigqX33817070 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 8 Oct 2020 16:44:42 GMT Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C9995A405F; Thu, 8 Oct 2020 16:44:42 +0000 (GMT) Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 23192A4065; Thu, 8 Oct 2020 16:44:42 +0000 (GMT) Received: from thinkpad (unknown [9.171.64.67]) by b06wcsmtp001.portsmouth.uk.ibm.com (Postfix) with SMTP; Thu, 8 Oct 2020 16:44:42 +0000 (GMT) Date: Thu, 8 Oct 2020 18:44:40 +0200 From: Gerald Schaefer To: Daniel Vetter Subject: Re: [PATCH 08/13] s390/pci: Remove races against pte updates Message-ID: <20201008184440.4c3bebed@thinkpad> In-Reply-To: <20201007164426.1812530-9-daniel.vetter@ffwll.ch> References: <20201007164426.1812530-1-daniel.vetter@ffwll.ch> <20201007164426.1812530-9-daniel.vetter@ffwll.ch> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687 definitions=2020-10-08_11:2020-10-08, 2020-10-08 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 malwarescore=0 spamscore=0 priorityscore=1501 suspectscore=2 mlxscore=0 impostorscore=0 clxscore=1011 phishscore=0 bulkscore=0 mlxlogscore=999 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2010080120 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201008_124459_395331_B2B35BD1 X-CRM114-Status: GOOD ( 35.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-s390@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Jan Kara , Kees Cook , kvm@vger.kernel.org, Jason Gunthorpe , John Hubbard , Niklas Schnelle , LKML , DRI Development , linux-mm@kvack.org, =?UTF-8?B?SsOpcsO0bWU=?= Glisse , Daniel Vetter , Dan Williams , Andrew Morton , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCAgNyBPY3QgMjAyMCAxODo0NDoyMSArMDIwMApEYW5pZWwgVmV0dGVyIDxkYW5pZWwu dmV0dGVyQGZmd2xsLmNoPiB3cm90ZToKCj4gV2F5IGJhY2sgaXQgd2FzIGEgcmVhc29uYWJsZSBh c3N1bXB0aW9ucyB0aGF0IGlvbWVtIG1hcHBpbmdzIG5ldmVyCj4gY2hhbmdlIHRoZSBwZm4gcmFu Z2UgdGhleSBwb2ludCBhdC4gQnV0IHRoaXMgaGFzIGNoYW5nZWQ6Cj4gCj4gLSBncHUgZHJpdmVy cyBkeW5hbWljYWxseSBtYW5hZ2UgdGhlaXIgbWVtb3J5IG5vd2FkYXlzLCBpbnZhbGlkYXRpbmcK PiBwdGVzIHdpdGggdW5tYXBfbWFwcGluZ19yYW5nZSB3aGVuIGJ1ZmZlcnMgZ2V0IG1vdmVkCj4g Cj4gLSBjb250aWd1b3VzIGRtYSBhbGxvY2F0aW9ucyBoYXZlIG1vdmVkIGZyb20gZGVkaWNhdGVk IGNhcnZldG91dHMgdG8KPiBjbWEgcmVnaW9ucy4gVGhpcyBtZWFucyBpZiB3ZSBtaXNzIHRoZSB1 bm1hcCB0aGUgcGZuIG1pZ2h0IGNvbnRhaW4KPiBwYWdlY2FjaGUgb3IgYW5vbiBtZW1vcnkgKHdl bGwgYW55dGhpbmcgYWxsb2NhdGVkIHdpdGggR0ZQX01PVkVBQkxFKQo+IAo+IC0gZXZlbiAvZGV2 L21lbSBub3cgaW52YWxpZGF0ZXMgbWFwcGluZ3Mgd2hlbiB0aGUga2VybmVsIHJlcXVlc3RzIHRo YXQKPiBpb21lbSByZWdpb24gd2hlbiBDT05GSUdfSU9fU1RSSUNUX0RFVk1FTSBpcyBzZXQsIHNl ZSAzMjM0YWM2NjRhODcKPiAoIi9kZXYvbWVtOiBSZXZva2UgbWFwcGluZ3Mgd2hlbiBhIGRyaXZl ciBjbGFpbXMgdGhlIHJlZ2lvbiIpCj4gCj4gQWNjZXNzaW5nIHBmbnMgb2J0YWluZWQgZnJvbSBw dGVzIHdpdGhvdXQgaG9sZGluZyBhbGwgdGhlIGxvY2tzIGlzCj4gdGhlcmVmb3JlIG5vIGxvbmdl ciBhIGdvb2QgaWRlYS4gRml4IHRoaXMuCj4gCj4gU2luY2UgenBjaV9tZW1jcHlfZnJvbXx0b2lv IHNlZW1zIHRvIG5vdCBkbyBhbnl0aGluZyBuZWZhcmlvdXMgd2l0aAo+IGxvY2tzIHdlIGp1c3Qg bmVlZCB0byBvcGVuIGNvZGUgZ2V0X3BmbiBhbmQgZm9sbG93X3BmbiBhbmQgbWFrZSBzdXJlCj4g d2UgZHJvcCB0aGUgbG9ja3Mgb25seSBhZnRlciB3ZSd2ZSBkb25lLiBUaGUgd3JpdGUgZnVuY3Rp b24gYWxzbyBuZWVkcwo+IHRoZSBjb3B5X2Zyb21fdXNlciBtb3ZlLCBzaW5jZSB3ZSBjYW4ndCB0 YWtlIHVzZXJzcGFjZSBmYXVsdHMgd2hpbGUKPiBob2xkaW5nIHRoZSBtbWFwIHNlbS4KPiAKPiBT aWduZWQtb2ZmLWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGludGVsLmNvbT4KPiBD YzogSmFzb24gR3VudGhvcnBlIDxqZ2dAemllcGUuY2E+Cj4gQ2M6IERhbiBXaWxsaWFtcyA8ZGFu Lmoud2lsbGlhbXNAaW50ZWwuY29tPgo+IENjOiBLZWVzIENvb2sgPGtlZXNjb29rQGNocm9taXVt Lm9yZz4KPiBDYzogQW5kcmV3IE1vcnRvbiA8YWtwbUBsaW51eC1mb3VuZGF0aW9uLm9yZz4KPiBD YzogSm9obiBIdWJiYXJkIDxqaHViYmFyZEBudmlkaWEuY29tPgo+IENjOiBKw6lyw7RtZSBHbGlz c2UgPGpnbGlzc2VAcmVkaGF0LmNvbT4KPiBDYzogSmFuIEthcmEgPGphY2tAc3VzZS5jej4KPiBD YzogRGFuIFdpbGxpYW1zIDxkYW4uai53aWxsaWFtc0BpbnRlbC5jb20+Cj4gQ2M6IGxpbnV4LW1t QGt2YWNrLm9yZwo+IENjOiBsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKPiBD YzogbGludXgtc2Ftc3VuZy1zb2NAdmdlci5rZXJuZWwub3JnCj4gQ2M6IGxpbnV4LW1lZGlhQHZn ZXIua2VybmVsLm9yZwo+IENjOiBOaWtsYXMgU2NobmVsbGUgPHNjaG5lbGxlQGxpbnV4LmlibS5j b20+Cj4gQ2M6IEdlcmFsZCBTY2hhZWZlciA8Z2VyYWxkLnNjaGFlZmVyQGxpbnV4LmlibS5jb20+ Cj4gQ2M6IGxpbnV4LXMzOTBAdmdlci5rZXJuZWwub3JnCj4gLS0tCj4gIGFyY2gvczM5MC9wY2kv cGNpX21taW8uYyB8IDk4ICsrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0K PiAgMSBmaWxlIGNoYW5nZWQsIDU3IGluc2VydGlvbnMoKyksIDQxIGRlbGV0aW9ucygtKQoKTG9v a3MgZ29vZCwgdGhhbmtzLiBBbHNvIHN1cnZpdmVkIHNvbWUgYmFzaWMgZnVuY3Rpb24gdGVzdC4g T25seSBzb21lCm1pbm9yIG5pdHBpY2ssIHNlZSBiZWxvdy4KClJldmlld2VkLWJ5OiBHZXJhbGQg U2NoYWVmZXIgPGdlcmFsZC5zY2hhZWZlckBsaW51eC5pYm0uY29tPgoKPiAKPiBkaWZmIC0tZ2l0 IGEvYXJjaC9zMzkwL3BjaS9wY2lfbW1pby5jIGIvYXJjaC9zMzkwL3BjaS9wY2lfbW1pby5jCj4g aW5kZXggNDAxY2Y2NzBhMjQzLi40ZDE5NGNiMDkzNzIgMTAwNjQ0Cj4gLS0tIGEvYXJjaC9zMzkw L3BjaS9wY2lfbW1pby5jCj4gKysrIGIvYXJjaC9zMzkwL3BjaS9wY2lfbW1pby5jCj4gQEAgLTEx OSwzMyArMTE5LDE1IEBAIHN0YXRpYyBpbmxpbmUgaW50IF9fbWVtY3B5X3RvaW9faW51c2VyKHZv aWQgX19pb21lbSAqZHN0LAo+ICAJcmV0dXJuIHJjOwo+ICB9Cj4gIAo+IC1zdGF0aWMgbG9uZyBn ZXRfcGZuKHVuc2lnbmVkIGxvbmcgdXNlcl9hZGRyLCB1bnNpZ25lZCBsb25nIGFjY2VzcywKPiAt CQkgICAgdW5zaWduZWQgbG9uZyAqcGZuKQo+IC17Cj4gLQlzdHJ1Y3Qgdm1fYXJlYV9zdHJ1Y3Qg KnZtYTsKPiAtCWxvbmcgcmV0Owo+IC0KPiAtCW1tYXBfcmVhZF9sb2NrKGN1cnJlbnQtPm1tKTsK PiAtCXJldCA9IC1FSU5WQUw7Cj4gLQl2bWEgPSBmaW5kX3ZtYShjdXJyZW50LT5tbSwgdXNlcl9h ZGRyKTsKPiAtCWlmICghdm1hKQo+IC0JCWdvdG8gb3V0Owo+IC0JcmV0ID0gLUVBQ0NFUzsKPiAt CWlmICghKHZtYS0+dm1fZmxhZ3MgJiBhY2Nlc3MpKQo+IC0JCWdvdG8gb3V0Owo+IC0JcmV0ID0g Zm9sbG93X3Bmbih2bWEsIHVzZXJfYWRkciwgcGZuKTsKPiAtb3V0Ogo+IC0JbW1hcF9yZWFkX3Vu bG9jayhjdXJyZW50LT5tbSk7Cj4gLQlyZXR1cm4gcmV0Owo+IC19Cj4gLQo+ICBTWVNDQUxMX0RF RklORTMoczM5MF9wY2lfbW1pb193cml0ZSwgdW5zaWduZWQgbG9uZywgbW1pb19hZGRyLAo+ICAJ CWNvbnN0IHZvaWQgX191c2VyICosIHVzZXJfYnVmZmVyLCBzaXplX3QsIGxlbmd0aCkKPiAgewo+ ICAJdTggbG9jYWxfYnVmWzY0XTsKPiAgCXZvaWQgX19pb21lbSAqaW9fYWRkcjsKPiAgCXZvaWQg KmJ1ZjsKPiAtCXVuc2lnbmVkIGxvbmcgcGZuOwo+ICsJc3RydWN0IHZtX2FyZWFfc3RydWN0ICp2 bWE7Cj4gKwlwdGVfdCAqcHRlcDsKPiArCXNwaW5sb2NrX3QgKnB0bDsKPiAgCWxvbmcgcmV0Owo+ ICAKPiAgCWlmICghenBjaV9pc19lbmFibGVkKCkpCj4gQEAgLTE1OCw3ICsxNDAsNyBAQCBTWVND QUxMX0RFRklORTMoczM5MF9wY2lfbW1pb193cml0ZSwgdW5zaWduZWQgbG9uZywgbW1pb19hZGRy LAo+ICAJICogV2Ugb25seSBzdXBwb3J0IHdyaXRlIGFjY2VzcyB0byBNSU8gY2FwYWJsZSBkZXZp Y2VzIGlmIHdlIGFyZSBvbgo+ICAJICogYSBNSU8gZW5hYmxlZCBzeXN0ZW0uIE90aGVyd2lzZSB3 ZSB3b3VsZCBoYXZlIHRvIGNoZWNrIGZvciBldmVyeQo+ICAJICogYWRkcmVzcyBpZiBpdCBpcyBh IHNwZWNpYWwgWlBDSV9BRERSIGFuZCB3b3VsZCBoYXZlIHRvIGRvCj4gLQkgKiBhIGdldF9wZm4o KSB3aGljaCB3ZSBkb24ndCBuZWVkIGZvciBNSU8gY2FwYWJsZSBkZXZpY2VzLiAgQ3VycmVudGx5 Cj4gKwkgKiBhIHBmbiBsb29rdXAgd2hpY2ggd2UgZG9uJ3QgbmVlZCBmb3IgTUlPIGNhcGFibGUg ZGV2aWNlcy4gIEN1cnJlbnRseQo+ICAJICogSVNNIGRldmljZXMgYXJlIHRoZSBvbmx5IGRldmlj ZXMgd2l0aG91dCBNSU8gc3VwcG9ydCBhbmQgdGhlcmUgaXMgbm8KPiAgCSAqIGtub3duIG5lZWQg Zm9yIGFjY2Vzc2luZyB0aGVzZSBmcm9tIHVzZXJzcGFjZS4KPiAgCSAqLwo+IEBAIC0xNzYsMjEg KzE1OCwzNyBAQCBTWVNDQUxMX0RFRklORTMoczM5MF9wY2lfbW1pb193cml0ZSwgdW5zaWduZWQg bG9uZywgbW1pb19hZGRyLAo+ICAJfSBlbHNlCj4gIAkJYnVmID0gbG9jYWxfYnVmOwo+ICAKPiAt CXJldCA9IGdldF9wZm4obW1pb19hZGRyLCBWTV9XUklURSwgJnBmbik7Cj4gKwlyZXQgPSAtRUZB VUxUOwo+ICsJaWYgKGNvcHlfZnJvbV91c2VyKGJ1ZiwgdXNlcl9idWZmZXIsIGxlbmd0aCkpCj4g KwkJZ290byBvdXRfZnJlZTsKPiArCj4gKwltbWFwX3JlYWRfbG9jayhjdXJyZW50LT5tbSk7Cj4g KwlyZXQgPSAtRUlOVkFMOwo+ICsJdm1hID0gZmluZF92bWEoY3VycmVudC0+bW0sIG1taW9fYWRk cik7Cj4gKwlpZiAoIXZtYSkKPiArCQlnb3RvIG91dF91bmxvY2tfbW1hcDsKPiArCXJldCA9IC1F QUNDRVM7Cj4gKwlpZiAoISh2bWEtPnZtX2ZsYWdzICYgVk1fV1JJVEUpKQo+ICsJCWdvdG8gb3V0 X3VubG9ja19tbWFwOwo+ICsJaWYgKCEodm1hLT52bV9mbGFncyAmIChWTV9JTyB8IFZNX1BGTk1B UCkpKQo+ICsJCWdvdG8gb3V0X3VubG9ja19tbWFwOwoKVGhhdCBjaGVjayBmb3IgVk1fSU8gfCBW TV9QRk5NQVAgd2FzIHByZXZpb3VzbHkgaGlkZGVuIGluc2lkZSBmb2xsb3dfcGZuKCksCmFuZCB0 aGF0IHdvdWxkIGhhdmUgcmV0dXJuZWQgLUVJTlZBTCBpbiB0aGlzIGNhc2UuIFdpdGggeW91ciBj aGFuZ2UsIHdlCm5vdyByZXR1cm4gLUVBQ0NFUy4gTm90IHN1cmUgaG93IGltcG9ydGFudCB0aGF0 IGlzLCBidXQgaXQgZmVlbHMgd3JvbmcuCk1heWJlIG1vdmUgdGhlIFZNX0lPIHwgVk1fUEZOTUFQ IGNoZWNrIHVwLCBiZWZvcmUgdGhlIHJldCA9IC1FQUNDRVM/CgpbLi4uXQo+IEBAIC0zMDYsMjIg KzMwNiwzOCBAQCBTWVNDQUxMX0RFRklORTMoczM5MF9wY2lfbW1pb19yZWFkLCB1bnNpZ25lZCBs b25nLCBtbWlvX2FkZHIsCj4gIAkJYnVmID0gbG9jYWxfYnVmOwo+ICAJfQo+ICAKPiAtCXJldCA9 IGdldF9wZm4obW1pb19hZGRyLCBWTV9SRUFELCAmcGZuKTsKPiArCW1tYXBfcmVhZF9sb2NrKGN1 cnJlbnQtPm1tKTsKPiArCXJldCA9IC1FSU5WQUw7Cj4gKwl2bWEgPSBmaW5kX3ZtYShjdXJyZW50 LT5tbSwgbW1pb19hZGRyKTsKPiArCWlmICghdm1hKQo+ICsJCWdvdG8gb3V0X3VubG9ja19tbWFw Owo+ICsJcmV0ID0gLUVBQ0NFUzsKPiArCWlmICghKHZtYS0+dm1fZmxhZ3MgJiBWTV9XUklURSkp Cj4gKwkJZ290byBvdXRfdW5sb2NrX21tYXA7Cj4gKwlpZiAoISh2bWEtPnZtX2ZsYWdzICYgKFZN X0lPIHwgVk1fUEZOTUFQKSkpCj4gKwkJZ290byBvdXRfdW5sb2NrX21tYXA7CgpTYW1lIGhlcmUg d2l0aCBWTV9JTyB8IFZNX1BGTk1BUCBhbmQgLUVJTlZBTC4KCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0 CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFk ZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5601DC43457 for ; Fri, 9 Oct 2020 07:30:32 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B64A822265 for ; Fri, 9 Oct 2020 07:30:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="Wg15T8U9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B64A822265 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3954F6EC5F; Fri, 9 Oct 2020 07:30:02 +0000 (UTC) Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by gabe.freedesktop.org (Postfix) with ESMTPS id EA53B6EA96 for ; Thu, 8 Oct 2020 16:44:56 +0000 (UTC) Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 098GWc25119610; Thu, 8 Oct 2020 12:44:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=pp1; bh=DOjfJtmqn0RgphxiIiG0Kv2UKoYLCpYcT9ErIqcce6E=; b=Wg15T8U9KQDXgs4QwB8A79tlx7vkXl3sj9pFh/1cOPLlDjrtMPxkA1D6agqTMMOzRLf7 NUnasH/5LgKXjRmsfdo8cPf3xCzwhbuxs2Z8DTZRnSWg8WMLVLxLDsVASnHBlnfZGWD5 nrHVw4Mrev3JAPk1tZjw4hdG2ZoVozDpaXbDoW6prAYwvRRF53bIbj4IQ+PJoDUQZgJ/ f6GjUgeB+MO2nhKeRhvObJsiHly0uBtE1AQCa31NxixXKdyjB9iU/pTGQ4Mz3rer6W96 eRSBZOyfkkXDhLNgYJTHugguwBIeLDnByF/lWwzsCaKdh5SLKVgxMPNkdzNTGJCVQ2v3 1g== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 34263q8xd7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 08 Oct 2020 12:44:48 -0400 Received: from m0098416.ppops.net (m0098416.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 098GgIad150220; Thu, 8 Oct 2020 12:44:47 -0400 Received: from ppma03fra.de.ibm.com (6b.4a.5195.ip4.static.sl-reverse.com [149.81.74.107]) by mx0b-001b2d01.pphosted.com with ESMTP id 34263q8xbq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 08 Oct 2020 12:44:47 -0400 Received: from pps.filterd (ppma03fra.de.ibm.com [127.0.0.1]) by ppma03fra.de.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 098Gclfr009991; Thu, 8 Oct 2020 16:44:45 GMT Received: from b06avi18626390.portsmouth.uk.ibm.com (b06avi18626390.portsmouth.uk.ibm.com [9.149.26.192]) by ppma03fra.de.ibm.com with ESMTP id 33xgx7tw34-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 08 Oct 2020 16:44:45 +0000 Received: from b06wcsmtp001.portsmouth.uk.ibm.com (b06wcsmtp001.portsmouth.uk.ibm.com [9.149.105.160]) by b06avi18626390.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 098GigqX33817070 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 8 Oct 2020 16:44:42 GMT Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C9995A405F; Thu, 8 Oct 2020 16:44:42 +0000 (GMT) Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 23192A4065; Thu, 8 Oct 2020 16:44:42 +0000 (GMT) Received: from thinkpad (unknown [9.171.64.67]) by b06wcsmtp001.portsmouth.uk.ibm.com (Postfix) with SMTP; Thu, 8 Oct 2020 16:44:42 +0000 (GMT) Date: Thu, 8 Oct 2020 18:44:40 +0200 From: Gerald Schaefer To: Daniel Vetter Subject: Re: [PATCH 08/13] s390/pci: Remove races against pte updates Message-ID: <20201008184440.4c3bebed@thinkpad> In-Reply-To: <20201007164426.1812530-9-daniel.vetter@ffwll.ch> References: <20201007164426.1812530-1-daniel.vetter@ffwll.ch> <20201007164426.1812530-9-daniel.vetter@ffwll.ch> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687 definitions=2020-10-08_11:2020-10-08, 2020-10-08 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 malwarescore=0 spamscore=0 priorityscore=1501 suspectscore=2 mlxscore=0 impostorscore=0 clxscore=1011 phishscore=0 bulkscore=0 mlxlogscore=999 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2010080120 X-Mailman-Approved-At: Fri, 09 Oct 2020 07:29:53 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-s390@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Jan Kara , Kees Cook , kvm@vger.kernel.org, Jason Gunthorpe , John Hubbard , Niklas Schnelle , LKML , DRI Development , linux-mm@kvack.org, =?UTF-8?B?SsOpcsO0bWU=?= Glisse , Daniel Vetter , Dan Williams , Andrew Morton , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gV2VkLCAgNyBPY3QgMjAyMCAxODo0NDoyMSArMDIwMApEYW5pZWwgVmV0dGVyIDxkYW5pZWwu dmV0dGVyQGZmd2xsLmNoPiB3cm90ZToKCj4gV2F5IGJhY2sgaXQgd2FzIGEgcmVhc29uYWJsZSBh c3N1bXB0aW9ucyB0aGF0IGlvbWVtIG1hcHBpbmdzIG5ldmVyCj4gY2hhbmdlIHRoZSBwZm4gcmFu Z2UgdGhleSBwb2ludCBhdC4gQnV0IHRoaXMgaGFzIGNoYW5nZWQ6Cj4gCj4gLSBncHUgZHJpdmVy cyBkeW5hbWljYWxseSBtYW5hZ2UgdGhlaXIgbWVtb3J5IG5vd2FkYXlzLCBpbnZhbGlkYXRpbmcK PiBwdGVzIHdpdGggdW5tYXBfbWFwcGluZ19yYW5nZSB3aGVuIGJ1ZmZlcnMgZ2V0IG1vdmVkCj4g Cj4gLSBjb250aWd1b3VzIGRtYSBhbGxvY2F0aW9ucyBoYXZlIG1vdmVkIGZyb20gZGVkaWNhdGVk IGNhcnZldG91dHMgdG8KPiBjbWEgcmVnaW9ucy4gVGhpcyBtZWFucyBpZiB3ZSBtaXNzIHRoZSB1 bm1hcCB0aGUgcGZuIG1pZ2h0IGNvbnRhaW4KPiBwYWdlY2FjaGUgb3IgYW5vbiBtZW1vcnkgKHdl bGwgYW55dGhpbmcgYWxsb2NhdGVkIHdpdGggR0ZQX01PVkVBQkxFKQo+IAo+IC0gZXZlbiAvZGV2 L21lbSBub3cgaW52YWxpZGF0ZXMgbWFwcGluZ3Mgd2hlbiB0aGUga2VybmVsIHJlcXVlc3RzIHRo YXQKPiBpb21lbSByZWdpb24gd2hlbiBDT05GSUdfSU9fU1RSSUNUX0RFVk1FTSBpcyBzZXQsIHNl ZSAzMjM0YWM2NjRhODcKPiAoIi9kZXYvbWVtOiBSZXZva2UgbWFwcGluZ3Mgd2hlbiBhIGRyaXZl ciBjbGFpbXMgdGhlIHJlZ2lvbiIpCj4gCj4gQWNjZXNzaW5nIHBmbnMgb2J0YWluZWQgZnJvbSBw dGVzIHdpdGhvdXQgaG9sZGluZyBhbGwgdGhlIGxvY2tzIGlzCj4gdGhlcmVmb3JlIG5vIGxvbmdl ciBhIGdvb2QgaWRlYS4gRml4IHRoaXMuCj4gCj4gU2luY2UgenBjaV9tZW1jcHlfZnJvbXx0b2lv IHNlZW1zIHRvIG5vdCBkbyBhbnl0aGluZyBuZWZhcmlvdXMgd2l0aAo+IGxvY2tzIHdlIGp1c3Qg bmVlZCB0byBvcGVuIGNvZGUgZ2V0X3BmbiBhbmQgZm9sbG93X3BmbiBhbmQgbWFrZSBzdXJlCj4g d2UgZHJvcCB0aGUgbG9ja3Mgb25seSBhZnRlciB3ZSd2ZSBkb25lLiBUaGUgd3JpdGUgZnVuY3Rp b24gYWxzbyBuZWVkcwo+IHRoZSBjb3B5X2Zyb21fdXNlciBtb3ZlLCBzaW5jZSB3ZSBjYW4ndCB0 YWtlIHVzZXJzcGFjZSBmYXVsdHMgd2hpbGUKPiBob2xkaW5nIHRoZSBtbWFwIHNlbS4KPiAKPiBT aWduZWQtb2ZmLWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGludGVsLmNvbT4KPiBD YzogSmFzb24gR3VudGhvcnBlIDxqZ2dAemllcGUuY2E+Cj4gQ2M6IERhbiBXaWxsaWFtcyA8ZGFu Lmoud2lsbGlhbXNAaW50ZWwuY29tPgo+IENjOiBLZWVzIENvb2sgPGtlZXNjb29rQGNocm9taXVt Lm9yZz4KPiBDYzogQW5kcmV3IE1vcnRvbiA8YWtwbUBsaW51eC1mb3VuZGF0aW9uLm9yZz4KPiBD YzogSm9obiBIdWJiYXJkIDxqaHViYmFyZEBudmlkaWEuY29tPgo+IENjOiBKw6lyw7RtZSBHbGlz c2UgPGpnbGlzc2VAcmVkaGF0LmNvbT4KPiBDYzogSmFuIEthcmEgPGphY2tAc3VzZS5jej4KPiBD YzogRGFuIFdpbGxpYW1zIDxkYW4uai53aWxsaWFtc0BpbnRlbC5jb20+Cj4gQ2M6IGxpbnV4LW1t QGt2YWNrLm9yZwo+IENjOiBsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKPiBD YzogbGludXgtc2Ftc3VuZy1zb2NAdmdlci5rZXJuZWwub3JnCj4gQ2M6IGxpbnV4LW1lZGlhQHZn ZXIua2VybmVsLm9yZwo+IENjOiBOaWtsYXMgU2NobmVsbGUgPHNjaG5lbGxlQGxpbnV4LmlibS5j b20+Cj4gQ2M6IEdlcmFsZCBTY2hhZWZlciA8Z2VyYWxkLnNjaGFlZmVyQGxpbnV4LmlibS5jb20+ Cj4gQ2M6IGxpbnV4LXMzOTBAdmdlci5rZXJuZWwub3JnCj4gLS0tCj4gIGFyY2gvczM5MC9wY2kv cGNpX21taW8uYyB8IDk4ICsrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0K PiAgMSBmaWxlIGNoYW5nZWQsIDU3IGluc2VydGlvbnMoKyksIDQxIGRlbGV0aW9ucygtKQoKTG9v a3MgZ29vZCwgdGhhbmtzLiBBbHNvIHN1cnZpdmVkIHNvbWUgYmFzaWMgZnVuY3Rpb24gdGVzdC4g T25seSBzb21lCm1pbm9yIG5pdHBpY2ssIHNlZSBiZWxvdy4KClJldmlld2VkLWJ5OiBHZXJhbGQg U2NoYWVmZXIgPGdlcmFsZC5zY2hhZWZlckBsaW51eC5pYm0uY29tPgoKPiAKPiBkaWZmIC0tZ2l0 IGEvYXJjaC9zMzkwL3BjaS9wY2lfbW1pby5jIGIvYXJjaC9zMzkwL3BjaS9wY2lfbW1pby5jCj4g aW5kZXggNDAxY2Y2NzBhMjQzLi40ZDE5NGNiMDkzNzIgMTAwNjQ0Cj4gLS0tIGEvYXJjaC9zMzkw L3BjaS9wY2lfbW1pby5jCj4gKysrIGIvYXJjaC9zMzkwL3BjaS9wY2lfbW1pby5jCj4gQEAgLTEx OSwzMyArMTE5LDE1IEBAIHN0YXRpYyBpbmxpbmUgaW50IF9fbWVtY3B5X3RvaW9faW51c2VyKHZv aWQgX19pb21lbSAqZHN0LAo+ICAJcmV0dXJuIHJjOwo+ICB9Cj4gIAo+IC1zdGF0aWMgbG9uZyBn ZXRfcGZuKHVuc2lnbmVkIGxvbmcgdXNlcl9hZGRyLCB1bnNpZ25lZCBsb25nIGFjY2VzcywKPiAt CQkgICAgdW5zaWduZWQgbG9uZyAqcGZuKQo+IC17Cj4gLQlzdHJ1Y3Qgdm1fYXJlYV9zdHJ1Y3Qg KnZtYTsKPiAtCWxvbmcgcmV0Owo+IC0KPiAtCW1tYXBfcmVhZF9sb2NrKGN1cnJlbnQtPm1tKTsK PiAtCXJldCA9IC1FSU5WQUw7Cj4gLQl2bWEgPSBmaW5kX3ZtYShjdXJyZW50LT5tbSwgdXNlcl9h ZGRyKTsKPiAtCWlmICghdm1hKQo+IC0JCWdvdG8gb3V0Owo+IC0JcmV0ID0gLUVBQ0NFUzsKPiAt CWlmICghKHZtYS0+dm1fZmxhZ3MgJiBhY2Nlc3MpKQo+IC0JCWdvdG8gb3V0Owo+IC0JcmV0ID0g Zm9sbG93X3Bmbih2bWEsIHVzZXJfYWRkciwgcGZuKTsKPiAtb3V0Ogo+IC0JbW1hcF9yZWFkX3Vu bG9jayhjdXJyZW50LT5tbSk7Cj4gLQlyZXR1cm4gcmV0Owo+IC19Cj4gLQo+ICBTWVNDQUxMX0RF RklORTMoczM5MF9wY2lfbW1pb193cml0ZSwgdW5zaWduZWQgbG9uZywgbW1pb19hZGRyLAo+ICAJ CWNvbnN0IHZvaWQgX191c2VyICosIHVzZXJfYnVmZmVyLCBzaXplX3QsIGxlbmd0aCkKPiAgewo+ ICAJdTggbG9jYWxfYnVmWzY0XTsKPiAgCXZvaWQgX19pb21lbSAqaW9fYWRkcjsKPiAgCXZvaWQg KmJ1ZjsKPiAtCXVuc2lnbmVkIGxvbmcgcGZuOwo+ICsJc3RydWN0IHZtX2FyZWFfc3RydWN0ICp2 bWE7Cj4gKwlwdGVfdCAqcHRlcDsKPiArCXNwaW5sb2NrX3QgKnB0bDsKPiAgCWxvbmcgcmV0Owo+ ICAKPiAgCWlmICghenBjaV9pc19lbmFibGVkKCkpCj4gQEAgLTE1OCw3ICsxNDAsNyBAQCBTWVND QUxMX0RFRklORTMoczM5MF9wY2lfbW1pb193cml0ZSwgdW5zaWduZWQgbG9uZywgbW1pb19hZGRy LAo+ICAJICogV2Ugb25seSBzdXBwb3J0IHdyaXRlIGFjY2VzcyB0byBNSU8gY2FwYWJsZSBkZXZp Y2VzIGlmIHdlIGFyZSBvbgo+ICAJICogYSBNSU8gZW5hYmxlZCBzeXN0ZW0uIE90aGVyd2lzZSB3 ZSB3b3VsZCBoYXZlIHRvIGNoZWNrIGZvciBldmVyeQo+ICAJICogYWRkcmVzcyBpZiBpdCBpcyBh IHNwZWNpYWwgWlBDSV9BRERSIGFuZCB3b3VsZCBoYXZlIHRvIGRvCj4gLQkgKiBhIGdldF9wZm4o KSB3aGljaCB3ZSBkb24ndCBuZWVkIGZvciBNSU8gY2FwYWJsZSBkZXZpY2VzLiAgQ3VycmVudGx5 Cj4gKwkgKiBhIHBmbiBsb29rdXAgd2hpY2ggd2UgZG9uJ3QgbmVlZCBmb3IgTUlPIGNhcGFibGUg ZGV2aWNlcy4gIEN1cnJlbnRseQo+ICAJICogSVNNIGRldmljZXMgYXJlIHRoZSBvbmx5IGRldmlj ZXMgd2l0aG91dCBNSU8gc3VwcG9ydCBhbmQgdGhlcmUgaXMgbm8KPiAgCSAqIGtub3duIG5lZWQg Zm9yIGFjY2Vzc2luZyB0aGVzZSBmcm9tIHVzZXJzcGFjZS4KPiAgCSAqLwo+IEBAIC0xNzYsMjEg KzE1OCwzNyBAQCBTWVNDQUxMX0RFRklORTMoczM5MF9wY2lfbW1pb193cml0ZSwgdW5zaWduZWQg bG9uZywgbW1pb19hZGRyLAo+ICAJfSBlbHNlCj4gIAkJYnVmID0gbG9jYWxfYnVmOwo+ICAKPiAt CXJldCA9IGdldF9wZm4obW1pb19hZGRyLCBWTV9XUklURSwgJnBmbik7Cj4gKwlyZXQgPSAtRUZB VUxUOwo+ICsJaWYgKGNvcHlfZnJvbV91c2VyKGJ1ZiwgdXNlcl9idWZmZXIsIGxlbmd0aCkpCj4g KwkJZ290byBvdXRfZnJlZTsKPiArCj4gKwltbWFwX3JlYWRfbG9jayhjdXJyZW50LT5tbSk7Cj4g KwlyZXQgPSAtRUlOVkFMOwo+ICsJdm1hID0gZmluZF92bWEoY3VycmVudC0+bW0sIG1taW9fYWRk cik7Cj4gKwlpZiAoIXZtYSkKPiArCQlnb3RvIG91dF91bmxvY2tfbW1hcDsKPiArCXJldCA9IC1F QUNDRVM7Cj4gKwlpZiAoISh2bWEtPnZtX2ZsYWdzICYgVk1fV1JJVEUpKQo+ICsJCWdvdG8gb3V0 X3VubG9ja19tbWFwOwo+ICsJaWYgKCEodm1hLT52bV9mbGFncyAmIChWTV9JTyB8IFZNX1BGTk1B UCkpKQo+ICsJCWdvdG8gb3V0X3VubG9ja19tbWFwOwoKVGhhdCBjaGVjayBmb3IgVk1fSU8gfCBW TV9QRk5NQVAgd2FzIHByZXZpb3VzbHkgaGlkZGVuIGluc2lkZSBmb2xsb3dfcGZuKCksCmFuZCB0 aGF0IHdvdWxkIGhhdmUgcmV0dXJuZWQgLUVJTlZBTCBpbiB0aGlzIGNhc2UuIFdpdGggeW91ciBj aGFuZ2UsIHdlCm5vdyByZXR1cm4gLUVBQ0NFUy4gTm90IHN1cmUgaG93IGltcG9ydGFudCB0aGF0 IGlzLCBidXQgaXQgZmVlbHMgd3JvbmcuCk1heWJlIG1vdmUgdGhlIFZNX0lPIHwgVk1fUEZOTUFQ IGNoZWNrIHVwLCBiZWZvcmUgdGhlIHJldCA9IC1FQUNDRVM/CgpbLi4uXQo+IEBAIC0zMDYsMjIg KzMwNiwzOCBAQCBTWVNDQUxMX0RFRklORTMoczM5MF9wY2lfbW1pb19yZWFkLCB1bnNpZ25lZCBs b25nLCBtbWlvX2FkZHIsCj4gIAkJYnVmID0gbG9jYWxfYnVmOwo+ICAJfQo+ICAKPiAtCXJldCA9 IGdldF9wZm4obW1pb19hZGRyLCBWTV9SRUFELCAmcGZuKTsKPiArCW1tYXBfcmVhZF9sb2NrKGN1 cnJlbnQtPm1tKTsKPiArCXJldCA9IC1FSU5WQUw7Cj4gKwl2bWEgPSBmaW5kX3ZtYShjdXJyZW50 LT5tbSwgbW1pb19hZGRyKTsKPiArCWlmICghdm1hKQo+ICsJCWdvdG8gb3V0X3VubG9ja19tbWFw Owo+ICsJcmV0ID0gLUVBQ0NFUzsKPiArCWlmICghKHZtYS0+dm1fZmxhZ3MgJiBWTV9XUklURSkp Cj4gKwkJZ290byBvdXRfdW5sb2NrX21tYXA7Cj4gKwlpZiAoISh2bWEtPnZtX2ZsYWdzICYgKFZN X0lPIHwgVk1fUEZOTUFQKSkpCj4gKwkJZ290byBvdXRfdW5sb2NrX21tYXA7CgpTYW1lIGhlcmUg d2l0aCBWTV9JTyB8IFZNX1BGTk1BUCBhbmQgLUVJTlZBTC4KX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2 ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==