From: Ondrej Zary <linux@zary.sk>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Oliver Neukum <oneukum@suse.com>,
netdev@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] cx82310_eth: re-enable ethernet mode after router reboot
Date: Mon, 12 Oct 2020 12:42:55 +0200 [thread overview]
Message-ID: <202010121242.55826.linux@zary.sk> (raw)
In-Reply-To: <20201011155539.315bf5aa@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Monday 12 October 2020, Jakub Kicinski wrote:
> On Sat, 10 Oct 2020 16:00:46 +0200 Ondrej Zary wrote:
> > When the router is rebooted without a power cycle, the USB device
> > remains connected but its configuration is reset. This results in
> > a non-working ethernet connection with messages like this in syslog:
> > usb 2-2: RX packet too long: 65535 B
> >
> > Re-enable ethernet mode when receiving a packet with invalid size of
> > 0xffff.
>
> Patch looks good, but could you explain what's a reboot without a power
> cycle in this case? The modem gets reset but USB subsystem doesn't know
> it and doesn't go though a unbind() + bind() cycle?
The router can be rebooted through the web interface. The reboot does not
disconnect the USB device - it remains connected as if nothing happened. Only
wrong data starts to come in.
--
Ondrej Zary
next prev parent reply other threads:[~2020-10-12 10:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-10 14:00 [PATCH 1/2] cx82310_eth: re-enable ethernet mode after router reboot Ondrej Zary
2020-10-10 14:00 ` [PATCH 2/2] cx82310_eth: use netdev_err instead of dev_err Ondrej Zary
2020-10-11 22:55 ` [PATCH 1/2] cx82310_eth: re-enable ethernet mode after router reboot Jakub Kicinski
2020-10-12 10:42 ` Ondrej Zary [this message]
2020-10-12 16:50 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202010121242.55826.linux@zary.sk \
--to=linux@zary.sk \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.