From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Georg Kohmann <geokohma@cisco.com>
Cc: netdev@vger.kernel.org, kadlec@netfilter.org, fw@strlen.de,
davem@davemloft.net, kuznet@ms2.inr.ac.ru,
yoshfuji@linux-ipv6.org, kuba@kernel.org,
netfilter-devel@vger.kernel.org
Subject: Re: [PATCH net] netfilter: Drop fragmented ndisc packets assembled in netfilter
Date: Mon, 12 Oct 2020 14:56:14 +0200 [thread overview]
Message-ID: <20201012125614.GA27601@salvia> (raw)
In-Reply-To: <20201012125347.13011-1-geokohma@cisco.com>
Please, Cc: netfilter-devel@vger.kernel.org for your netfilter
patches, so patchwork can catch it there too next time.
On Mon, Oct 12, 2020 at 02:53:47PM +0200, Georg Kohmann wrote:
> Fragmented ndisc packets assembled in netfilter not dropped as specified
> in RFC 6980, section 5. This behaviour breaks TAHI IPv6 Core Conformance
> Tests v6LC.2.1.22/23, V6LC.2.2.26/27 and V6LC.2.3.18.
>
> Setting IPSKB_FRAGMENTED flag during reassembly.
>
> References: commit b800c3b966bc ("ipv6: drop fragmented ndisc packets by
> default (RFC 6980)")
> Signed-off-by: Georg Kohmann <geokohma@cisco.com>
> ---
> net/ipv6/netfilter/nf_conntrack_reasm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/ipv6/netfilter/nf_conntrack_reasm.c b/net/ipv6/netfilter/nf_conntrack_reasm.c
> index fed9666..054d287 100644
> --- a/net/ipv6/netfilter/nf_conntrack_reasm.c
> +++ b/net/ipv6/netfilter/nf_conntrack_reasm.c
> @@ -355,6 +355,7 @@ static int nf_ct_frag6_reasm(struct frag_queue *fq, struct sk_buff *skb,
> ipv6_hdr(skb)->payload_len = htons(payload_len);
> ipv6_change_dsfield(ipv6_hdr(skb), 0xff, ecn);
> IP6CB(skb)->frag_max_size = sizeof(struct ipv6hdr) + fq->q.max_size;
> + IP6CB(skb)->flags |= IP6SKB_FRAGMENTED;
>
> /* Yes, and fold redundant checksum back. 8) */
> if (skb->ip_summed == CHECKSUM_COMPLETE)
> --
> 2.10.2
>
next prev parent reply other threads:[~2020-10-12 12:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 12:53 [PATCH net] netfilter: Drop fragmented ndisc packets assembled in netfilter Georg Kohmann
2020-10-12 12:56 ` Pablo Neira Ayuso [this message]
2020-10-12 14:22 ` Georg Kohmann (geokohma)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201012125614.GA27601@salvia \
--to=pablo@netfilter.org \
--cc=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=geokohma@cisco.com \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.