From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-media@vger.kernel.org, Tsuchiya Yuto <kitakar@gmail.com>,
bingbu.cao@intel.com, Yong Zhi <yong.zhi@intel.com>,
Tianshu Qiu <tian.shu.qiu@intel.com>
Subject: Re: [PATCH v3 6/8] ipu3-cio2: Remove explicit type from frame size checks
Date: Mon, 12 Oct 2020 21:35:38 +0300 [thread overview]
Message-ID: <20201012183538.GC740@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20201012180414.11579-7-sakari.ailus@linux.intel.com>
Hi Sakari,
Thank you for the patch.
On Mon, Oct 12, 2020 at 09:04:12PM +0300, Sakari Ailus wrote:
> Now that the values are unsigned, we can remove explicit cast to u32.
>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
With Andy's comment addressed,
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/media/pci/intel/ipu3/ipu3-cio2.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/pci/intel/ipu3/ipu3-cio2.c b/drivers/media/pci/intel/ipu3/ipu3-cio2.c
> index 87d040e176f7..e42177f8c426 100644
> --- a/drivers/media/pci/intel/ipu3/ipu3-cio2.c
> +++ b/drivers/media/pci/intel/ipu3/ipu3-cio2.c
> @@ -1282,9 +1282,8 @@ static int cio2_subdev_set_fmt(struct v4l2_subdev *sd,
> }
> }
>
> - fmt->format.width = min_t(u32, fmt->format.width, CIO2_IMAGE_MAX_WIDTH);
> - fmt->format.height = min_t(u32, fmt->format.height,
> - CIO2_IMAGE_MAX_LENGTH);
> + fmt->format.width = min(fmt->format.width, CIO2_IMAGE_MAX_WIDTH);
> + fmt->format.height = min(fmt->format.height, CIO2_IMAGE_MAX_LENGTH);
> fmt->format.field = V4L2_FIELD_NONE;
>
> mutex_lock(&q->subdev_lock);
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2020-10-12 18:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 18:04 [PATCH v3 0/8] ipu3-cio2 format and other fixes Sakari Ailus
2020-10-12 18:04 ` [PATCH v3 1/8] ipu3-cio2: Return actual subdev format Sakari Ailus
2020-10-12 18:04 ` [PATCH v3 2/8] ipu3-cio2: Serialise access to pad format Sakari Ailus
2020-10-12 18:04 ` [PATCH v3 3/8] ipu3-cio2: Validate mbus format in setting subdev format Sakari Ailus
2020-10-12 18:04 ` [PATCH v3 4/8] ipu3-cio2: Make the field on subdev format V4L2_FIELD_NONE Sakari Ailus
2020-10-12 18:04 ` [PATCH v3 5/8] ipu3-cio2: Use unsigned values where appropriate Sakari Ailus
2020-10-12 18:04 ` [PATCH v3 6/8] ipu3-cio2: Remove explicit type from frame size checks Sakari Ailus
2020-10-12 18:30 ` Andy Shevchenko
2020-10-12 18:35 ` Laurent Pinchart [this message]
2020-10-12 18:04 ` [PATCH v3 7/8] ipu3-cio2: Rename CIO2_IMAGE_MAX_LENGTH as CIO2_IMAGE_MAX_HEIGHT Sakari Ailus
2020-10-12 18:31 ` Andy Shevchenko
2020-10-12 18:32 ` Laurent Pinchart
2020-10-12 18:04 ` [PATCH v3 8/8] ipu3-cio2: Remove traces of returned buffers Sakari Ailus
2020-10-12 18:32 ` Andy Shevchenko
2020-10-13 7:22 ` Sakari Ailus
2020-10-12 18:35 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201012183538.GC740@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=bingbu.cao@intel.com \
--cc=kitakar@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tian.shu.qiu@intel.com \
--cc=yong.zhi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.