From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90C96C433DF for ; Tue, 13 Oct 2020 10:42:51 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E402720878 for ; Tue, 13 Oct 2020 10:42:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="DUBQOxs8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E402720878 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51346 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kSHlZ-0006fD-SH for qemu-devel@archiver.kernel.org; Tue, 13 Oct 2020 06:42:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56942) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kSHjx-0005Hq-Jx for qemu-devel@nongnu.org; Tue, 13 Oct 2020 06:41:09 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:59058) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kSHjt-0004ev-1z for qemu-devel@nongnu.org; Tue, 13 Oct 2020 06:41:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602585663; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/1xJ/ZaPJoGKw/5HWQzF/mRE8+PH2JlQjD1pRlcegEo=; b=DUBQOxs89QdzdWp9tLdWn1led5QmQh+SLhwMysvS6v8n+iVg+H4OHsedDQ8B3rrCXURmWd T+BpHVDjLP6NkUM6m7V7CkBm4im7QDzBAnG8LuUkkvK4WqO+++1NRlMDcvWpyj3qPdpizg fEJVbJMoWXj2P/g+evCzDlvKVDeCx6Q= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-198-IPcP9JRHPEau_xIsPa-TrQ-1; Tue, 13 Oct 2020 06:40:59 -0400 X-MC-Unique: IPcP9JRHPEau_xIsPa-TrQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A36838030C3 for ; Tue, 13 Oct 2020 10:40:58 +0000 (UTC) Received: from redhat.com (ovpn-114-78.ams2.redhat.com [10.36.114.78]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D8E6D5D9D2; Tue, 13 Oct 2020 10:40:54 +0000 (UTC) Date: Tue, 13 Oct 2020 11:40:52 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Gerd Hoffmann Subject: Re: [PATCH] qemu-edid: drop cast Message-ID: <20201013104052.GJ70612@redhat.com> References: <20201013091615.14166-1-kraxel@redhat.com> <20201013092322.GE70612@redhat.com> <20201013103446.ahhhplg5mwpppk7o@sirius.home.kraxel.org> MIME-Version: 1.0 In-Reply-To: <20201013103446.ahhhplg5mwpppk7o@sirius.home.kraxel.org> User-Agent: Mutt/1.14.6 (2020-07-11) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/13 03:04:27 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Oct 13, 2020 at 12:34:46PM +0200, Gerd Hoffmann wrote: > On Tue, Oct 13, 2020 at 10:23:22AM +0100, Daniel P. Berrangé wrote: > > On Tue, Oct 13, 2020 at 11:16:15AM +0200, Gerd Hoffmann wrote: > > > Not needed and makes some compilers error out with: > > > > > > qemu-edid.c:15:1: error: initializer element is not constant > > > > Which compilers do this. If we're not seeing this failure in our > > CI, then we have a CI gap that likely needs filling. > > x86_64-w64-mingw32-gcc (GCC) 4.9.3 20150626 (Fedora MinGW 4.9.3-1.el7) Oh, that's a really ancient mingw toolchain. Officially we only care about current generation mingw toolchains ad don't try to support old ones. Effectively this means whatever mingw is in current shipping Fedora or MXE releases. The fix is fine, but we don't need to worry about adding this CI after all since its an unsupported platform. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|