All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marian Csontos <mcsontos@sourceware.org>
To: lvm-devel@redhat.com
Subject: master - Revert "tests: Adapt RAID test to changes"
Date: Tue, 13 Oct 2020 11:17:10 +0000 (GMT)	[thread overview]
Message-ID: <20201013111710.4D2173877036@sourceware.org> (raw)

Gitweb:        https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=53db14171c6b516058486b2a80eaa17af32a246b
Commit:        53db14171c6b516058486b2a80eaa17af32a246b
Parent:        ee43ec5782c3fe23b99e84da86fa3f43d3eb1c56
Author:        Marian Csontos <mcsontos@redhat.com>
AuthorDate:    Tue Oct 13 13:15:16 2020 +0200
Committer:     Marian Csontos <mcsontos@redhat.com>
CommitterDate: Tue Oct 13 13:15:16 2020 +0200

Revert "tests: Adapt RAID test to changes"

The cpnversion of degraded RAID should still report a failure.

This reverts commit e12bdd591a1e60f055baee6cf5e9a144ea245a33.
---
 test/shell/lvconvert-m-raid1-degraded.sh | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/test/shell/lvconvert-m-raid1-degraded.sh b/test/shell/lvconvert-m-raid1-degraded.sh
index c3f70855e..05c3e893c 100644
--- a/test/shell/lvconvert-m-raid1-degraded.sh
+++ b/test/shell/lvconvert-m-raid1-degraded.sh
@@ -33,10 +33,8 @@ aux disable_dev "$dev1"
 vgreduce --force --removemissing $vg
 check raid_leg_status $vg $lv "DA"
 
-# Conversion to 2 legs does nothing on degraded 2-legged raid1 LV
-lvconvert -y -m1 $vg/$lv 2>&1 | tee out
-grep "already has 2 images" out
-# Check it remains degraded after the successful "conversion"
+# Conversion to 2 legs must fail on degraded 2-legged raid1 LV
+not lvconvert -y -m1 $vg/$lv
 check raid_leg_status $vg $lv "DA"
 
 # Repair has to succeed



                 reply	other threads:[~2020-10-13 11:17 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201013111710.4D2173877036@sourceware.org \
    --to=mcsontos@sourceware.org \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.