From: Dan Carpenter <dan.carpenter@oracle.com>
To: tehuang@realtek.com
Cc: linux-wireless@vger.kernel.org
Subject: [bug report] rtw88: add dump firmware fifo support
Date: Tue, 13 Oct 2020 17:23:30 +0300 [thread overview]
Message-ID: <20201013142330.GA490753@mwanda> (raw)
Hello Tzu-En Huang,
The patch 0fbc2f0f34cc: "rtw88: add dump firmware fifo support" from
Sep 25, 2020, leads to the following static checker warning:
drivers/net/wireless/realtek/rtw88/fw.c:1485 rtw_fw_dump_fifo()
warn: this array is probably non-NULL. 'rtwdev->chip->fw_fifo_addr'
drivers/net/wireless/realtek/rtw88/fw.c
1482 int rtw_fw_dump_fifo(struct rtw_dev *rtwdev, u8 fifo_sel, u32 addr, u32 size,
1483 u32 *buffer)
1484 {
1485 if (!rtwdev->chip->fw_fifo_addr) {
^^^^^^^^^^^^^^^^^^^^^^^^^^^
Delete this check?
1486 rtw_dbg(rtwdev, RTW_DBG_FW, "chip not support dump fw fifo\n");
1487 return -ENOTSUPP;
1488 }
1489
1490 if (size == 0 || !buffer)
1491 return -EINVAL;
regards,
dan carpenter
next reply other threads:[~2020-10-13 14:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-13 14:23 Dan Carpenter [this message]
2020-10-14 2:24 ` [bug report] rtw88: add dump firmware fifo support Andy Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201013142330.GA490753@mwanda \
--to=dan.carpenter@oracle.com \
--cc=linux-wireless@vger.kernel.org \
--cc=tehuang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.