Re: [Outreachy kernel] [PATCH v2 2/2] staging: media: imx: remove unnecessary variable use

[Deepak R Varma <mh12gx2825@gmail.com>]

On Tue, Oct 13, 2020 at 07:23:46PM +0530, Vaishali Thakkar wrote:
> On Tue, Oct 13, 2020 at 6:39 PM Deepak R Varma <mh12gx2825@gmail.com> wrote:
> >
> > Variable vc_num usage is unnecessary as it used only once. Instead, the
> > value can directly be used in place of the variable.
> 
> There is something off with this commit log[e.g. missing words etc].
> Probably you can reorganize the words like 'Use of variable
> vc_num is unnecessary here because it is being used only once.
> The value can be used directly.'
> 
> How did you find this? If checkpatch.pl was used for it,
> you should give it a credit in the commit log.
> 
> Also, [unrelated to this change] Greg doesn't pick patches
> for drivers/staging/media so as mentioned in the
> announcement email, you should avoid sending patches
> in media subsystem during the contribution period of Outreachy
> as we can't be sure that they'll be picked up during the timeline
> of a program.
> 

Thank you for the review and comments. I will update and resend the
patch.

Also, my apologies for missing the message about /media specific patches in 
the announcement email. However, since I have already made the change and you 
all have provided feedback, I would like to go ahead with this patch
submission. However, I will avoid any further patch for this driver set
for now.

Thank you again.
Deepak.


> > Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
> >
> > ---
> >  Changes since v1:
> >     - Implement feedback from Julia to be exact with the patch description
> >
> >  drivers/staging/media/imx/imx-media-csi.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/staging/media/imx/imx-media-csi.c
> > index 9320e3974d86..db77fef07654 100644
> > --- a/drivers/staging/media/imx/imx-media-csi.c
> > +++ b/drivers/staging/media/imx/imx-media-csi.c
> > @@ -1123,7 +1123,6 @@ static int csi_link_validate(struct v4l2_subdev *sd,
> >         priv->upstream_ep = upstream_ep;
> >         is_csi2 = !is_parallel_bus(&upstream_ep);
> >         if (is_csi2) {
> > -               int vc_num = 0;
> >                 /*
> >                  * NOTE! It seems the virtual channels from the mipi csi-2
> >                  * receiver are used only for routing by the video mux's,
> > @@ -1131,7 +1130,7 @@ static int csi_link_validate(struct v4l2_subdev *sd,
> >                  * enters the CSI's however, they are treated internally
> >                  * in the IPU as virtual channel 0.
> >                  */
> > -               ipu_csi_set_mipi_datatype(priv->csi, vc_num,
> > +               ipu_csi_set_mipi_datatype(priv->csi, 0,
> >                                           &priv->format_mbus[CSI_SINK_PAD]);
> >         }
> >
> > --
> > 2.25.1
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/5fcd93b57b9232f38fd6d7bc4f685de7ed827628.1602593826.git.mh12gx2825%40gmail.com.
> 
> 
> 
> --
> Vaishali
> http://vaishalithakkar.in/