All of lore.kernel.org
 help / color / mirror / Atom feed
From: William Breathitt Gray <vilhelm.gray@gmail.com>
To: Deepak R Varma <mh12gx2825@gmail.com>,
	Linus Walleij <linus.walleij@linaro.org>
Cc: outreachy-kernel@googlegroups.com,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>,
	gregkh@linuxfoundation.org
Subject: Re: [PATCH] staging: gpio: 104-idi-48: improve code indentation
Date: Tue, 13 Oct 2020 14:52:03 -0400	[thread overview]
Message-ID: <20201013185203.GA32722@shinobu> (raw)
In-Reply-To: <20201013181903.GA67299@ubuntu204>

[-- Attachment #1: Type: text/plain, Size: 1520 bytes --]

On Tue, Oct 13, 2020 at 11:49:03PM +0530, Deepak R Varma wrote:
> Address code indentation warning messages by checkpatch script. Combine
> split function parameters on one line. This also resolves the "use tabs
> instead of space" warning by checkpatch script.
> 
> Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>

As Greg KH mentioned, the subject line should be fixed; as for the
change itself, it looks like pretty innocent whitespace adjustments, so
I'm okay with it. :-)

Acked-by: William Breathitt Gray <vilhelm.gray@gmail.com>

> 
> ---
> 
>  drivers/gpio/gpio-104-idi-48.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpio/gpio-104-idi-48.c b/drivers/gpio/gpio-104-idi-48.c
> index 94c3a9bc4e75..b132afaf7d99 100644
> --- a/drivers/gpio/gpio-104-idi-48.c
> +++ b/drivers/gpio/gpio-104-idi-48.c
> @@ -132,8 +132,7 @@ static void idi_48_irq_mask(struct irq_data *data)
>  
>  				outb(idi48gpio->cos_enb, idi48gpio->base + 7);
>  
> -				raw_spin_unlock_irqrestore(&idi48gpio->lock,
> -						           flags);
> +				raw_spin_unlock_irqrestore(&idi48gpio->lock, flags);
>  			}
>  
>  			return;
> @@ -166,8 +165,7 @@ static void idi_48_irq_unmask(struct irq_data *data)
>  
>  				outb(idi48gpio->cos_enb, idi48gpio->base + 7);
>  
> -				raw_spin_unlock_irqrestore(&idi48gpio->lock,
> -						           flags);
> +				raw_spin_unlock_irqrestore(&idi48gpio->lock, flags);
>  			}
>  
>  			return;
> -- 
> 2.25.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      parent reply	other threads:[~2020-10-13 19:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-13 18:19 [PATCH] staging: gpio: 104-idi-48: improve code indentation Deepak R Varma
2020-10-13 18:34 ` Greg KH
2020-10-13 18:52 ` William Breathitt Gray [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201013185203.GA32722@shinobu \
    --to=vilhelm.gray@gmail.com \
    --cc=bgolaszewski@baylibre.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linus.walleij@linaro.org \
    --cc=mh12gx2825@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.