Re: [meta-ti] [PATCH 1/2] ti-pdk-fetch.bbclass: Do not emit trailing slash during S forming

["Denys Dmytriyenko" <denys@ti.com>]

On Tue, Oct 13, 2020 at 02:22:30PM -0700, Khem Raj wrote:
> On Tue, Oct 13, 2020 at 1:55 PM Denys Dmytriyenko <denys@ti.com> wrote:
> 
> > On Tue, Oct 13, 2020 at 11:36:41AM -0700, Khem Raj wrote:
> > > latest OE-core does not promote using trailing slash to make pseudo's
> > > life easier
> > >
> > > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > > ---
> > >  classes/ti-pdk-fetch.bbclass | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/classes/ti-pdk-fetch.bbclass b/classes/ti-pdk-fetch.bbclass
> > > index 0c9879be..4261e86d 100644
> > > --- a/classes/ti-pdk-fetch.bbclass
> > > +++ b/classes/ti-pdk-fetch.bbclass
> > > @@ -9,13 +9,13 @@ PV = "${TI_PDK_VERSION}"
> > >  PE = "2"
> > >
> > >  TI_PDK_COMP ?= ""
> > > -TI_PDK_COMP_PATH = "${@'${TI_PDK_COMP}'.replace('.','/')}"
> > > +TI_PDK_COMP_PATH = "/${@'${TI_PDK_COMP}'.replace('.','/')}"
> >
> > This one I don't understand - even when TI_PDK_COMP is empty,
> > TI_PDK_COMP_PATH will have a trailing slash, hence S below will
> > have it too...
> 
> 
> Right I think I was thinking of ensuring that we can make conditional to
> have the slash always and then remove it from S which is missing
> 
> I guess it needs to be solved differently
> 
> 
> >
> > Moreover, below in this class there's this line:
> >
> > src =
> > os.path.join(d.getVar('TI_PDK_SOURCE'),'packages',d.getVar('TI_PDK_COMP_PATH'))
> >
> > If TI_PDK_COMP_PATH starts with a leading slash, os.path.join treats
> > it as absolute and the resulting "src" var will be completely wrong.
> 
> 
> This is not going to be problem it will just use // in worst case

Nope, I tested - it should combine $TI_PDK_SOURCE/packages/$TI_PDK_COMP_PATH

>>> print(os.path.join('a','b','c'))
a/b/c
>>> print(os.path.join('a','b','/c'))
/c

So, if TI_PDK_COMP_PATH starts with slash, it becomes absolute and the final 
src path will be wrong.


> > So, I believe this change is incorrect.
> >
> >
> > >  TI_PDK_SOURCE_PN = "ti-pdk-source"
> > >  TI_PDK_SOURCE_WORKDIR = "${TMPDIR}/work-shared/ti-pdk-${PV}"
> > >  TI_PDK_SOURCE = "${TI_PDK_SOURCE_WORKDIR}/git"
> > >
> > > -S = "${WORKDIR}/git/${TI_PDK_COMP_PATH}"
> > > +S = "${WORKDIR}/git${TI_PDK_COMP_PATH}"
> > >
> > >  # Hard-link only required sources from PDK
> > >  python do_unpack_append() {
> > > --
> > > 2.28.0
> > >
> >
> > >
> > > 
> > >
> >
> >