From: "Denys Dmytriyenko" <denys@ti.com>
To: Khem Raj <raj.khem@gmail.com>
Cc: <meta-ti@lists.yoctoproject.org>
Subject: Re: [meta-ti] [PATCH v2] ti-pdk-fetch.bbclass: Do not emit trailing slash during S forming
Date: Tue, 13 Oct 2020 17:51:03 -0400 [thread overview]
Message-ID: <20201013215103.GF14852@beryl> (raw)
In-Reply-To: <20201013214911.339265-1-raj.khem@gmail.com>
On Tue, Oct 13, 2020 at 02:49:11PM -0700, Khem Raj wrote:
> latest OE-core does not promote using trailing slash to make pseudo's
> life easier
This should be fine.
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
Reviewed-by: Denys Dmytriyenko <denys@ti.com>
> ---
> v2: Strip slash from S if it exists
>
> classes/ti-pdk-fetch.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/classes/ti-pdk-fetch.bbclass b/classes/ti-pdk-fetch.bbclass
> index 0c9879be..cacd71a4 100644
> --- a/classes/ti-pdk-fetch.bbclass
> +++ b/classes/ti-pdk-fetch.bbclass
> @@ -15,7 +15,7 @@ TI_PDK_SOURCE_PN = "ti-pdk-source"
> TI_PDK_SOURCE_WORKDIR = "${TMPDIR}/work-shared/ti-pdk-${PV}"
> TI_PDK_SOURCE = "${TI_PDK_SOURCE_WORKDIR}/git"
>
> -S = "${WORKDIR}/git/${TI_PDK_COMP_PATH}"
> +S = "${@'${WORKDIR}/git/${TI_PDK_COMP_PATH}'.rstrip('/')}"
>
> # Hard-link only required sources from PDK
> python do_unpack_append() {
> --
> 2.28.0
>
>
>
>
next prev parent reply other threads:[~2020-10-13 21:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-13 21:49 [PATCH v2] ti-pdk-fetch.bbclass: Do not emit trailing slash during S forming Khem Raj
2020-10-13 21:51 ` Denys Dmytriyenko [this message]
2020-10-14 15:35 ` [meta-ti] " Dan Murphy
2020-10-14 15:37 ` Denys Dmytriyenko
2020-10-14 15:39 ` Dan Murphy
2020-10-14 15:51 ` Khem Raj
2020-10-14 15:54 ` Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201013215103.GF14852@beryl \
--to=denys@ti.com \
--cc=meta-ti@lists.yoctoproject.org \
--cc=raj.khem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.