From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FD49C433E7 for ; Wed, 14 Oct 2020 07:56:04 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 16FF02222C for ; Wed, 14 Oct 2020 07:56:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="eB/DReMy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 16FF02222C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ucw.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id EDF011713; Wed, 14 Oct 2020 09:55:09 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz EDF011713 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1602662160; bh=OfYADyjwePrmJMvKMuxnl45AK9Rq8OsNBbfSIof3yWM=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=eB/DReMyG7czYdKfxtSnhUXZqj7FVLb1E4BJ2uQWVta4NwyOak++NhLuPKaexu+uU BDJyDUgusXpstIMU5KuFOkw3GCMWTyaxx25QGyzw1GlXkIVq3Ho5ruAvWp7SyyFjq8 eNmEfTKDG+XU6+qfw8BGpUAHY0tOVMAKxHir9ZA8= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 96582F8020D; Wed, 14 Oct 2020 09:55:09 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 186C1F80217; Wed, 14 Oct 2020 09:55:08 +0200 (CEST) Received: from jabberwock.ucw.cz (jabberwock.ucw.cz [46.255.230.98]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 4C8D9F800F6 for ; Wed, 14 Oct 2020 09:55:01 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 4C8D9F800F6 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id B40CA1C0B87; Wed, 14 Oct 2020 09:54:59 +0200 (CEST) Date: Wed, 14 Oct 2020 09:54:59 +0200 From: Pavel Machek To: Randy Dunlap Subject: Re: disabling CONFIG_LED_CLASS (SND_HDA_CODEC_REALTEK) Message-ID: <20201014075458.GA29881@amd> References: <43b79598-1592-683f-46df-9e5489110780@infradead.org> <6fd1e91e-19d0-6682-dfc6-49f1cd60408b@infradead.org> <3c6d174c-30db-3d03-3d16-42df405f38d9@xs4all.nl> <58e774c5-fc80-2060-2091-9a6398582cc5@infradead.org> <9fc679e9-e9a9-ad80-b24c-f04489b98aa7@xs4all.nl> <27e159be-4376-e87b-5e60-803bc3749ec2@infradead.org> <2739e1fd-75c6-4e43-cd79-9028479f91bf@infradead.org> <1e6b1961-9e9b-5f82-86a1-bf838cb68f55@xs4all.nl> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="dDRMvlgZJXvWKvBx" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Cc: moderated for non-subscribers , Takashi Iwai , "linux-kernel@vger.kernel.org" , Udo van den Heuvel , Dan Murphy , linux-leds@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --dDRMvlgZJXvWKvBx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > >>> I.e.: it looks like I will lose some funcionality when I disable > >>> SND_HDA_CODEC_REALTEK. > >> > >> OK. At present you can't have it both ways, i.e., SND_HDA_CODEC_REALTEK > >> with no LEDS. That driver apparently wants LEDS. > >=20 > > Thanks but why have I gone for years without LEDS? > > I do not need LEDS, I do not want LEDS, I do not have LEDS (that are > > visible, usable, etc). > >=20 > > Please make this selectable instead of forcing more bulk into my >> kernel. LED core is not that big, and this avoided some rather "interesting" hacks IIRC. If Udo wants more config complexity, lets first make him measure the benefits, second submit a patch. But I'd suggest to just live with it. And yes, we should probably get rid of "CONFIG_NEW_LEDS" symbol. That one is actually useless. Best regards, Pavel =09 > and this Kconfig entry: >=20 > config SND_HDA_CODEC_REALTEK > tristate "Build Realtek HD-audio codec support" > select SND_HDA_GENERIC > select SND_HDA_GENERIC_LEDS >=20 > it seems that LED support is not always wanted (please see above). > I.e., user(s) would like to build a kernel without LED support at all. >=20 > Can you make it a build option? >=20 > thanks. --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --dDRMvlgZJXvWKvBx Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAl+GrtIACgkQMOfwapXb+vIBRACfToWfcNk9AdXdXG4zZ7i28/s3 4/wAn0pgJoPXjHt0MDaxgLcMMwqmrHhJ =JHTM -----END PGP SIGNATURE----- --dDRMvlgZJXvWKvBx-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23DA8C433E7 for ; Wed, 14 Oct 2020 07:55:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AF2F321582 for ; Wed, 14 Oct 2020 07:55:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727151AbgJNHzC (ORCPT ); Wed, 14 Oct 2020 03:55:02 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]:53108 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726897AbgJNHzC (ORCPT ); Wed, 14 Oct 2020 03:55:02 -0400 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id B40CA1C0B87; Wed, 14 Oct 2020 09:54:59 +0200 (CEST) Date: Wed, 14 Oct 2020 09:54:59 +0200 From: Pavel Machek To: Randy Dunlap Cc: Udo van den Heuvel , "linux-kernel@vger.kernel.org" , linux-leds@vger.kernel.org, Dan Murphy , Takashi Iwai , moderated for non-subscribers Subject: Re: disabling CONFIG_LED_CLASS (SND_HDA_CODEC_REALTEK) Message-ID: <20201014075458.GA29881@amd> References: <43b79598-1592-683f-46df-9e5489110780@infradead.org> <6fd1e91e-19d0-6682-dfc6-49f1cd60408b@infradead.org> <3c6d174c-30db-3d03-3d16-42df405f38d9@xs4all.nl> <58e774c5-fc80-2060-2091-9a6398582cc5@infradead.org> <9fc679e9-e9a9-ad80-b24c-f04489b98aa7@xs4all.nl> <27e159be-4376-e87b-5e60-803bc3749ec2@infradead.org> <2739e1fd-75c6-4e43-cd79-9028479f91bf@infradead.org> <1e6b1961-9e9b-5f82-86a1-bf838cb68f55@xs4all.nl> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="dDRMvlgZJXvWKvBx" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org --dDRMvlgZJXvWKvBx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > >>> I.e.: it looks like I will lose some funcionality when I disable > >>> SND_HDA_CODEC_REALTEK. > >> > >> OK. At present you can't have it both ways, i.e., SND_HDA_CODEC_REALTEK > >> with no LEDS. That driver apparently wants LEDS. > >=20 > > Thanks but why have I gone for years without LEDS? > > I do not need LEDS, I do not want LEDS, I do not have LEDS (that are > > visible, usable, etc). > >=20 > > Please make this selectable instead of forcing more bulk into my >> kernel. LED core is not that big, and this avoided some rather "interesting" hacks IIRC. If Udo wants more config complexity, lets first make him measure the benefits, second submit a patch. But I'd suggest to just live with it. And yes, we should probably get rid of "CONFIG_NEW_LEDS" symbol. That one is actually useless. Best regards, Pavel =09 > and this Kconfig entry: >=20 > config SND_HDA_CODEC_REALTEK > tristate "Build Realtek HD-audio codec support" > select SND_HDA_GENERIC > select SND_HDA_GENERIC_LEDS >=20 > it seems that LED support is not always wanted (please see above). > I.e., user(s) would like to build a kernel without LED support at all. >=20 > Can you make it a build option? >=20 > thanks. --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --dDRMvlgZJXvWKvBx Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAl+GrtIACgkQMOfwapXb+vIBRACfToWfcNk9AdXdXG4zZ7i28/s3 4/wAn0pgJoPXjHt0MDaxgLcMMwqmrHhJ =JHTM -----END PGP SIGNATURE----- --dDRMvlgZJXvWKvBx--