From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE13DC43457 for ; Wed, 14 Oct 2020 09:19:44 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 460D520B1F for ; Wed, 14 Oct 2020 09:19:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="1np2Yo/K" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 460D520B1F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BIeqq4w6sxlcu+rdo5o7VV+BRHMS9bdapfraUBJIe/0=; b=1np2Yo/K4ByoQKDrpLvQSMrSL jSOKKiaj17+4ieMTxADBNzn7UBbo8oJOKbWnAnZfBzzjSZTfNBz02DfCwzDYemS84MdhHLni93821 zEtLEpvh91akuDijCHR6pK5s2TzkECOV2pJ293FJz+8/l+pQDdiFkDVVtNtAfTPhTP+9wC6I9xmoL gtYFuVjuxMrd7XFXxgh326d/nTOSbKY8s4t4QFnGj9E5dDVQRWUBsqcFq7GDISFT1G6zmjDX0R6bt 6t3UEBacs4PsDKdyWIEf2sGmypGKDPpNZmiX6Gy7dSsDtUgmZf1YZLlezyOA1f44PLypHsNMuX5zs Won4pWleg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kScvG-0005OK-Lg; Wed, 14 Oct 2020 09:18:14 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kScvE-0005Np-O5 for linux-arm-kernel@lists.infradead.org; Wed, 14 Oct 2020 09:18:13 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7D8F730E; Wed, 14 Oct 2020 02:18:11 -0700 (PDT) Received: from bogus (unknown [10.57.12.254]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4266A3F73C; Wed, 14 Oct 2020 02:18:10 -0700 (PDT) Date: Wed, 14 Oct 2020 10:18:06 +0100 From: Sudeep Holla To: Florian Fainelli Subject: Re: [PATCH] firmware: arm_scmi: Fix duplicate workqueue name Message-ID: <20201014091806.GB20315@bogus> References: <20201014021737.287340-1-f.fainelli@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201014021737.287340-1-f.fainelli@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201014_051812_880653_75FE9C33 X-CRM114-Status: GOOD ( 25.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, Cristian Marussi , linux-arm-kernel@lists.infradead.org, Jonathan Cameron Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgRmxvcmlhbiwKClRoYW5rcyBmb3IgdGhlIHBhdGNoLCBpdCBzaG93cyBzb21lb25lIGVsc2Ug aXMgYWxzbyB1c2luZyB0aGlzIGFuZAp0ZXN0aW5nIPCfmIkuCgpPbiBUdWUsIE9jdCAxMywgMjAy MCBhdCAwNzoxNzozN1BNIC0wNzAwLCBGbG9yaWFuIEZhaW5lbGxpIHdyb3RlOgo+IFdoZW4gbW9y ZSB0aGFuIGEgc2luZ2xlIFNDTUkgZGV2aWNlIGFyZSBwcmVzZW50IGluIHRoZSBzeXN0ZW0sIHRo ZQo+IGNyZWF0aW9uIG9mIHRoZSBub3RpZmljYXRpb24gd29ya3F1ZXVlIHdpdGggdGhlIFdRX1NZ U0ZTIGZsYWcgd2lsbCBsZWFkCj4gdG8gdGhlIGZvbGxvd2luZyBzeXNmcyBkdXBsaWNhdGUgbm9k ZSB3YXJuaW5nOgo+IAoKUGxlYXNlIHRyaW0gdGhlIGNhbGx0cmFjZSBuZXh0IHRpbWUgd2l0aG91 dCB0aW1lc3RhbXAgYW5kIHJlZ2lzdGVyIHJhdwpoZXggdmFsdWVzLgoKWW91IHVzaW5nIHRoaXMg b24gMzItYml0IHBsYXRmb3JtID8gSWYgc28sIHRoYW5rcyBmb3IgYWRkaXRpb25hbCB0ZXN0CmNv dmVyYWdlLgoKPiBbICAgIDkuMjU5OTkwXSBzeXNmczogY2Fubm90IGNyZWF0ZSBkdXBsaWNhdGUg ZmlsZW5hbWUgJy9kZXZpY2VzL3ZpcnR1YWwvd29ya3F1ZXVlL3NjbWlfbm90aWZ5Jwo+IFsgICAg OS4yNjAwMjRdIENQVTogMCBQSUQ6IDIwIENvbW06IGt3b3JrZXIvMDoxIE5vdCB0YWludGVkIDUu OS4wLWdkZjRkZDg0YTNmN2QgIzI5Cj4gWyAgICA5LjI2MDA0NV0gSGFyZHdhcmUgbmFtZTogQnJv YWRjb20gU1RCIChGbGF0dGVuZWQgRGV2aWNlIFRyZWUpCj4gWyAgICA5LjI2MDA4M10gV29ya3F1 ZXVlOiBldmVudHMgZGVmZXJyZWRfcHJvYmVfd29ya19mdW5jCj4gWyAgICA5LjI2MDA5OV0gQmFj a3RyYWNlOgo+IFsgICAgOS4yNjAxMjddIFs8YzAyMTIwYjQ+XSAoZHVtcF9iYWNrdHJhY2UpIGZy b20gWzxjMDIxMjNkOD5dIChzaG93X3N0YWNrKzB4MjAvMHgyNCkKPiBbICAgIDkuMjYwMTU1XSAg cjk6ZmZmZmZmZmYgcjg6MDAwMDAwMDAgcjc6YzI5OGUzYzAgcjY6NjAwMDAwMTMgcjU6MDAwMDAw MDAgcjQ6YzI5OGUzYzAKPiBbICAgIDkuMjYwMTg2XSBbPGMwMjEyM2I4Pl0gKHNob3dfc3RhY2sp IGZyb20gWzxjMDg4NTJhMD5dIChkdW1wX3N0YWNrKzB4YmMvMHhlMCkKPiBbICAgIDkuMjYwMjE2 XSBbPGMwODg1MWU0Pl0gKGR1bXBfc3RhY2spIGZyb20gWzxjMDU0NDQyYz5dIChzeXNmc193YXJu X2R1cCsweDcwLzB4ODApCj4gWyAgICA5LjI2MDI0M10gIHIxMDplNDcyZDgxNCByOTpmZmZmZmZl ZiByODplNDYxNGE1MCByNzpjMjgwNmQ0OCByNjplMGU1MGY4MCByNTplNDYxNGE1MAo+IFsgICAg OS4yNjAyNjVdICByNDplMGU4MjAwMCByMzpjNWIxN2MzNAo+IFsgICAgOS4yNjAyODVdIFs8YzA1 NDQzYmM+XSAoc3lzZnNfd2Fybl9kdXApIGZyb20gWzxjMDU0NDVmYz5dIChzeXNmc19jcmVhdGVf ZGlyX25zKzB4MTVjLzB4MWE0KQo+IFsgICAgOS4yNjAzMTBdICByNzpjMjgwNmQ0OCByNjpmZmZm ZmZlZiByNTplMGRmZjAwOCByNDpiYjhjZDZlNAo+IFsgICAgOS4yNjAzMzVdIFs8YzA1NDQ0YTA+ XSAoc3lzZnNfY3JlYXRlX2Rpcl9ucykgZnJvbSBbPGMwODhlYmFjPl0gKGtvYmplY3RfYWRkX2lu dGVybmFsKzB4MTQwLzB4NGQwKQo+IFsgICAgOS4yNjAzNjNdICByOTplNDUxZmE4MCByODplMGRm ZjAxYyByNzplMGRmZjAxNCByNjplNDViMTQwMCByNTplMGRmZjAxOCByNDplMGRmZjAwOAo+IFsg ICAgOS4yNjAzOTBdIFs8YzA4OGVhNmM+XSAoa29iamVjdF9hZGRfaW50ZXJuYWwpIGZyb20gWzxj MDg4ZjAwND5dIChrb2JqZWN0X2FkZCsweGM4LzB4MTM4KQo+IFsgICAgOS4yNjA0MTZdICByMTA6 ZTBkZmYwMzAgcjk6MDAwMDAwMDAgcjg6ZTQ1YjE0MDAgcjc6MDAwMDAwMDAgcjY6YzI4MDZkNDgg cjU6ZTBkZmYwMDgKPiBbICAgIDkuMjYwNDM2XSAgcjQ6YmI4Y2Q3MDgKPiBbICAgIDkuMjYwNDU1 XSBbPGMwODhlZjNjPl0gKGtvYmplY3RfYWRkKSBmcm9tIFs8YzBhMGJjNzA+XSAoZGV2aWNlX2Fk ZCsweDFkYy8weGMyMCkKPiBbICAgIDkuMjYwNDc2XSAgcjM6ZTBkZmYwMTQgcjI6MDAwMDAwMDAK PiBbICAgIDkuMjYwNDk1XSAgcjk6MDAwMDAwMDAgcjg6ZTQ2NmI5ODAgcjc6ZTQ1YjE0MDAgcjY6 YzI4MDZkNDggcjU6YmI4Y2Q3MjQgcjQ6ZTBkZmYwMDgKPiBbICAgIDkuMjYwNTIxXSBbPGMwYTBi YTk0Pl0gKGRldmljZV9hZGQpIGZyb20gWzxjMGEwYzZkOD5dIChkZXZpY2VfcmVnaXN0ZXIrMHgy NC8weDI4KQo+IFsgICAgOS4yNjA1NDddICByMTA6YzI4MzEzNDAgcjk6ZTBkZmVjMDggcjg6ZTBk ZmYwMjggcjc6ZTBkZmVjYzAgcjY6ZTBkZmVjMDAgcjU6ZTBkZmYwMDgKPiBbICAgIDkuMjYwNTY3 XSAgcjQ6ZTBkZmYwMDgKPiBbICAgIDkuMjYwNTg2XSBbPGMwYTBjNmI0Pl0gKGRldmljZV9yZWdp c3RlcikgZnJvbSBbPGMwMjVmMmE4Pl0gKHdvcmtxdWV1ZV9zeXNmc19yZWdpc3RlcisweGU0LzB4 MWYwKQo+IFsgICAgOS4yNjA2MDldICByNTplMGRmZjAwOCByNDplMGRmZjAwMAo+IFsgICAgOS4y NjA2MjddIFs8YzAyNWYxYzQ+XSAod29ya3F1ZXVlX3N5c2ZzX3JlZ2lzdGVyKSBmcm9tIFs8YzAy NWY3ZmM+XSAoYWxsb2Nfd29ya3F1ZXVlKzB4NDQ4LzB4NmFjKQo+IFsgICAgOS4yNjA2NTVdICBy MTA6ZTBkZmVjYzAgcjk6ZTBkZmVjMDggcjg6ZTBkZmVjMGMgcjc6ZTBkZmVjMDQgcjY6ZTBkZmVj YzAgcjU6ZTBkZmVjMDAKPiBbICAgIDkuMjYwNjc1XSAgcjQ6MDAwMDAwMDEKPiBbICAgIDkuMjYw Njk4XSBbPGMwMjVmM2I0Pl0gKGFsbG9jX3dvcmtxdWV1ZSkgZnJvbSBbPGMwZDhiNThjPl0gKHNj bWlfbm90aWZpY2F0aW9uX2luaXQrMHg3OC8weDFkYykKPiBbICAgIDkuMjYwNzIwXSAgcjM6YzBh MWI0ODggcjI6MDAwMDAwMDAKPiBbICAgIDkuMjYwNzM5XSAgcjEwOmUwZGUxMDQwIHI5OjAwODAw MDA0IHI4OmUwZGUxMGQ4IHI3OmUwZGUxMGY0IHI2OmUwZGUxMDc0IHI1OmUwZTU0NzQwCj4gWyAg ICA5LjI2MDc1OV0gIHI0OmUwZTUwZDAwCj4gWyAgICA5LjI2MDc3OF0gWzxjMGQ4YjUxND5dIChz Y21pX25vdGlmaWNhdGlvbl9pbml0KSBmcm9tIFs8YzBkODdjMDA+XSAoc2NtaV9wcm9iZSsweDI2 OC8weDRmYykKPiBbICAgIDkuMjYwODA1XSAgcjk6MDA4MDAwMDQgcjg6ZTBkZTEwZDggcjc6ZTBk ZTEwZjQgcjY6ZTBkZTEwNzQgcjU6ZTBkZTEwZjAgcjQ6ZTQ3MmQ4MTAKPiBbICAgIDkuMjYwODMz XSBbPGMwZDg3OTk4Pl0gKHNjbWlfcHJvYmUpIGZyb20gWzxjMGExN2Q3ND5dIChwbGF0Zm9ybV9k cnZfcHJvYmUrMHg3MC8weGM4KQo+IFsgICAgOS4yNjA4NTldICByMTA6ZTQ3MmQ4NDQgcjk6YzJh YjAyYjQgcjg6YzJiNWUyOTggcjc6MDAwMDAwMDAgcjY6YzJhYjAyYjQgcjU6MDAwMDAwMDAKPiBb ICAgIDkuMjYwODc5XSAgcjQ6ZTQ3MmQ4MTAKPiBbICAgIDkuMjYwODk4XSBbPGMwYTE3ZDA0Pl0g KHBsYXRmb3JtX2Rydl9wcm9iZSkgZnJvbSBbPGMwYTEzZTgwPl0gKHJlYWxseV9wcm9iZSsweDE4 NC8weDcyOCkKPiBbICAgIDkuMjYwOTIyXSAgcjc6MDAwMDAwMDAgcjY6YzJmYzgyYTAgcjU6YzJm YzgyMjAgcjQ6ZTQ3MmQ4MTAKPiBbICAgIDkuMjYwOTQ2XSBbPGMwYTEzY2ZjPl0gKHJlYWxseV9w cm9iZSkgZnJvbSBbPGMwYTE0NmI0Pl0gKGRyaXZlcl9wcm9iZV9kZXZpY2UrMHhhNC8weDI3OCkK PiBbICAgIDkuMjYwOTczXSAgcjEwOmUwY2VmNDM4IHI5OmMwYTE0YTA0IHI4OmMyYjc3MWMwIHI3 OmMyYjVlMjk4IHI2OmMyYWIwMmI0IHI1OmU0NzJkODM0Cj4gWyAgICA5LjI2MDk5M10gIHI0OmU0 NzJkODEwCj4gWyAgICA5LjI2MTAxNF0gWzxjMGExNDYxMD5dIChkcml2ZXJfcHJvYmVfZGV2aWNl KSBmcm9tIFs8YzBhMTRhZWM+XSAoX19kZXZpY2VfYXR0YWNoX2RyaXZlcisweGU4LzB4MTQ4KQo+ IFsgICAgOS4yNjEwNDJdICByMTA6ZTBjZWY0Mzggcjk6YzBhMTRhMDQgcjg6ZTQ2NmJkYzAgcjc6 ZTQ3MmQ4MTAgcjY6MDAwMDAwMDAgcjU6YzJhYjAyYjQKPiBbICAgIDkuMjYxMDYyXSAgcjQ6ZTQ2 NmJkYzAKPiBbICAgIDkuMjYxMDgyXSBbPGMwYTE0YTA0Pl0gKF9fZGV2aWNlX2F0dGFjaF9kcml2 ZXIpIGZyb20gWzxjMGExMGY2Yz5dIChidXNfZm9yX2VhY2hfZHJ2KzB4MTA4LzB4MTU4KQo+IFsg ICAgOS4yNjExMDddICByNzpjMjgwNmQ0OCByNjowMDAwMDAwMCByNTpiYjhjZDc5YyByNDplNDY2 YmQwMAo+IFsgICAgOS4yNjExMzFdIFs8YzBhMTBlNjQ+XSAoYnVzX2Zvcl9lYWNoX2RydikgZnJv bSBbPGMwYTEzYzM4Pl0gKF9fZGV2aWNlX2F0dGFjaCsweDE5MC8weDIzNCkKPiBbICAgIDkuMjYx MTU4XSAgcjEwOmU0NmZkZTAwIHI5OmU0NzJkODQ4IHI4OmU0NzJkODU0IHI3OmU0NjZiZTAwIHI2 OmMyODA2ZDQ4IHI1OmJiOGNkN2I0Cj4gWyAgICA5LjI2MTE3OF0gIHI0OmU0NzJkODEwCj4gWyAg ICA5LjI2MTE5OV0gWzxjMGExM2FhOD5dIChfX2RldmljZV9hdHRhY2gpIGZyb20gWzxjMGExNGI2 OD5dIChkZXZpY2VfaW5pdGlhbF9wcm9iZSsweDFjLzB4MjApCj4gWyAgICA5LjI2MTIyNl0gIHIx MDplNDZmZGU1NCByOTpjMjlkNjM4MCByODpjMjlkNzkxMCByNzplNDcyZDgxMCByNjpjMjlkNzhj MCByNTpjMjlkNjM0MAo+IFsgICAgOS4yNjEyNDZdICByNDplNDRlZmUwMAo+IFsgICAgOS4yNjEy NjZdIFs8YzBhMTRiNGM+XSAoZGV2aWNlX2luaXRpYWxfcHJvYmUpIGZyb20gWzxjMGExMjVmYz5d IChidXNfcHJvYmVfZGV2aWNlKzB4ZGMvMHhlYykKPiBbICAgIDkuMjYxMjk2XSBbPGMwYTEyNTIw Pl0gKGJ1c19wcm9iZV9kZXZpY2UpIGZyb20gWzxjMGExMmUyND5dIChkZWZlcnJlZF9wcm9iZV93 b3JrX2Z1bmMrMHhkNC8weDExYykKPiBbICAgIDkuMjYxMzI0XSAgcjk6YzI5ZDYzODAgcjg6ZTQ2 NzJlNTQgcjc6YzI5ZDYzODAgcjY6YzI5ZDYzNDAgcjU6YzI5ZDYzNDAgcjQ6ZTQ3MmQ4MTAKPiBb ICAgIDkuMjYxMzU2XSBbPGMwYTEyZDUwPl0gKGRlZmVycmVkX3Byb2JlX3dvcmtfZnVuYykgZnJv bSBbPGMwMjVhNTM0Pl0gKHByb2Nlc3Nfb25lX3dvcmsrMHg0MjAvMHg4ZjApCj4gWyAgICA5LjI2 MTM4NF0gIHIxMDplNDUyZmQ4NCByOTpjMmI1Mzc1MCByODowMDAwMDAwMCByNzplNDUyYWUwYyBy NjplOGExZTI0MCByNTplNDUyYWUwMAo+IFsgICAgOS4yNjE0MDRdICByNDpjMjlkNjQ0MAo+IFsg ICAgOS4yNjE0MjRdIFs8YzAyNWExMTQ+XSAocHJvY2Vzc19vbmVfd29yaykgZnJvbSBbPGMwMjVh ZjAwPl0gKHdvcmtlcl90aHJlYWQrMHg0ZmMvMHg5MWMpCj4gWyAgICA5LjI2MTQ1MF0gIHIxMDpl OGExZTI1OCByOTplNDUyYWUwMCByODplOGExZTI1NCByNzplOGExZTI0MCByNjplNDUyZmQ4NCBy NTplOGExZTI1NAo+IFsgICAgOS4yNjE0NzBdICByNDplNDUyYWUxNAo+IFsgICAgOS4yNjE0OTJd IFs8YzAyNWFhMDQ+XSAod29ya2VyX3RocmVhZCkgZnJvbSBbPGMwMjY1OTFjPl0gKGt0aHJlYWQr MHgyMWMvMHgyMmMpCj4gWyAgICA5LjI2MTUxN10gIHIxMDplNDU1YmNlMCByOTplNDViOGQ4MCBy ODplNDUyYWUwMCByNzpjMDI1YWEwNCByNjplNDViOGQ4MCByNTowMDAwMDAwMAo+IFsgICAgOS4y NjE1MzddICByNDplNDVjMDQwMAo+IFsgICAgOS4yNjE1NTVdIFs8YzAyNjU3MDA+XSAoa3RocmVh ZCkgZnJvbSBbPGMwMjAwMTE0Pl0gKHJldF9mcm9tX2ZvcmsrMHgxNC8weDIwKQo+IFsgICAgOS4y NjE1NzVdIEV4Y2VwdGlvbiBzdGFjaygweGU0NjZiZmIwIHRvIDB4ZTQ2NmJmZjgpCj4gWyAgICA5 LjI2MTU5M10gYmZhMDogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgMDAwMDAw MDAgMDAwMDAwMDAgMDAwMDAwMDAgMDAwMDAwMDAKPiBbICAgIDkuMjYxNjE4XSBiZmMwOiAwMDAw MDAwMCAwMDAwMDAwMCAwMDAwMDAwMCAwMDAwMDAwMCAwMDAwMDAwMCAwMDAwMDAwMCAwMDAwMDAw MCAwMDAwMDAwMAo+IFsgICAgOS4yNjE2NDFdIGJmZTA6IDAwMDAwMDAwIDAwMDAwMDAwIDAwMDAw MDAwIDAwMDAwMDAwIDAwMDAwMDEzIDAwMDAwMDAwCj4gWyAgICA5LjI2MTY2M10gIHIxMDowMDAw MDAwMCByOTowMDAwMDAwMCByODowMDAwMDAwMCByNzowMDAwMDAwMCByNjowMDAwMDAwMCByNTpj MDI2NTcwMAo+IFsgICAgOS4yNjE2ODNdICByNDplNDYyMjA4MAo+IFsgICAgOS4yNjE3MjhdIGtv YmplY3RfYWRkX2ludGVybmFsIGZhaWxlZCBmb3Igc2NtaV9ub3RpZnkgd2l0aCAtRUVYSVNULCBk b24ndCB0cnkgdG8gcmVnaXN0ZXIgdGhpbmdzIHdpdGggdGhlIHNhbWUgbmFtZSBpbiB0aGUgc2Ft ZSBkaXJlY3RvcnkuCj4gWyAgICA5LjI2MTgwNV0gYXJtLXNjbWkgYnJjbV9zY21pQDE6IFNDTUkg Tm90aWZpY2F0aW9ucyAtIEluaXRpYWxpemF0aW9uIEZhaWxlZC4KPiBbICAgIDkuMjYxODQ3XSBh cm0tc2NtaSBicmNtX3NjbWlAMTogU0NNSSBOb3RpZmljYXRpb25zIE5PVCBhdmFpbGFibGUuCj4g WyAgICA5LjI2MjAyNl0gYXJtLXNjbWkgYnJjbV9zY21pQDE6IFNDTUkgUHJvdG9jb2wgdjEuMCAn YnJjbS1zY21pOicgRmlybXdhcmUgdmVyc2lvbiAweDEKPiAKPiBGaXggdGhpcyBieSB1c2luZyBk ZXZfbmFtZShoYW5kbGUtPmRldikgd2hpY2ggZ3VhcmFudGVlcyB0aGF0IHRoZSBuYW1lIGlzCj4g dW5pcXVlIGFuZCB0aGlzIGFsc28gaGVscHMgY29ycmVsYXRlIHdoaWNoIG5vdGlmaWNhdGlvbiB3 b3JrcXVldWUgY29ycmVzcG9uZHMKPiB0byB3aGljaCBTQ01JIGRldmljZSBpbnN0YW5jZS4KPgoK SSBhbSBjdXJpb3VzIGFzIGhvdyBtdWx0aXBsZSBTQ01JIGluc3RhbmNlcyBhcmUgdXNlZC4gV2Ug a25vdyBmZXcgbGltaXRhdGlvbnMKaW4gdGhlIGNvZGUgdG8gaGFuZGxlIHRoYXQgeWV0LCBzbyBp bnRlcmVzdGVkIHRvIGtub3cgaWYgeW91IGFyZSBjYXJyeWluZwptb3JlIHBhdGNoZXMvZml4ZXMu Cgo+IEZpeGVzOiBiZDMxYjI0OTY5MmUgKCJmaXJtd2FyZTogYXJtX3NjbWk6IEFkZCBub3RpZmlj YXRpb24gZGlzcGF0Y2ggYW5kIGRlbGl2ZXJ5IikKPiBTaWduZWQtb2ZmLWJ5OiBGbG9yaWFuIEZh aW5lbGxpIDxmLmZhaW5lbGxpQGdtYWlsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9maXJtd2FyZS9h cm1fc2NtaS9ub3RpZnkuYyB8IDIgKy0KPiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCsp LCAxIGRlbGV0aW9uKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZmlybXdhcmUvYXJtX3Nj bWkvbm90aWZ5LmMgYi9kcml2ZXJzL2Zpcm13YXJlL2FybV9zY21pL25vdGlmeS5jCj4gaW5kZXgg NDczMWRhYWFjZDE5Li4yNGM5ZWYyMzJmNDggMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9maXJtd2Fy ZS9hcm1fc2NtaS9ub3RpZnkuYwo+ICsrKyBiL2RyaXZlcnMvZmlybXdhcmUvYXJtX3NjbWkvbm90 aWZ5LmMKPiBAQCAtMTQ2OCw3ICsxNDY4LDcgQEAgaW50IHNjbWlfbm90aWZpY2F0aW9uX2luaXQo c3RydWN0IHNjbWlfaGFuZGxlICpoYW5kbGUpCj4gIAluaS0+Z2lkID0gZ2lkOwo+ICAJbmktPmhh bmRsZSA9IGhhbmRsZTsKPiAgCj4gLQluaS0+bm90aWZ5X3dxID0gYWxsb2Nfd29ya3F1ZXVlKCJz Y21pX25vdGlmeSIsCj4gKwluaS0+bm90aWZ5X3dxID0gYWxsb2Nfd29ya3F1ZXVlKGRldl9uYW1l KGhhbmRsZS0+ZGV2KSwKCk5vdCBzdXJlIGlmIGl0IG1ha2VzIHNlbnNlIHRvIGFkZCAiX25vdGlm eSIgdG8gY2xlYXJseSBpZGVudGlmeSB0aGUgd29ya3F1ZXVlLgoKPiAgCQkJCQlXUV9VTkJPVU5E IHwgV1FfRlJFRVpBQkxFIHwgV1FfU1lTRlMsCj4gIAkJCQkJMCk7Cj4gIAlpZiAoIW5pLT5ub3Rp Znlfd3EpCj4gLS0gCj4gMi4yNS4xCj4gCgotLSAKUmVnYXJkcywKU3VkZWVwCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1h aWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xp c3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21FC4C433E7 for ; Wed, 14 Oct 2020 09:18:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C0E9520B1F for ; Wed, 14 Oct 2020 09:18:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729320AbgJNJSM (ORCPT ); Wed, 14 Oct 2020 05:18:12 -0400 Received: from foss.arm.com ([217.140.110.172]:57534 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726323AbgJNJSM (ORCPT ); Wed, 14 Oct 2020 05:18:12 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7D8F730E; Wed, 14 Oct 2020 02:18:11 -0700 (PDT) Received: from bogus (unknown [10.57.12.254]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4266A3F73C; Wed, 14 Oct 2020 02:18:10 -0700 (PDT) Date: Wed, 14 Oct 2020 10:18:06 +0100 From: Sudeep Holla To: Florian Fainelli Cc: linux-arm-kernel@lists.infradead.org, Jonathan Cameron , Cristian Marussi , linux-kernel@vger.kernel.org Subject: Re: [PATCH] firmware: arm_scmi: Fix duplicate workqueue name Message-ID: <20201014091806.GB20315@bogus> References: <20201014021737.287340-1-f.fainelli@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201014021737.287340-1-f.fainelli@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Florian, Thanks for the patch, it shows someone else is also using this and testing 😉. On Tue, Oct 13, 2020 at 07:17:37PM -0700, Florian Fainelli wrote: > When more than a single SCMI device are present in the system, the > creation of the notification workqueue with the WQ_SYSFS flag will lead > to the following sysfs duplicate node warning: > Please trim the calltrace next time without timestamp and register raw hex values. You using this on 32-bit platform ? If so, thanks for additional test coverage. > [ 9.259990] sysfs: cannot create duplicate filename '/devices/virtual/workqueue/scmi_notify' > [ 9.260024] CPU: 0 PID: 20 Comm: kworker/0:1 Not tainted 5.9.0-gdf4dd84a3f7d #29 > [ 9.260045] Hardware name: Broadcom STB (Flattened Device Tree) > [ 9.260083] Workqueue: events deferred_probe_work_func > [ 9.260099] Backtrace: > [ 9.260127] [] (dump_backtrace) from [] (show_stack+0x20/0x24) > [ 9.260155] r9:ffffffff r8:00000000 r7:c298e3c0 r6:60000013 r5:00000000 r4:c298e3c0 > [ 9.260186] [] (show_stack) from [] (dump_stack+0xbc/0xe0) > [ 9.260216] [] (dump_stack) from [] (sysfs_warn_dup+0x70/0x80) > [ 9.260243] r10:e472d814 r9:ffffffef r8:e4614a50 r7:c2806d48 r6:e0e50f80 r5:e4614a50 > [ 9.260265] r4:e0e82000 r3:c5b17c34 > [ 9.260285] [] (sysfs_warn_dup) from [] (sysfs_create_dir_ns+0x15c/0x1a4) > [ 9.260310] r7:c2806d48 r6:ffffffef r5:e0dff008 r4:bb8cd6e4 > [ 9.260335] [] (sysfs_create_dir_ns) from [] (kobject_add_internal+0x140/0x4d0) > [ 9.260363] r9:e451fa80 r8:e0dff01c r7:e0dff014 r6:e45b1400 r5:e0dff018 r4:e0dff008 > [ 9.260390] [] (kobject_add_internal) from [] (kobject_add+0xc8/0x138) > [ 9.260416] r10:e0dff030 r9:00000000 r8:e45b1400 r7:00000000 r6:c2806d48 r5:e0dff008 > [ 9.260436] r4:bb8cd708 > [ 9.260455] [] (kobject_add) from [] (device_add+0x1dc/0xc20) > [ 9.260476] r3:e0dff014 r2:00000000 > [ 9.260495] r9:00000000 r8:e466b980 r7:e45b1400 r6:c2806d48 r5:bb8cd724 r4:e0dff008 > [ 9.260521] [] (device_add) from [] (device_register+0x24/0x28) > [ 9.260547] r10:c2831340 r9:e0dfec08 r8:e0dff028 r7:e0dfecc0 r6:e0dfec00 r5:e0dff008 > [ 9.260567] r4:e0dff008 > [ 9.260586] [] (device_register) from [] (workqueue_sysfs_register+0xe4/0x1f0) > [ 9.260609] r5:e0dff008 r4:e0dff000 > [ 9.260627] [] (workqueue_sysfs_register) from [] (alloc_workqueue+0x448/0x6ac) > [ 9.260655] r10:e0dfecc0 r9:e0dfec08 r8:e0dfec0c r7:e0dfec04 r6:e0dfecc0 r5:e0dfec00 > [ 9.260675] r4:00000001 > [ 9.260698] [] (alloc_workqueue) from [] (scmi_notification_init+0x78/0x1dc) > [ 9.260720] r3:c0a1b488 r2:00000000 > [ 9.260739] r10:e0de1040 r9:00800004 r8:e0de10d8 r7:e0de10f4 r6:e0de1074 r5:e0e54740 > [ 9.260759] r4:e0e50d00 > [ 9.260778] [] (scmi_notification_init) from [] (scmi_probe+0x268/0x4fc) > [ 9.260805] r9:00800004 r8:e0de10d8 r7:e0de10f4 r6:e0de1074 r5:e0de10f0 r4:e472d810 > [ 9.260833] [] (scmi_probe) from [] (platform_drv_probe+0x70/0xc8) > [ 9.260859] r10:e472d844 r9:c2ab02b4 r8:c2b5e298 r7:00000000 r6:c2ab02b4 r5:00000000 > [ 9.260879] r4:e472d810 > [ 9.260898] [] (platform_drv_probe) from [] (really_probe+0x184/0x728) > [ 9.260922] r7:00000000 r6:c2fc82a0 r5:c2fc8220 r4:e472d810 > [ 9.260946] [] (really_probe) from [] (driver_probe_device+0xa4/0x278) > [ 9.260973] r10:e0cef438 r9:c0a14a04 r8:c2b771c0 r7:c2b5e298 r6:c2ab02b4 r5:e472d834 > [ 9.260993] r4:e472d810 > [ 9.261014] [] (driver_probe_device) from [] (__device_attach_driver+0xe8/0x148) > [ 9.261042] r10:e0cef438 r9:c0a14a04 r8:e466bdc0 r7:e472d810 r6:00000000 r5:c2ab02b4 > [ 9.261062] r4:e466bdc0 > [ 9.261082] [] (__device_attach_driver) from [] (bus_for_each_drv+0x108/0x158) > [ 9.261107] r7:c2806d48 r6:00000000 r5:bb8cd79c r4:e466bd00 > [ 9.261131] [] (bus_for_each_drv) from [] (__device_attach+0x190/0x234) > [ 9.261158] r10:e46fde00 r9:e472d848 r8:e472d854 r7:e466be00 r6:c2806d48 r5:bb8cd7b4 > [ 9.261178] r4:e472d810 > [ 9.261199] [] (__device_attach) from [] (device_initial_probe+0x1c/0x20) > [ 9.261226] r10:e46fde54 r9:c29d6380 r8:c29d7910 r7:e472d810 r6:c29d78c0 r5:c29d6340 > [ 9.261246] r4:e44efe00 > [ 9.261266] [] (device_initial_probe) from [] (bus_probe_device+0xdc/0xec) > [ 9.261296] [] (bus_probe_device) from [] (deferred_probe_work_func+0xd4/0x11c) > [ 9.261324] r9:c29d6380 r8:e4672e54 r7:c29d6380 r6:c29d6340 r5:c29d6340 r4:e472d810 > [ 9.261356] [] (deferred_probe_work_func) from [] (process_one_work+0x420/0x8f0) > [ 9.261384] r10:e452fd84 r9:c2b53750 r8:00000000 r7:e452ae0c r6:e8a1e240 r5:e452ae00 > [ 9.261404] r4:c29d6440 > [ 9.261424] [] (process_one_work) from [] (worker_thread+0x4fc/0x91c) > [ 9.261450] r10:e8a1e258 r9:e452ae00 r8:e8a1e254 r7:e8a1e240 r6:e452fd84 r5:e8a1e254 > [ 9.261470] r4:e452ae14 > [ 9.261492] [] (worker_thread) from [] (kthread+0x21c/0x22c) > [ 9.261517] r10:e455bce0 r9:e45b8d80 r8:e452ae00 r7:c025aa04 r6:e45b8d80 r5:00000000 > [ 9.261537] r4:e45c0400 > [ 9.261555] [] (kthread) from [] (ret_from_fork+0x14/0x20) > [ 9.261575] Exception stack(0xe466bfb0 to 0xe466bff8) > [ 9.261593] bfa0: 00000000 00000000 00000000 00000000 > [ 9.261618] bfc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 > [ 9.261641] bfe0: 00000000 00000000 00000000 00000000 00000013 00000000 > [ 9.261663] r10:00000000 r9:00000000 r8:00000000 r7:00000000 r6:00000000 r5:c0265700 > [ 9.261683] r4:e4622080 > [ 9.261728] kobject_add_internal failed for scmi_notify with -EEXIST, don't try to register things with the same name in the same directory. > [ 9.261805] arm-scmi brcm_scmi@1: SCMI Notifications - Initialization Failed. > [ 9.261847] arm-scmi brcm_scmi@1: SCMI Notifications NOT available. > [ 9.262026] arm-scmi brcm_scmi@1: SCMI Protocol v1.0 'brcm-scmi:' Firmware version 0x1 > > Fix this by using dev_name(handle->dev) which guarantees that the name is > unique and this also helps correlate which notification workqueue corresponds > to which SCMI device instance. > I am curious as how multiple SCMI instances are used. We know few limitations in the code to handle that yet, so interested to know if you are carrying more patches/fixes. > Fixes: bd31b249692e ("firmware: arm_scmi: Add notification dispatch and delivery") > Signed-off-by: Florian Fainelli > --- > drivers/firmware/arm_scmi/notify.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/firmware/arm_scmi/notify.c b/drivers/firmware/arm_scmi/notify.c > index 4731daaacd19..24c9ef232f48 100644 > --- a/drivers/firmware/arm_scmi/notify.c > +++ b/drivers/firmware/arm_scmi/notify.c > @@ -1468,7 +1468,7 @@ int scmi_notification_init(struct scmi_handle *handle) > ni->gid = gid; > ni->handle = handle; > > - ni->notify_wq = alloc_workqueue("scmi_notify", > + ni->notify_wq = alloc_workqueue(dev_name(handle->dev), Not sure if it makes sense to add "_notify" to clearly identify the workqueue. > WQ_UNBOUND | WQ_FREEZABLE | WQ_SYSFS, > 0); > if (!ni->notify_wq) > -- > 2.25.1 > -- Regards, Sudeep