From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D07AC43467 for ; Wed, 14 Oct 2020 13:32:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C1FFF22203 for ; Wed, 14 Oct 2020 13:32:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602682346; bh=fEnh2yKV+NuzCH5mUByQ4ZTH+rxHrkGz8doH8Y8/sB0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=mv6Avc4n3f7LJJXDqP4u0E9RSJjrhxgmBf7ppPWT5jzeYY+sW+3I+nypaQlRnT0Vi WOsV1vYDZAPaUJf3TV4ABxjv6a+1Pg4qyP5xH0nJrNzNdDDljsKxa6sTXjj2++KFXF dDrqtLwCVVFFpnbWKf048oqko9s9z5Y3slY+qdUI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727703AbgJNNcX (ORCPT ); Wed, 14 Oct 2020 09:32:23 -0400 Received: from mail-oi1-f195.google.com ([209.85.167.195]:41310 "EHLO mail-oi1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727250AbgJNNcW (ORCPT ); Wed, 14 Oct 2020 09:32:22 -0400 Received: by mail-oi1-f195.google.com with SMTP id q136so3207636oic.8; Wed, 14 Oct 2020 06:32:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=RfUVv3fCiTl2E9POO6Buswiqzr2whvPDBuKBRK/9qXo=; b=Br2rDl/wy/hG61xdFs1wMZ/sr69Q+sP0b/xcZpwc2PDXB71uy7D+XpvGpwb26tJdHo d2GssCjK4eFZCXwl03Gkfkb3xOVDKEck7USPf8wwRrC6XBCCjewR4OJsG/RPcpvExITA WqOcxQNQo1vl/GaZy4w97ZHsW44qcglKfjKQEX883xERjL2esP7bUTQlGKDjIyeNzaWu JMApsr6wpBAuiNgeyTXbJYVkyQvGJMq0uy0+09L6UnWlUK7aAmhU+hZoZ6J7qN9o92Zi iwoE4tEJS5jRhf9WPLYteKE9kctJrFvHUBolOtwUgoExiqdr+D5UH5cPeEBlQhC4BviO GaMw== X-Gm-Message-State: AOAM530lNJfDpF9cCUG6TLwCQuDMYcBUHmuKbwnWoribjHbRe5A7VNq5 GjQTAHQQyb5zTPVmLpFkug== X-Google-Smtp-Source: ABdhPJxd/P4qzAtPsd2916G42APosJoO+yYmHIG+zpWj3QmjNHSypnWafNQcsvqbK5VxDOltQFbAXQ== X-Received: by 2002:aca:ea84:: with SMTP id i126mr1059134oih.98.1602682341597; Wed, 14 Oct 2020 06:32:21 -0700 (PDT) Received: from xps15 (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id 92sm1204900otl.1.2020.10.14.06.32.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Oct 2020 06:32:20 -0700 (PDT) Received: (nullmailer pid 1546268 invoked by uid 1000); Wed, 14 Oct 2020 13:32:19 -0000 Date: Wed, 14 Oct 2020 08:32:19 -0500 From: Rob Herring To: Serge Semin Cc: Yoshihiro Shimoda , Andy Gross , linux-kernel@vger.kernel.org, Neil Armstrong , linux-usb@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Bjorn Andersson , Rob Herring , Pavel Parkhomenko , Greg Kroah-Hartman , Kevin Hilman , Alexey Malahov , Serge Semin , Felipe Balbi , Roger Quadros , linux-arm-kernel@lists.infradead.org, Lad Prabhakar , Mathias Nyman , linux-snps-arc@lists.infradead.org, Manu Gautam , devicetree@vger.kernel.org Subject: Re: [PATCH 09/20] dt-bindings: usb: Convert DWC USB3 bindings to DT schema Message-ID: <20201014133219.GA1545403@bogus> References: <20201014101402.18271-1-Sergey.Semin@baikalelectronics.ru> <20201014101402.18271-10-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201014101402.18271-10-Sergey.Semin@baikalelectronics.ru> Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Wed, 14 Oct 2020 13:13:51 +0300, Serge Semin wrote: > DWC USB3 DT node is supposed to be compliant with the Generic xHCI > Controller schema, but with additional vendor-specific properties, the > controller-specific reference clocks and PHYs. So let's convert the > currently available legacy text-based DWC USB3 bindings to the DT schema > and make sure the DWC USB3 nodes are also validated against the > usb-xhci.yaml schema. > > Note we have to discard the nodename restriction of being prefixed with > "dwc3@" string, since in accordance with the usb-hcd.yaml schema USB nodes > are supposed to be named as "^usb(@.*)". > > Signed-off-by: Serge Semin > > --- > > Changelog v2: > - Discard '|' from the descriptions, since we don't need to preserve > the text formatting in any of them. > - Drop quotes from around the string constants. > - Fix the "clock-names" prop description to be referring the enumerated > clock-names instead of the ones from the Databook. > --- > .../devicetree/bindings/usb/dwc3.txt | 125 -------- > .../devicetree/bindings/usb/snps,dwc3.yaml | 295 ++++++++++++++++++ > 2 files changed, 295 insertions(+), 125 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/usb/dwc3.txt > create mode 100644 Documentation/devicetree/bindings/usb/snps,dwc3.yaml > My bot found errors running 'make dt_binding_check' on your patch: ./Documentation/devicetree/bindings/usb/snps,dwc3.yaml:44:4: [warning] wrong indentation: expected 4 but found 3 (indentation) /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/qcom,dwc3.example.dt.yaml: dwc3@a600000: $nodename:0: 'dwc3@a600000' does not match '^usb(@.*)?' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/snps,dwc3.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.example.dt.yaml: usb@ff500000: snps,quirk-frame-length-adjustment: True is not of type 'array' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/snps,dwc3.yaml See https://patchwork.ozlabs.org/patch/1382003 If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure dt-schema is up to date: pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade Please check and re-submit. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1626DC433E7 for ; Wed, 14 Oct 2020 13:32:29 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9CFEB22202 for ; Wed, 14 Oct 2020 13:32:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WoSlMQ+2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9CFEB22202 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qlDU00WqrSVjZ5ZYGOnLyrryOkcjRPAeAqMTLji+pag=; b=WoSlMQ+2MLf5MIvkhtHvACVsa yD4wcvn0s7O8UGFFgqiebv6jJGo/hUGlUIlhSBzduBzz5rHPQ6H88YUwKPOKPYEL51ggA3Li8WqP1 mdwF3sm5xvuc83dmYB9SZb6z3PqJN0q0RNIgQtkfuwNTXrfoSRPtyEkyUH2MkKsKo0xVv2t3MXo4I gBx6fwmnr2SntcZ+r4niKBHWo4GC+a7LNhQbO9qxe7ITkcTX+8p3UqwlUhxGKiefDZHtc8pTRLHOt NauzfiN7fzO3RnbPlGVzkjp3K1z2E0Go8VsszTKTeMJn0PtuoGhe7SB9JCyg+VJ2v4YShv7qNeJ62 gk7erSETQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kSgtH-0005az-Rb; Wed, 14 Oct 2020 13:32:27 +0000 Received: from mail-oi1-f194.google.com ([209.85.167.194]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kSgtC-0005Z8-O0; Wed, 14 Oct 2020 13:32:23 +0000 Received: by mail-oi1-f194.google.com with SMTP id s81so3174518oie.13; Wed, 14 Oct 2020 06:32:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=RfUVv3fCiTl2E9POO6Buswiqzr2whvPDBuKBRK/9qXo=; b=oh1FOPjDj3ZIuTAthvZ4Fr8d7J1saRSuGMRC9/K1jBIjcnMEVFmv/hN+Rl8GaeEEfR /9YwvBUfafZLmLtWPytejQ6E7SFc9ZnkKZeO1jKZ7M5YuO+lPDl1GIg5+mON8Ss6GhwN L4oe4QbyOibIAFfmhWQxtwrXwQJruj2HD5fzDFYW6jq2IgoRdSa6pBTGMP6FoZpM9GDv xAT9+Nu+MKLisSmp+KTFDIEn9IsIxncQ8jgLfnBccCzbocEGT/AyFBz7g6J4rvz2/BT9 w2OWzTGPvf+pEIcmcMMvenE0jZ59MiTtQxunDWmskIS6F47LnsjE8NxbXIBfZH5Y+RmL vvYQ== X-Gm-Message-State: AOAM530gVJkq3cP04UphVjJVaGpgwJNZfFiSBIg+JqJ7+QHhXmVUM+L1 7x3zj71cX/8YiuugUUXEWw== X-Google-Smtp-Source: ABdhPJxd/P4qzAtPsd2916G42APosJoO+yYmHIG+zpWj3QmjNHSypnWafNQcsvqbK5VxDOltQFbAXQ== X-Received: by 2002:aca:ea84:: with SMTP id i126mr1059134oih.98.1602682341597; Wed, 14 Oct 2020 06:32:21 -0700 (PDT) Received: from xps15 (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id 92sm1204900otl.1.2020.10.14.06.32.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Oct 2020 06:32:20 -0700 (PDT) Received: (nullmailer pid 1546268 invoked by uid 1000); Wed, 14 Oct 2020 13:32:19 -0000 Date: Wed, 14 Oct 2020 08:32:19 -0500 From: Rob Herring To: Serge Semin Subject: Re: [PATCH 09/20] dt-bindings: usb: Convert DWC USB3 bindings to DT schema Message-ID: <20201014133219.GA1545403@bogus> References: <20201014101402.18271-1-Sergey.Semin@baikalelectronics.ru> <20201014101402.18271-10-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201014101402.18271-10-Sergey.Semin@baikalelectronics.ru> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201014_093222_813331_A606B026 X-CRM114-Status: GOOD ( 16.96 ) X-BeenThere: linux-snps-arc@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on Synopsys ARC Processors List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , linux-kernel@vger.kernel.org, Pavel Parkhomenko , Kevin Hilman , Andy Gross , linux-snps-arc@lists.infradead.org, devicetree@vger.kernel.org, Mathias Nyman , Lad Prabhakar , Alexey Malahov , Rob Herring , Bjorn Andersson , linux-arm-kernel@lists.infradead.org, Roger Quadros , Felipe Balbi , Greg Kroah-Hartman , Yoshihiro Shimoda , linux-usb@vger.kernel.org, linux-mips@vger.kernel.org, Serge Semin , Manu Gautam , linuxppc-dev@lists.ozlabs.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org On Wed, 14 Oct 2020 13:13:51 +0300, Serge Semin wrote: > DWC USB3 DT node is supposed to be compliant with the Generic xHCI > Controller schema, but with additional vendor-specific properties, the > controller-specific reference clocks and PHYs. So let's convert the > currently available legacy text-based DWC USB3 bindings to the DT schema > and make sure the DWC USB3 nodes are also validated against the > usb-xhci.yaml schema. > > Note we have to discard the nodename restriction of being prefixed with > "dwc3@" string, since in accordance with the usb-hcd.yaml schema USB nodes > are supposed to be named as "^usb(@.*)". > > Signed-off-by: Serge Semin > > --- > > Changelog v2: > - Discard '|' from the descriptions, since we don't need to preserve > the text formatting in any of them. > - Drop quotes from around the string constants. > - Fix the "clock-names" prop description to be referring the enumerated > clock-names instead of the ones from the Databook. > --- > .../devicetree/bindings/usb/dwc3.txt | 125 -------- > .../devicetree/bindings/usb/snps,dwc3.yaml | 295 ++++++++++++++++++ > 2 files changed, 295 insertions(+), 125 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/usb/dwc3.txt > create mode 100644 Documentation/devicetree/bindings/usb/snps,dwc3.yaml > My bot found errors running 'make dt_binding_check' on your patch: ./Documentation/devicetree/bindings/usb/snps,dwc3.yaml:44:4: [warning] wrong indentation: expected 4 but found 3 (indentation) /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/qcom,dwc3.example.dt.yaml: dwc3@a600000: $nodename:0: 'dwc3@a600000' does not match '^usb(@.*)?' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/snps,dwc3.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.example.dt.yaml: usb@ff500000: snps,quirk-frame-length-adjustment: True is not of type 'array' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/snps,dwc3.yaml See https://patchwork.ozlabs.org/patch/1382003 If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure dt-schema is up to date: pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade Please check and re-submit. _______________________________________________ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAA3FC433DF for ; Wed, 14 Oct 2020 13:35:43 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F30DD22203 for ; Wed, 14 Oct 2020 13:35:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F30DD22203 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4CBD233qhgzDqs2 for ; Thu, 15 Oct 2020 00:35:39 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=209.85.167.193; helo=mail-oi1-f193.google.com; envelope-from=robherring2@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=fail (p=none dis=none) header.from=kernel.org Received: from mail-oi1-f193.google.com (mail-oi1-f193.google.com [209.85.167.193]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4CBCyJ4HkPzDqXJ for ; Thu, 15 Oct 2020 00:32:24 +1100 (AEDT) Received: by mail-oi1-f193.google.com with SMTP id x62so3191149oix.11 for ; Wed, 14 Oct 2020 06:32:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=RfUVv3fCiTl2E9POO6Buswiqzr2whvPDBuKBRK/9qXo=; b=lXj7gwDc6nUa11Z4qLbBduPlTgdeqgzfxb+KeQAaze7H2/SWx6ISQEaXOYgBgz11fJ DX4VOOUoCfQXqCCc9TMJ2G6QEYRHBa/f3t0CcUnOKkekvJQJ/AT0Df0G1WMoWuETC+kt vljpM0N3JqSrE6ejzhabV2NX482k6zo2EqZdwku8kNcVJBDUzpWZQt99pTq7RvS6xkFh j8g5sPbC9yp/OQo3pd9WzOMV/mvIPbnc6EOU0bKegVcuy1Yhk+WMuwKfbQwukPjtOKxg cj3Wp4A5O3pvUfvIWOaTHszEtM0PO1yYs3Bnsx4yx0q/rYqOsoehYdzw/SS+CLQoSJff 5Xyw== X-Gm-Message-State: AOAM5331jnqg7fB4fkQBIwzYyZV4phTxw1mPdMcuJYble3q/w9P7l8+I MvYJm4IrGY1Avo+2gMw/1g== X-Google-Smtp-Source: ABdhPJxd/P4qzAtPsd2916G42APosJoO+yYmHIG+zpWj3QmjNHSypnWafNQcsvqbK5VxDOltQFbAXQ== X-Received: by 2002:aca:ea84:: with SMTP id i126mr1059134oih.98.1602682341597; Wed, 14 Oct 2020 06:32:21 -0700 (PDT) Received: from xps15 (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id 92sm1204900otl.1.2020.10.14.06.32.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Oct 2020 06:32:20 -0700 (PDT) Received: (nullmailer pid 1546268 invoked by uid 1000); Wed, 14 Oct 2020 13:32:19 -0000 Date: Wed, 14 Oct 2020 08:32:19 -0500 From: Rob Herring To: Serge Semin Subject: Re: [PATCH 09/20] dt-bindings: usb: Convert DWC USB3 bindings to DT schema Message-ID: <20201014133219.GA1545403@bogus> References: <20201014101402.18271-1-Sergey.Semin@baikalelectronics.ru> <20201014101402.18271-10-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201014101402.18271-10-Sergey.Semin@baikalelectronics.ru> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , linux-kernel@vger.kernel.org, Pavel Parkhomenko , Kevin Hilman , Andy Gross , linux-snps-arc@lists.infradead.org, devicetree@vger.kernel.org, Mathias Nyman , Lad Prabhakar , Alexey Malahov , Rob Herring , Bjorn Andersson , linux-arm-kernel@lists.infradead.org, Roger Quadros , Felipe Balbi , Greg Kroah-Hartman , Yoshihiro Shimoda , linux-usb@vger.kernel.org, linux-mips@vger.kernel.org, Serge Semin , Manu Gautam , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed, 14 Oct 2020 13:13:51 +0300, Serge Semin wrote: > DWC USB3 DT node is supposed to be compliant with the Generic xHCI > Controller schema, but with additional vendor-specific properties, the > controller-specific reference clocks and PHYs. So let's convert the > currently available legacy text-based DWC USB3 bindings to the DT schema > and make sure the DWC USB3 nodes are also validated against the > usb-xhci.yaml schema. > > Note we have to discard the nodename restriction of being prefixed with > "dwc3@" string, since in accordance with the usb-hcd.yaml schema USB nodes > are supposed to be named as "^usb(@.*)". > > Signed-off-by: Serge Semin > > --- > > Changelog v2: > - Discard '|' from the descriptions, since we don't need to preserve > the text formatting in any of them. > - Drop quotes from around the string constants. > - Fix the "clock-names" prop description to be referring the enumerated > clock-names instead of the ones from the Databook. > --- > .../devicetree/bindings/usb/dwc3.txt | 125 -------- > .../devicetree/bindings/usb/snps,dwc3.yaml | 295 ++++++++++++++++++ > 2 files changed, 295 insertions(+), 125 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/usb/dwc3.txt > create mode 100644 Documentation/devicetree/bindings/usb/snps,dwc3.yaml > My bot found errors running 'make dt_binding_check' on your patch: ./Documentation/devicetree/bindings/usb/snps,dwc3.yaml:44:4: [warning] wrong indentation: expected 4 but found 3 (indentation) /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/qcom,dwc3.example.dt.yaml: dwc3@a600000: $nodename:0: 'dwc3@a600000' does not match '^usb(@.*)?' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/snps,dwc3.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.example.dt.yaml: usb@ff500000: snps,quirk-frame-length-adjustment: True is not of type 'array' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/snps,dwc3.yaml See https://patchwork.ozlabs.org/patch/1382003 If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure dt-schema is up to date: pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade Please check and re-submit. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B30EFC433DF for ; Wed, 14 Oct 2020 13:33:47 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3C47C22202 for ; Wed, 14 Oct 2020 13:33:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WxLwkgJP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3C47C22202 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=uzlPB/lZ2jPEO0JsIgMXYwV/TkIVyLnzna/fximJDWQ=; b=WxLwkgJPowAZg68DXMApPZrLX vn7EfF/IqVnMNUN3Bloit3MviY9MJ7cpz+iVmhmmXOEnD6gZ8tuHyFOmvqcwr8OsKpnhpa8txlweP 2mSuYLxi31/oAj+xtxg9wnzCUKQPEDRLSJlFJPYW9ff1izTBDeVoVcAcMsF6mUg9GblFO3X4GX8iA 3Ey70OXzc1xGNQnXDWKzoDrukrsi4k/+9FBLOBFm1v0hdgxIEFVsOz7g9jGLKDkunzCx4VQWr3p2C Ud9gZAKJ/kTwywNeMm7LdPFS8EcmwZG9tfhRyq3TpJvT9ZBAtYi51s16YKBe/d8+BHb5b7ULfz8yL S8rawGN2w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kSgtF-0005a4-Jn; Wed, 14 Oct 2020 13:32:25 +0000 Received: from mail-oi1-f194.google.com ([209.85.167.194]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kSgtC-0005Z8-O0; Wed, 14 Oct 2020 13:32:23 +0000 Received: by mail-oi1-f194.google.com with SMTP id s81so3174518oie.13; Wed, 14 Oct 2020 06:32:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=RfUVv3fCiTl2E9POO6Buswiqzr2whvPDBuKBRK/9qXo=; b=oh1FOPjDj3ZIuTAthvZ4Fr8d7J1saRSuGMRC9/K1jBIjcnMEVFmv/hN+Rl8GaeEEfR /9YwvBUfafZLmLtWPytejQ6E7SFc9ZnkKZeO1jKZ7M5YuO+lPDl1GIg5+mON8Ss6GhwN L4oe4QbyOibIAFfmhWQxtwrXwQJruj2HD5fzDFYW6jq2IgoRdSa6pBTGMP6FoZpM9GDv xAT9+Nu+MKLisSmp+KTFDIEn9IsIxncQ8jgLfnBccCzbocEGT/AyFBz7g6J4rvz2/BT9 w2OWzTGPvf+pEIcmcMMvenE0jZ59MiTtQxunDWmskIS6F47LnsjE8NxbXIBfZH5Y+RmL vvYQ== X-Gm-Message-State: AOAM530gVJkq3cP04UphVjJVaGpgwJNZfFiSBIg+JqJ7+QHhXmVUM+L1 7x3zj71cX/8YiuugUUXEWw== X-Google-Smtp-Source: ABdhPJxd/P4qzAtPsd2916G42APosJoO+yYmHIG+zpWj3QmjNHSypnWafNQcsvqbK5VxDOltQFbAXQ== X-Received: by 2002:aca:ea84:: with SMTP id i126mr1059134oih.98.1602682341597; Wed, 14 Oct 2020 06:32:21 -0700 (PDT) Received: from xps15 (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id 92sm1204900otl.1.2020.10.14.06.32.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Oct 2020 06:32:20 -0700 (PDT) Received: (nullmailer pid 1546268 invoked by uid 1000); Wed, 14 Oct 2020 13:32:19 -0000 Date: Wed, 14 Oct 2020 08:32:19 -0500 From: Rob Herring To: Serge Semin Subject: Re: [PATCH 09/20] dt-bindings: usb: Convert DWC USB3 bindings to DT schema Message-ID: <20201014133219.GA1545403@bogus> References: <20201014101402.18271-1-Sergey.Semin@baikalelectronics.ru> <20201014101402.18271-10-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201014101402.18271-10-Sergey.Semin@baikalelectronics.ru> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201014_093222_813331_A606B026 X-CRM114-Status: GOOD ( 16.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , linux-kernel@vger.kernel.org, Pavel Parkhomenko , Kevin Hilman , Andy Gross , linux-snps-arc@lists.infradead.org, devicetree@vger.kernel.org, Mathias Nyman , Lad Prabhakar , Alexey Malahov , Rob Herring , Bjorn Andersson , linux-arm-kernel@lists.infradead.org, Roger Quadros , Felipe Balbi , Greg Kroah-Hartman , Yoshihiro Shimoda , linux-usb@vger.kernel.org, linux-mips@vger.kernel.org, Serge Semin , Manu Gautam , linuxppc-dev@lists.ozlabs.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 14 Oct 2020 13:13:51 +0300, Serge Semin wrote: > DWC USB3 DT node is supposed to be compliant with the Generic xHCI > Controller schema, but with additional vendor-specific properties, the > controller-specific reference clocks and PHYs. So let's convert the > currently available legacy text-based DWC USB3 bindings to the DT schema > and make sure the DWC USB3 nodes are also validated against the > usb-xhci.yaml schema. > > Note we have to discard the nodename restriction of being prefixed with > "dwc3@" string, since in accordance with the usb-hcd.yaml schema USB nodes > are supposed to be named as "^usb(@.*)". > > Signed-off-by: Serge Semin > > --- > > Changelog v2: > - Discard '|' from the descriptions, since we don't need to preserve > the text formatting in any of them. > - Drop quotes from around the string constants. > - Fix the "clock-names" prop description to be referring the enumerated > clock-names instead of the ones from the Databook. > --- > .../devicetree/bindings/usb/dwc3.txt | 125 -------- > .../devicetree/bindings/usb/snps,dwc3.yaml | 295 ++++++++++++++++++ > 2 files changed, 295 insertions(+), 125 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/usb/dwc3.txt > create mode 100644 Documentation/devicetree/bindings/usb/snps,dwc3.yaml > My bot found errors running 'make dt_binding_check' on your patch: ./Documentation/devicetree/bindings/usb/snps,dwc3.yaml:44:4: [warning] wrong indentation: expected 4 but found 3 (indentation) /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/qcom,dwc3.example.dt.yaml: dwc3@a600000: $nodename:0: 'dwc3@a600000' does not match '^usb(@.*)?' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/snps,dwc3.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.example.dt.yaml: usb@ff500000: snps,quirk-frame-length-adjustment: True is not of type 'array' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/snps,dwc3.yaml See https://patchwork.ozlabs.org/patch/1382003 If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure dt-schema is up to date: pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade Please check and re-submit. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel