From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD207C433DF for ; Wed, 14 Oct 2020 13:50:06 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 21FEE22201 for ; Wed, 14 Oct 2020 13:50:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="3U1oixCa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 21FEE22201 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7j2Fl+xTq84o0FJWrbBZ+X1ld3J7l8IR6kC2lPDM3GI=; b=3U1oixCajytX4NmxrNegzZdTd BdicSq6JmvxAMTROHk6HpZ3QDa5tv4VcKBZrx2T9IvrR0GlUHZYVepYdX3G5fYBq+I5CQ9dzvb89P pwbi4iQiKukmzr6MEbTYgIByZxZwa5MC/6uuUGoJcjVLRp34UGo6fvgE9YkkWY1axu0/Br7Te0Rx1 GLUcwhWQxIL8vIFChNKryK3csVKPyN4ZKDx0HNFoWONHW1CnJ/7FYMYufaCFPOVV72rwbgyYO+osq DUtOxXR8hs4aV0+U8CNXnDyFiM8iPEfrZqV29pbsvQhGApK77/FQC4WtgKAReoEVx52oR6LE3XCcP d8F9l8EPg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kSh8o-0008Et-71; Wed, 14 Oct 2020 13:48:30 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kSh8k-0008Cl-18 for linux-arm-kernel@lists.infradead.org; Wed, 14 Oct 2020 13:48:27 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E510D31B; Wed, 14 Oct 2020 06:48:22 -0700 (PDT) Received: from e120937-lin (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 12B8F3F71F; Wed, 14 Oct 2020 06:48:21 -0700 (PDT) Date: Wed, 14 Oct 2020 14:48:19 +0100 From: Cristian Marussi To: Sudeep Holla Subject: Re: [PATCH] firmware: arm_scmi: Fix duplicate workqueue name Message-ID: <20201014134819.GA24061@e120937-lin> References: <20201014021737.287340-1-f.fainelli@gmail.com> <20201014091806.GB20315@bogus> <20201014130524.cj42wknvzdpgsbsr@bogus> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201014130524.cj42wknvzdpgsbsr@bogus> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201014_094826_164335_5142E9A9 X-CRM114-Status: GOOD ( 36.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Florian Fainelli , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jonathan Cameron Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkKCk9uIFdlZCwgT2N0IDE0LCAyMDIwIGF0IDAyOjA1OjI0UE0gKzAxMDAsIFN1ZGVlcCBIb2xs YSB3cm90ZToKPiBPbiBXZWQsIE9jdCAxNCwgMjAyMCBhdCAxMDoxODowNkFNICswMTAwLCBTdWRl ZXAgSG9sbGEgd3JvdGU6Cj4gPiBIaSBGbG9yaWFuLAo+ID4gCj4gPiBUaGFua3MgZm9yIHRoZSBw YXRjaCwgaXQgc2hvd3Mgc29tZW9uZSBlbHNlIGlzIGFsc28gdXNpbmcgdGhpcyBhbmQKPiA+IHRl c3Rpbmcg8J+YiS4KPiA+IAo+ID4gT24gVHVlLCBPY3QgMTMsIDIwMjAgYXQgMDc6MTc6MzdQTSAt MDcwMCwgRmxvcmlhbiBGYWluZWxsaSB3cm90ZToKPiA+ID4gV2hlbiBtb3JlIHRoYW4gYSBzaW5n bGUgU0NNSSBkZXZpY2UgYXJlIHByZXNlbnQgaW4gdGhlIHN5c3RlbSwgdGhlCj4gPiA+IGNyZWF0 aW9uIG9mIHRoZSBub3RpZmljYXRpb24gd29ya3F1ZXVlIHdpdGggdGhlIFdRX1NZU0ZTIGZsYWcg d2lsbCBsZWFkCj4gPiA+IHRvIHRoZSBmb2xsb3dpbmcgc3lzZnMgZHVwbGljYXRlIG5vZGUgd2Fy bmluZzoKPiA+ID4gCj4gPiAKPiA+IFBsZWFzZSB0cmltIHRoZSBjYWxsdHJhY2UgbmV4dCB0aW1l IHdpdGhvdXQgdGltZXN0YW1wIGFuZCByZWdpc3RlciByYXcKPiA+IGhleCB2YWx1ZXMuCj4gPiAK PiA+IFlvdSB1c2luZyB0aGlzIG9uIDMyLWJpdCBwbGF0Zm9ybSA/IElmIHNvLCB0aGFua3MgZm9y IGFkZGl0aW9uYWwgdGVzdAo+ID4gY292ZXJhZ2UuCj4gPiAKPiA+ID4gWyAgICA5LjI1OTk5MF0g c3lzZnM6IGNhbm5vdCBjcmVhdGUgZHVwbGljYXRlIGZpbGVuYW1lICcvZGV2aWNlcy92aXJ0dWFs L3dvcmtxdWV1ZS9zY21pX25vdGlmeScKPiA+ID4gWyAgICA5LjI2MDAyNF0gQ1BVOiAwIFBJRDog MjAgQ29tbToga3dvcmtlci8wOjEgTm90IHRhaW50ZWQgNS45LjAtZ2RmNGRkODRhM2Y3ZCAjMjkK PiA+ID4gWyAgICA5LjI2MDA0NV0gSGFyZHdhcmUgbmFtZTogQnJvYWRjb20gU1RCIChGbGF0dGVu ZWQgRGV2aWNlIFRyZWUpCj4gPiA+IFsgICAgOS4yNjAwODNdIFdvcmtxdWV1ZTogZXZlbnRzIGRl ZmVycmVkX3Byb2JlX3dvcmtfZnVuYwo+ID4gPiBbICAgIDkuMjYwMDk5XSBCYWNrdHJhY2U6Cj4g PiA+IFsgICAgOS4yNjAxMjddIFs8YzAyMTIwYjQ+XSAoZHVtcF9iYWNrdHJhY2UpIGZyb20gWzxj MDIxMjNkOD5dIChzaG93X3N0YWNrKzB4MjAvMHgyNCkKPiA+ID4gWyAgICA5LjI2MDE1NV0gIHI5 OmZmZmZmZmZmIHI4OjAwMDAwMDAwIHI3OmMyOThlM2MwIHI2OjYwMDAwMDEzIHI1OjAwMDAwMDAw IHI0OmMyOThlM2MwCj4gPiA+IFsgICAgOS4yNjAxODZdIFs8YzAyMTIzYjg+XSAoc2hvd19zdGFj aykgZnJvbSBbPGMwODg1MmEwPl0gKGR1bXBfc3RhY2srMHhiYy8weGUwKQo+ID4gPiBbICAgIDku MjYwMjE2XSBbPGMwODg1MWU0Pl0gKGR1bXBfc3RhY2spIGZyb20gWzxjMDU0NDQyYz5dIChzeXNm c193YXJuX2R1cCsweDcwLzB4ODApCj4gPiA+IFsgICAgOS4yNjAyNDNdICByMTA6ZTQ3MmQ4MTQg cjk6ZmZmZmZmZWYgcjg6ZTQ2MTRhNTAgcjc6YzI4MDZkNDggcjY6ZTBlNTBmODAgcjU6ZTQ2MTRh NTAKPiA+ID4gWyAgICA5LjI2MDI2NV0gIHI0OmUwZTgyMDAwIHIzOmM1YjE3YzM0Cj4gPiA+IFsg ICAgOS4yNjAyODVdIFs8YzA1NDQzYmM+XSAoc3lzZnNfd2Fybl9kdXApIGZyb20gWzxjMDU0NDVm Yz5dIChzeXNmc19jcmVhdGVfZGlyX25zKzB4MTVjLzB4MWE0KQo+ID4gPiBbICAgIDkuMjYwMzEw XSAgcjc6YzI4MDZkNDggcjY6ZmZmZmZmZWYgcjU6ZTBkZmYwMDggcjQ6YmI4Y2Q2ZTQKPiA+ID4g WyAgICA5LjI2MDMzNV0gWzxjMDU0NDRhMD5dIChzeXNmc19jcmVhdGVfZGlyX25zKSBmcm9tIFs8 YzA4OGViYWM+XSAoa29iamVjdF9hZGRfaW50ZXJuYWwrMHgxNDAvMHg0ZDApCj4gPiA+IFsgICAg OS4yNjAzNjNdICByOTplNDUxZmE4MCByODplMGRmZjAxYyByNzplMGRmZjAxNCByNjplNDViMTQw MCByNTplMGRmZjAxOCByNDplMGRmZjAwOAo+ID4gPiBbICAgIDkuMjYwMzkwXSBbPGMwODhlYTZj Pl0gKGtvYmplY3RfYWRkX2ludGVybmFsKSBmcm9tIFs8YzA4OGYwMDQ+XSAoa29iamVjdF9hZGQr MHhjOC8weDEzOCkKPiA+ID4gWyAgICA5LjI2MDQxNl0gIHIxMDplMGRmZjAzMCByOTowMDAwMDAw MCByODplNDViMTQwMCByNzowMDAwMDAwMCByNjpjMjgwNmQ0OCByNTplMGRmZjAwOAo+ID4gPiBb ICAgIDkuMjYwNDM2XSAgcjQ6YmI4Y2Q3MDgKPiA+ID4gWyAgICA5LjI2MDQ1NV0gWzxjMDg4ZWYz Yz5dIChrb2JqZWN0X2FkZCkgZnJvbSBbPGMwYTBiYzcwPl0gKGRldmljZV9hZGQrMHgxZGMvMHhj MjApCj4gPiA+IFsgICAgOS4yNjA0NzZdICByMzplMGRmZjAxNCByMjowMDAwMDAwMAo+ID4gPiBb ICAgIDkuMjYwNDk1XSAgcjk6MDAwMDAwMDAgcjg6ZTQ2NmI5ODAgcjc6ZTQ1YjE0MDAgcjY6YzI4 MDZkNDggcjU6YmI4Y2Q3MjQgcjQ6ZTBkZmYwMDgKPiA+ID4gWyAgICA5LjI2MDUyMV0gWzxjMGEw YmE5ND5dIChkZXZpY2VfYWRkKSBmcm9tIFs8YzBhMGM2ZDg+XSAoZGV2aWNlX3JlZ2lzdGVyKzB4 MjQvMHgyOCkKPiA+ID4gWyAgICA5LjI2MDU0N10gIHIxMDpjMjgzMTM0MCByOTplMGRmZWMwOCBy ODplMGRmZjAyOCByNzplMGRmZWNjMCByNjplMGRmZWMwMCByNTplMGRmZjAwOAo+ID4gPiBbICAg IDkuMjYwNTY3XSAgcjQ6ZTBkZmYwMDgKPiA+ID4gWyAgICA5LjI2MDU4Nl0gWzxjMGEwYzZiND5d IChkZXZpY2VfcmVnaXN0ZXIpIGZyb20gWzxjMDI1ZjJhOD5dICh3b3JrcXVldWVfc3lzZnNfcmVn aXN0ZXIrMHhlNC8weDFmMCkKPiA+ID4gWyAgICA5LjI2MDYwOV0gIHI1OmUwZGZmMDA4IHI0OmUw ZGZmMDAwCj4gPiA+IFsgICAgOS4yNjA2MjddIFs8YzAyNWYxYzQ+XSAod29ya3F1ZXVlX3N5c2Zz X3JlZ2lzdGVyKSBmcm9tIFs8YzAyNWY3ZmM+XSAoYWxsb2Nfd29ya3F1ZXVlKzB4NDQ4LzB4NmFj KQo+ID4gPiBbICAgIDkuMjYwNjU1XSAgcjEwOmUwZGZlY2MwIHI5OmUwZGZlYzA4IHI4OmUwZGZl YzBjIHI3OmUwZGZlYzA0IHI2OmUwZGZlY2MwIHI1OmUwZGZlYzAwCj4gPiA+IFsgICAgOS4yNjA2 NzVdICByNDowMDAwMDAwMQo+ID4gPiBbICAgIDkuMjYwNjk4XSBbPGMwMjVmM2I0Pl0gKGFsbG9j X3dvcmtxdWV1ZSkgZnJvbSBbPGMwZDhiNThjPl0gKHNjbWlfbm90aWZpY2F0aW9uX2luaXQrMHg3 OC8weDFkYykKPiA+ID4gWyAgICA5LjI2MDcyMF0gIHIzOmMwYTFiNDg4IHIyOjAwMDAwMDAwCj4g PiA+IFsgICAgOS4yNjA3MzldICByMTA6ZTBkZTEwNDAgcjk6MDA4MDAwMDQgcjg6ZTBkZTEwZDgg cjc6ZTBkZTEwZjQgcjY6ZTBkZTEwNzQgcjU6ZTBlNTQ3NDAKPiA+ID4gWyAgICA5LjI2MDc1OV0g IHI0OmUwZTUwZDAwCj4gPiA+IFsgICAgOS4yNjA3NzhdIFs8YzBkOGI1MTQ+XSAoc2NtaV9ub3Rp ZmljYXRpb25faW5pdCkgZnJvbSBbPGMwZDg3YzAwPl0gKHNjbWlfcHJvYmUrMHgyNjgvMHg0ZmMp Cj4gPiA+IFsgICAgOS4yNjA4MDVdICByOTowMDgwMDAwNCByODplMGRlMTBkOCByNzplMGRlMTBm NCByNjplMGRlMTA3NCByNTplMGRlMTBmMCByNDplNDcyZDgxMAo+ID4gPiBbICAgIDkuMjYwODMz XSBbPGMwZDg3OTk4Pl0gKHNjbWlfcHJvYmUpIGZyb20gWzxjMGExN2Q3ND5dIChwbGF0Zm9ybV9k cnZfcHJvYmUrMHg3MC8weGM4KQo+ID4gPiBbICAgIDkuMjYwODU5XSAgcjEwOmU0NzJkODQ0IHI5 OmMyYWIwMmI0IHI4OmMyYjVlMjk4IHI3OjAwMDAwMDAwIHI2OmMyYWIwMmI0IHI1OjAwMDAwMDAw Cj4gPiA+IFsgICAgOS4yNjA4NzldICByNDplNDcyZDgxMAo+ID4gPiBbICAgIDkuMjYwODk4XSBb PGMwYTE3ZDA0Pl0gKHBsYXRmb3JtX2Rydl9wcm9iZSkgZnJvbSBbPGMwYTEzZTgwPl0gKHJlYWxs eV9wcm9iZSsweDE4NC8weDcyOCkKPiA+ID4gWyAgICA5LjI2MDkyMl0gIHI3OjAwMDAwMDAwIHI2 OmMyZmM4MmEwIHI1OmMyZmM4MjIwIHI0OmU0NzJkODEwCj4gPiA+IFsgICAgOS4yNjA5NDZdIFs8 YzBhMTNjZmM+XSAocmVhbGx5X3Byb2JlKSBmcm9tIFs8YzBhMTQ2YjQ+XSAoZHJpdmVyX3Byb2Jl X2RldmljZSsweGE0LzB4Mjc4KQo+ID4gPiBbICAgIDkuMjYwOTczXSAgcjEwOmUwY2VmNDM4IHI5 OmMwYTE0YTA0IHI4OmMyYjc3MWMwIHI3OmMyYjVlMjk4IHI2OmMyYWIwMmI0IHI1OmU0NzJkODM0 Cj4gPiA+IFsgICAgOS4yNjA5OTNdICByNDplNDcyZDgxMAo+ID4gPiBbICAgIDkuMjYxMDE0XSBb PGMwYTE0NjEwPl0gKGRyaXZlcl9wcm9iZV9kZXZpY2UpIGZyb20gWzxjMGExNGFlYz5dIChfX2Rl dmljZV9hdHRhY2hfZHJpdmVyKzB4ZTgvMHgxNDgpCj4gPiA+IFsgICAgOS4yNjEwNDJdICByMTA6 ZTBjZWY0Mzggcjk6YzBhMTRhMDQgcjg6ZTQ2NmJkYzAgcjc6ZTQ3MmQ4MTAgcjY6MDAwMDAwMDAg cjU6YzJhYjAyYjQKPiA+ID4gWyAgICA5LjI2MTA2Ml0gIHI0OmU0NjZiZGMwCj4gPiA+IFsgICAg OS4yNjEwODJdIFs8YzBhMTRhMDQ+XSAoX19kZXZpY2VfYXR0YWNoX2RyaXZlcikgZnJvbSBbPGMw YTEwZjZjPl0gKGJ1c19mb3JfZWFjaF9kcnYrMHgxMDgvMHgxNTgpCj4gPiA+IFsgICAgOS4yNjEx MDddICByNzpjMjgwNmQ0OCByNjowMDAwMDAwMCByNTpiYjhjZDc5YyByNDplNDY2YmQwMAo+ID4g PiBbICAgIDkuMjYxMTMxXSBbPGMwYTEwZTY0Pl0gKGJ1c19mb3JfZWFjaF9kcnYpIGZyb20gWzxj MGExM2MzOD5dIChfX2RldmljZV9hdHRhY2grMHgxOTAvMHgyMzQpCj4gPiA+IFsgICAgOS4yNjEx NThdICByMTA6ZTQ2ZmRlMDAgcjk6ZTQ3MmQ4NDggcjg6ZTQ3MmQ4NTQgcjc6ZTQ2NmJlMDAgcjY6 YzI4MDZkNDggcjU6YmI4Y2Q3YjQKPiA+ID4gWyAgICA5LjI2MTE3OF0gIHI0OmU0NzJkODEwCj4g PiA+IFsgICAgOS4yNjExOTldIFs8YzBhMTNhYTg+XSAoX19kZXZpY2VfYXR0YWNoKSBmcm9tIFs8 YzBhMTRiNjg+XSAoZGV2aWNlX2luaXRpYWxfcHJvYmUrMHgxYy8weDIwKQo+ID4gPiBbICAgIDku MjYxMjI2XSAgcjEwOmU0NmZkZTU0IHI5OmMyOWQ2MzgwIHI4OmMyOWQ3OTEwIHI3OmU0NzJkODEw IHI2OmMyOWQ3OGMwIHI1OmMyOWQ2MzQwCj4gPiA+IFsgICAgOS4yNjEyNDZdICByNDplNDRlZmUw MAo+ID4gPiBbICAgIDkuMjYxMjY2XSBbPGMwYTE0YjRjPl0gKGRldmljZV9pbml0aWFsX3Byb2Jl KSBmcm9tIFs8YzBhMTI1ZmM+XSAoYnVzX3Byb2JlX2RldmljZSsweGRjLzB4ZWMpCj4gPiA+IFsg ICAgOS4yNjEyOTZdIFs8YzBhMTI1MjA+XSAoYnVzX3Byb2JlX2RldmljZSkgZnJvbSBbPGMwYTEy ZTI0Pl0gKGRlZmVycmVkX3Byb2JlX3dvcmtfZnVuYysweGQ0LzB4MTFjKQo+ID4gPiBbICAgIDku MjYxMzI0XSAgcjk6YzI5ZDYzODAgcjg6ZTQ2NzJlNTQgcjc6YzI5ZDYzODAgcjY6YzI5ZDYzNDAg cjU6YzI5ZDYzNDAgcjQ6ZTQ3MmQ4MTAKPiA+ID4gWyAgICA5LjI2MTM1Nl0gWzxjMGExMmQ1MD5d IChkZWZlcnJlZF9wcm9iZV93b3JrX2Z1bmMpIGZyb20gWzxjMDI1YTUzND5dIChwcm9jZXNzX29u ZV93b3JrKzB4NDIwLzB4OGYwKQo+ID4gPiBbICAgIDkuMjYxMzg0XSAgcjEwOmU0NTJmZDg0IHI5 OmMyYjUzNzUwIHI4OjAwMDAwMDAwIHI3OmU0NTJhZTBjIHI2OmU4YTFlMjQwIHI1OmU0NTJhZTAw Cj4gPiA+IFsgICAgOS4yNjE0MDRdICByNDpjMjlkNjQ0MAo+ID4gPiBbICAgIDkuMjYxNDI0XSBb PGMwMjVhMTE0Pl0gKHByb2Nlc3Nfb25lX3dvcmspIGZyb20gWzxjMDI1YWYwMD5dICh3b3JrZXJf dGhyZWFkKzB4NGZjLzB4OTFjKQo+ID4gPiBbICAgIDkuMjYxNDUwXSAgcjEwOmU4YTFlMjU4IHI5 OmU0NTJhZTAwIHI4OmU4YTFlMjU0IHI3OmU4YTFlMjQwIHI2OmU0NTJmZDg0IHI1OmU4YTFlMjU0 Cj4gPiA+IFsgICAgOS4yNjE0NzBdICByNDplNDUyYWUxNAo+ID4gPiBbICAgIDkuMjYxNDkyXSBb PGMwMjVhYTA0Pl0gKHdvcmtlcl90aHJlYWQpIGZyb20gWzxjMDI2NTkxYz5dIChrdGhyZWFkKzB4 MjFjLzB4MjJjKQo+ID4gPiBbICAgIDkuMjYxNTE3XSAgcjEwOmU0NTViY2UwIHI5OmU0NWI4ZDgw IHI4OmU0NTJhZTAwIHI3OmMwMjVhYTA0IHI2OmU0NWI4ZDgwIHI1OjAwMDAwMDAwCj4gPiA+IFsg ICAgOS4yNjE1MzddICByNDplNDVjMDQwMAo+ID4gPiBbICAgIDkuMjYxNTU1XSBbPGMwMjY1NzAw Pl0gKGt0aHJlYWQpIGZyb20gWzxjMDIwMDExND5dIChyZXRfZnJvbV9mb3JrKzB4MTQvMHgyMCkK PiA+ID4gWyAgICA5LjI2MTU3NV0gRXhjZXB0aW9uIHN0YWNrKDB4ZTQ2NmJmYjAgdG8gMHhlNDY2 YmZmOCkKPiA+ID4gWyAgICA5LjI2MTU5M10gYmZhMDogICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgMDAwMDAwMDAgMDAwMDAwMDAgMDAwMDAwMDAgMDAwMDAwMDAKPiA+ID4gWyAg ICA5LjI2MTYxOF0gYmZjMDogMDAwMDAwMDAgMDAwMDAwMDAgMDAwMDAwMDAgMDAwMDAwMDAgMDAw MDAwMDAgMDAwMDAwMDAgMDAwMDAwMDAgMDAwMDAwMDAKPiA+ID4gWyAgICA5LjI2MTY0MV0gYmZl MDogMDAwMDAwMDAgMDAwMDAwMDAgMDAwMDAwMDAgMDAwMDAwMDAgMDAwMDAwMTMgMDAwMDAwMDAK PiA+ID4gWyAgICA5LjI2MTY2M10gIHIxMDowMDAwMDAwMCByOTowMDAwMDAwMCByODowMDAwMDAw MCByNzowMDAwMDAwMCByNjowMDAwMDAwMCByNTpjMDI2NTcwMAo+ID4gPiBbICAgIDkuMjYxNjgz XSAgcjQ6ZTQ2MjIwODAKPiA+ID4gWyAgICA5LjI2MTcyOF0ga29iamVjdF9hZGRfaW50ZXJuYWwg ZmFpbGVkIGZvciBzY21pX25vdGlmeSB3aXRoIC1FRVhJU1QsIGRvbid0IHRyeSB0byByZWdpc3Rl ciB0aGluZ3Mgd2l0aCB0aGUgc2FtZSBuYW1lIGluIHRoZSBzYW1lIGRpcmVjdG9yeS4KPiA+ID4g WyAgICA5LjI2MTgwNV0gYXJtLXNjbWkgYnJjbV9zY21pQDE6IFNDTUkgTm90aWZpY2F0aW9ucyAt IEluaXRpYWxpemF0aW9uIEZhaWxlZC4KPiA+ID4gWyAgICA5LjI2MTg0N10gYXJtLXNjbWkgYnJj bV9zY21pQDE6IFNDTUkgTm90aWZpY2F0aW9ucyBOT1QgYXZhaWxhYmxlLgo+ID4gPiBbICAgIDku MjYyMDI2XSBhcm0tc2NtaSBicmNtX3NjbWlAMTogU0NNSSBQcm90b2NvbCB2MS4wICdicmNtLXNj bWk6JyBGaXJtd2FyZSB2ZXJzaW9uIDB4MQo+ID4gPiAKPiA+ID4gRml4IHRoaXMgYnkgdXNpbmcg ZGV2X25hbWUoaGFuZGxlLT5kZXYpIHdoaWNoIGd1YXJhbnRlZXMgdGhhdCB0aGUgbmFtZSBpcwo+ ID4gPiB1bmlxdWUgYW5kIHRoaXMgYWxzbyBoZWxwcyBjb3JyZWxhdGUgd2hpY2ggbm90aWZpY2F0 aW9uIHdvcmtxdWV1ZSBjb3JyZXNwb25kcwo+ID4gPiB0byB3aGljaCBTQ01JIGRldmljZSBpbnN0 YW5jZS4KPiA+ID4KPiA+IAo+ID4gSSBhbSBjdXJpb3VzIGFzIGhvdyBtdWx0aXBsZSBTQ01JIGlu c3RhbmNlcyBhcmUgdXNlZC4gV2Uga25vdyBmZXcgbGltaXRhdGlvbnMKPiA+IGluIHRoZSBjb2Rl IHRvIGhhbmRsZSB0aGF0IHlldCwgc28gaW50ZXJlc3RlZCB0byBrbm93IGlmIHlvdSBhcmUgY2Fy cnlpbmcKPiA+IG1vcmUgcGF0Y2hlcy9maXhlcy4KPiA+IAo+ID4gPiBGaXhlczogYmQzMWIyNDk2 OTJlICgiZmlybXdhcmU6IGFybV9zY21pOiBBZGQgbm90aWZpY2F0aW9uIGRpc3BhdGNoIGFuZCBk ZWxpdmVyeSIpCj4gPiA+IFNpZ25lZC1vZmYtYnk6IEZsb3JpYW4gRmFpbmVsbGkgPGYuZmFpbmVs bGlAZ21haWwuY29tPgo+ID4gPiAtLS0KPiA+ID4gIGRyaXZlcnMvZmlybXdhcmUvYXJtX3NjbWkv bm90aWZ5LmMgfCAyICstCj4gPiA+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEg ZGVsZXRpb24oLSkKPiA+ID4gCj4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2Zpcm13YXJlL2Fy bV9zY21pL25vdGlmeS5jIGIvZHJpdmVycy9maXJtd2FyZS9hcm1fc2NtaS9ub3RpZnkuYwo+ID4g PiBpbmRleCA0NzMxZGFhYWNkMTkuLjI0YzllZjIzMmY0OCAxMDA2NDQKPiA+ID4gLS0tIGEvZHJp dmVycy9maXJtd2FyZS9hcm1fc2NtaS9ub3RpZnkuYwo+ID4gPiArKysgYi9kcml2ZXJzL2Zpcm13 YXJlL2FybV9zY21pL25vdGlmeS5jCj4gPiA+IEBAIC0xNDY4LDcgKzE0NjgsNyBAQCBpbnQgc2Nt aV9ub3RpZmljYXRpb25faW5pdChzdHJ1Y3Qgc2NtaV9oYW5kbGUgKmhhbmRsZSkKPiA+ID4gIAlu aS0+Z2lkID0gZ2lkOwo+ID4gPiAgCW5pLT5oYW5kbGUgPSBoYW5kbGU7Cj4gPiA+ICAKPiA+ID4g LQluaS0+bm90aWZ5X3dxID0gYWxsb2Nfd29ya3F1ZXVlKCJzY21pX25vdGlmeSIsCj4gPiA+ICsJ bmktPm5vdGlmeV93cSA9IGFsbG9jX3dvcmtxdWV1ZShkZXZfbmFtZShoYW5kbGUtPmRldiksCj4g PiAKPiA+IE5vdCBzdXJlIGlmIGl0IG1ha2VzIHNlbnNlIHRvIGFkZCAiX25vdGlmeSIgdG8gY2xl YXJseSBpZGVudGlmeSB0aGUgd29ya3F1ZXVlLgo+ID4gCj4gCj4gSSBoYXZlIHB1c2hlZCBhIHZl cnNpb24gd2l0aCBhYm92ZSBjaGFuZ2UgWzFdLCBwbGVhc2UgY2hlY2sgaWYgeW91IGFyZQo+IGhh cHB5IHdpdGggdGhhdCA/Cj4gCj4gLS0gCj4gUmVnYXJkcywKPiBTdWRlZXAKPiAKPiBbMV0gaHR0 cHM6Ly9naXQua2VybmVsLm9yZy9zdWRlZXAuaG9sbGEvbGludXgvYy9iMmNkMTU1NDliCgpJIGFn cmVlIHdpdGggdGhlIG5lZWQgdG8gcmV0YWluIF9ub3RpZnkgbmFtZSwgYnV0IEknbSBub3Qgc28g c3VyZSBhYm91dAp0aGUgYWJvdmUgcGF0Y2guLi53aGljaCBpczoKCgpkaWZmIC0tZ2l0IGEvZHJp dmVycy9maXJtd2FyZS9hcm1fc2NtaS9ub3RpZnkuYyBiL2RyaXZlcnMvZmlybXdhcmUvYXJtX3Nj bWkvbm90aWZ5LmMKaW5kZXggYzI0ZTQyN2RjZTBkNy4uZjYwZmE2MzBkZDk4ZiAxMDA2NDQKLS0t IGEvZHJpdmVycy9maXJtd2FyZS9hcm1fc2NtaS9ub3RpZnkuYworKysgYi9kcml2ZXJzL2Zpcm13 YXJlL2FybV9zY21pL25vdGlmeS5jCkBAIC0xNDYxLDYgKzE0NjEsNyBAQCBzdGF0aWMgY29uc3Qg c3RydWN0IHNjbWlfbm90aWZ5X29wcyBub3RpZnlfb3BzID0gewogaW50IHNjbWlfbm90aWZpY2F0 aW9uX2luaXQoc3RydWN0IHNjbWlfaGFuZGxlICpoYW5kbGUpCiB7CiAJdm9pZCAqZ2lkOworCWNo YXIgc2NtaV93cV9uYW1lWzMyXTsKIAlzdHJ1Y3Qgc2NtaV9ub3RpZnlfaW5zdGFuY2UgKm5pOwog CiAJZ2lkID0gZGV2cmVzX29wZW5fZ3JvdXAoaGFuZGxlLT5kZXYsIE5VTEwsIEdGUF9LRVJORUwp OwpAQCAtMTQ3NCw3ICsxNDc1LDggQEAgaW50IHNjbWlfbm90aWZpY2F0aW9uX2luaXQoc3RydWN0 IHNjbWlfaGFuZGxlICpoYW5kbGUpCiAJbmktPmdpZCA9IGdpZDsKIAluaS0+aGFuZGxlID0gaGFu ZGxlOwogCi0JbmktPm5vdGlmeV93cSA9IGFsbG9jX3dvcmtxdWV1ZSgic2NtaV9ub3RpZnkiLAor CXNwcmludGYoc2NtaV93cV9uYW1lLCAiJXNfbm90aWZ5IiwgZGV2X25hbWUoaGFuZGxlLT5kZXYp KTsKKwluaS0+bm90aWZ5X3dxID0gYWxsb2Nfd29ya3F1ZXVlKHNjbWlfd3FfbmFtZSwKIAkJCQkJ V1FfVU5CT1VORCB8IFdRX0ZSRUVaQUJMRSB8IFdRX1NZU0ZTLAogCQkJCQkwKTsKIAlpZiAoIW5p LT5ub3RpZnlfd3EpCgoKLi4uZG9lcyBub3QgZXhwb3NlIGEgcG90ZW50aWFsIGJ1ZmZlciBvdmVy ZmxvdyBnaXZlbiB0aGF0IHRoZSBkZXZfbmFtZSBub3cgY29tZXMKZnJvbSB0aGUgRFQgY2hvc2Vu IG5hbWUgZm9yIHRoaXMgU0NNSSBzZXJ2ZXIgaW5zdGFuY2UgPwoKSSdkIHVzZSBzbnByaW50ZiBh bmQgZW5sYXJnZSBhIGJpdCB0aGUgc3RhdGljIHNjbWlfd3FfbmFtZVtdIHRvIGZpdCBhIG1heApk ZXZpY2UgYmFuZSBwbHVzICJfbm90aWZ5Ii4KClJlZ2FyZHMKCkNyaXN0aWFuCgoKCgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVs IG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDov L2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D83D1C433E7 for ; Wed, 14 Oct 2020 13:48:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 886E422202 for ; Wed, 14 Oct 2020 13:48:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731396AbgJNNsY (ORCPT ); Wed, 14 Oct 2020 09:48:24 -0400 Received: from foss.arm.com ([217.140.110.172]:49006 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729537AbgJNNsY (ORCPT ); Wed, 14 Oct 2020 09:48:24 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E510D31B; Wed, 14 Oct 2020 06:48:22 -0700 (PDT) Received: from e120937-lin (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 12B8F3F71F; Wed, 14 Oct 2020 06:48:21 -0700 (PDT) Date: Wed, 14 Oct 2020 14:48:19 +0100 From: Cristian Marussi To: Sudeep Holla Cc: Florian Fainelli , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jonathan Cameron Subject: Re: [PATCH] firmware: arm_scmi: Fix duplicate workqueue name Message-ID: <20201014134819.GA24061@e120937-lin> References: <20201014021737.287340-1-f.fainelli@gmail.com> <20201014091806.GB20315@bogus> <20201014130524.cj42wknvzdpgsbsr@bogus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201014130524.cj42wknvzdpgsbsr@bogus> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi On Wed, Oct 14, 2020 at 02:05:24PM +0100, Sudeep Holla wrote: > On Wed, Oct 14, 2020 at 10:18:06AM +0100, Sudeep Holla wrote: > > Hi Florian, > > > > Thanks for the patch, it shows someone else is also using this and > > testing 😉. > > > > On Tue, Oct 13, 2020 at 07:17:37PM -0700, Florian Fainelli wrote: > > > When more than a single SCMI device are present in the system, the > > > creation of the notification workqueue with the WQ_SYSFS flag will lead > > > to the following sysfs duplicate node warning: > > > > > > > Please trim the calltrace next time without timestamp and register raw > > hex values. > > > > You using this on 32-bit platform ? If so, thanks for additional test > > coverage. > > > > > [ 9.259990] sysfs: cannot create duplicate filename '/devices/virtual/workqueue/scmi_notify' > > > [ 9.260024] CPU: 0 PID: 20 Comm: kworker/0:1 Not tainted 5.9.0-gdf4dd84a3f7d #29 > > > [ 9.260045] Hardware name: Broadcom STB (Flattened Device Tree) > > > [ 9.260083] Workqueue: events deferred_probe_work_func > > > [ 9.260099] Backtrace: > > > [ 9.260127] [] (dump_backtrace) from [] (show_stack+0x20/0x24) > > > [ 9.260155] r9:ffffffff r8:00000000 r7:c298e3c0 r6:60000013 r5:00000000 r4:c298e3c0 > > > [ 9.260186] [] (show_stack) from [] (dump_stack+0xbc/0xe0) > > > [ 9.260216] [] (dump_stack) from [] (sysfs_warn_dup+0x70/0x80) > > > [ 9.260243] r10:e472d814 r9:ffffffef r8:e4614a50 r7:c2806d48 r6:e0e50f80 r5:e4614a50 > > > [ 9.260265] r4:e0e82000 r3:c5b17c34 > > > [ 9.260285] [] (sysfs_warn_dup) from [] (sysfs_create_dir_ns+0x15c/0x1a4) > > > [ 9.260310] r7:c2806d48 r6:ffffffef r5:e0dff008 r4:bb8cd6e4 > > > [ 9.260335] [] (sysfs_create_dir_ns) from [] (kobject_add_internal+0x140/0x4d0) > > > [ 9.260363] r9:e451fa80 r8:e0dff01c r7:e0dff014 r6:e45b1400 r5:e0dff018 r4:e0dff008 > > > [ 9.260390] [] (kobject_add_internal) from [] (kobject_add+0xc8/0x138) > > > [ 9.260416] r10:e0dff030 r9:00000000 r8:e45b1400 r7:00000000 r6:c2806d48 r5:e0dff008 > > > [ 9.260436] r4:bb8cd708 > > > [ 9.260455] [] (kobject_add) from [] (device_add+0x1dc/0xc20) > > > [ 9.260476] r3:e0dff014 r2:00000000 > > > [ 9.260495] r9:00000000 r8:e466b980 r7:e45b1400 r6:c2806d48 r5:bb8cd724 r4:e0dff008 > > > [ 9.260521] [] (device_add) from [] (device_register+0x24/0x28) > > > [ 9.260547] r10:c2831340 r9:e0dfec08 r8:e0dff028 r7:e0dfecc0 r6:e0dfec00 r5:e0dff008 > > > [ 9.260567] r4:e0dff008 > > > [ 9.260586] [] (device_register) from [] (workqueue_sysfs_register+0xe4/0x1f0) > > > [ 9.260609] r5:e0dff008 r4:e0dff000 > > > [ 9.260627] [] (workqueue_sysfs_register) from [] (alloc_workqueue+0x448/0x6ac) > > > [ 9.260655] r10:e0dfecc0 r9:e0dfec08 r8:e0dfec0c r7:e0dfec04 r6:e0dfecc0 r5:e0dfec00 > > > [ 9.260675] r4:00000001 > > > [ 9.260698] [] (alloc_workqueue) from [] (scmi_notification_init+0x78/0x1dc) > > > [ 9.260720] r3:c0a1b488 r2:00000000 > > > [ 9.260739] r10:e0de1040 r9:00800004 r8:e0de10d8 r7:e0de10f4 r6:e0de1074 r5:e0e54740 > > > [ 9.260759] r4:e0e50d00 > > > [ 9.260778] [] (scmi_notification_init) from [] (scmi_probe+0x268/0x4fc) > > > [ 9.260805] r9:00800004 r8:e0de10d8 r7:e0de10f4 r6:e0de1074 r5:e0de10f0 r4:e472d810 > > > [ 9.260833] [] (scmi_probe) from [] (platform_drv_probe+0x70/0xc8) > > > [ 9.260859] r10:e472d844 r9:c2ab02b4 r8:c2b5e298 r7:00000000 r6:c2ab02b4 r5:00000000 > > > [ 9.260879] r4:e472d810 > > > [ 9.260898] [] (platform_drv_probe) from [] (really_probe+0x184/0x728) > > > [ 9.260922] r7:00000000 r6:c2fc82a0 r5:c2fc8220 r4:e472d810 > > > [ 9.260946] [] (really_probe) from [] (driver_probe_device+0xa4/0x278) > > > [ 9.260973] r10:e0cef438 r9:c0a14a04 r8:c2b771c0 r7:c2b5e298 r6:c2ab02b4 r5:e472d834 > > > [ 9.260993] r4:e472d810 > > > [ 9.261014] [] (driver_probe_device) from [] (__device_attach_driver+0xe8/0x148) > > > [ 9.261042] r10:e0cef438 r9:c0a14a04 r8:e466bdc0 r7:e472d810 r6:00000000 r5:c2ab02b4 > > > [ 9.261062] r4:e466bdc0 > > > [ 9.261082] [] (__device_attach_driver) from [] (bus_for_each_drv+0x108/0x158) > > > [ 9.261107] r7:c2806d48 r6:00000000 r5:bb8cd79c r4:e466bd00 > > > [ 9.261131] [] (bus_for_each_drv) from [] (__device_attach+0x190/0x234) > > > [ 9.261158] r10:e46fde00 r9:e472d848 r8:e472d854 r7:e466be00 r6:c2806d48 r5:bb8cd7b4 > > > [ 9.261178] r4:e472d810 > > > [ 9.261199] [] (__device_attach) from [] (device_initial_probe+0x1c/0x20) > > > [ 9.261226] r10:e46fde54 r9:c29d6380 r8:c29d7910 r7:e472d810 r6:c29d78c0 r5:c29d6340 > > > [ 9.261246] r4:e44efe00 > > > [ 9.261266] [] (device_initial_probe) from [] (bus_probe_device+0xdc/0xec) > > > [ 9.261296] [] (bus_probe_device) from [] (deferred_probe_work_func+0xd4/0x11c) > > > [ 9.261324] r9:c29d6380 r8:e4672e54 r7:c29d6380 r6:c29d6340 r5:c29d6340 r4:e472d810 > > > [ 9.261356] [] (deferred_probe_work_func) from [] (process_one_work+0x420/0x8f0) > > > [ 9.261384] r10:e452fd84 r9:c2b53750 r8:00000000 r7:e452ae0c r6:e8a1e240 r5:e452ae00 > > > [ 9.261404] r4:c29d6440 > > > [ 9.261424] [] (process_one_work) from [] (worker_thread+0x4fc/0x91c) > > > [ 9.261450] r10:e8a1e258 r9:e452ae00 r8:e8a1e254 r7:e8a1e240 r6:e452fd84 r5:e8a1e254 > > > [ 9.261470] r4:e452ae14 > > > [ 9.261492] [] (worker_thread) from [] (kthread+0x21c/0x22c) > > > [ 9.261517] r10:e455bce0 r9:e45b8d80 r8:e452ae00 r7:c025aa04 r6:e45b8d80 r5:00000000 > > > [ 9.261537] r4:e45c0400 > > > [ 9.261555] [] (kthread) from [] (ret_from_fork+0x14/0x20) > > > [ 9.261575] Exception stack(0xe466bfb0 to 0xe466bff8) > > > [ 9.261593] bfa0: 00000000 00000000 00000000 00000000 > > > [ 9.261618] bfc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 > > > [ 9.261641] bfe0: 00000000 00000000 00000000 00000000 00000013 00000000 > > > [ 9.261663] r10:00000000 r9:00000000 r8:00000000 r7:00000000 r6:00000000 r5:c0265700 > > > [ 9.261683] r4:e4622080 > > > [ 9.261728] kobject_add_internal failed for scmi_notify with -EEXIST, don't try to register things with the same name in the same directory. > > > [ 9.261805] arm-scmi brcm_scmi@1: SCMI Notifications - Initialization Failed. > > > [ 9.261847] arm-scmi brcm_scmi@1: SCMI Notifications NOT available. > > > [ 9.262026] arm-scmi brcm_scmi@1: SCMI Protocol v1.0 'brcm-scmi:' Firmware version 0x1 > > > > > > Fix this by using dev_name(handle->dev) which guarantees that the name is > > > unique and this also helps correlate which notification workqueue corresponds > > > to which SCMI device instance. > > > > > > > I am curious as how multiple SCMI instances are used. We know few limitations > > in the code to handle that yet, so interested to know if you are carrying > > more patches/fixes. > > > > > Fixes: bd31b249692e ("firmware: arm_scmi: Add notification dispatch and delivery") > > > Signed-off-by: Florian Fainelli > > > --- > > > drivers/firmware/arm_scmi/notify.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/firmware/arm_scmi/notify.c b/drivers/firmware/arm_scmi/notify.c > > > index 4731daaacd19..24c9ef232f48 100644 > > > --- a/drivers/firmware/arm_scmi/notify.c > > > +++ b/drivers/firmware/arm_scmi/notify.c > > > @@ -1468,7 +1468,7 @@ int scmi_notification_init(struct scmi_handle *handle) > > > ni->gid = gid; > > > ni->handle = handle; > > > > > > - ni->notify_wq = alloc_workqueue("scmi_notify", > > > + ni->notify_wq = alloc_workqueue(dev_name(handle->dev), > > > > Not sure if it makes sense to add "_notify" to clearly identify the workqueue. > > > > I have pushed a version with above change [1], please check if you are > happy with that ? > > -- > Regards, > Sudeep > > [1] https://git.kernel.org/sudeep.holla/linux/c/b2cd15549b I agree with the need to retain _notify name, but I'm not so sure about the above patch...which is: diff --git a/drivers/firmware/arm_scmi/notify.c b/drivers/firmware/arm_scmi/notify.c index c24e427dce0d7..f60fa630dd98f 100644 --- a/drivers/firmware/arm_scmi/notify.c +++ b/drivers/firmware/arm_scmi/notify.c @@ -1461,6 +1461,7 @@ static const struct scmi_notify_ops notify_ops = { int scmi_notification_init(struct scmi_handle *handle) { void *gid; + char scmi_wq_name[32]; struct scmi_notify_instance *ni; gid = devres_open_group(handle->dev, NULL, GFP_KERNEL); @@ -1474,7 +1475,8 @@ int scmi_notification_init(struct scmi_handle *handle) ni->gid = gid; ni->handle = handle; - ni->notify_wq = alloc_workqueue("scmi_notify", + sprintf(scmi_wq_name, "%s_notify", dev_name(handle->dev)); + ni->notify_wq = alloc_workqueue(scmi_wq_name, WQ_UNBOUND | WQ_FREEZABLE | WQ_SYSFS, 0); if (!ni->notify_wq) ...does not expose a potential buffer overflow given that the dev_name now comes from the DT chosen name for this SCMI server instance ? I'd use snprintf and enlarge a bit the static scmi_wq_name[] to fit a max device bane plus "_notify". Regards Cristian