From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 683CEC433DF for ; Wed, 14 Oct 2020 14:04:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1249322202 for ; Wed, 14 Oct 2020 14:04:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388860AbgJNOEn (ORCPT ); Wed, 14 Oct 2020 10:04:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388859AbgJNOEn (ORCPT ); Wed, 14 Oct 2020 10:04:43 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 69E0EC061755 for ; Wed, 14 Oct 2020 07:04:43 -0700 (PDT) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kShOI-0001Ik-Lb; Wed, 14 Oct 2020 16:04:30 +0200 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1kShOH-0004SM-4F; Wed, 14 Oct 2020 16:04:29 +0200 Date: Wed, 14 Oct 2020 16:04:29 +0200 From: Sascha Hauer To: Rob Herring Cc: linux-edac@vger.kernel.org, Borislav Petkov , Mauro Carvalho Chehab , Tony Luck , James Morse , Robert Richter , York Sun , kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Subject: Re: [PATCH v2 0/3] Add L1 and L2 error detection for A53 and A57 Message-ID: <20201014140429.GE13710@pengutronix.de> References: <20201013125033.4749-1-s.hauer@pengutronix.de> <20201014132511.GA1517487@bogus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201014132511.GA1517487@bogus> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 15:54:31 up 237 days, 21:25, 150 users, load average: 0.21, 0.34, 0.32 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-edac@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org On Wed, Oct 14, 2020 at 08:25:11AM -0500, Rob Herring wrote: > On Tue, Oct 13, 2020 at 02:50:30PM +0200, Sascha Hauer wrote: > > This driver is based on an earlier version from York Sun which can > > be found here: https://lkml.org/lkml/2018/3/14/1203. > > > > At that time the conclusion was that this driver is not suitable for > > mainline as it used IMPLEMENTATION DEFINED CPU registers and also > > NXP specific SMC calls. All this was used for the error injection only, > > for error reporting it is not needed. > > Have you looked at Amazon's version: > http://lore.kernel.org/r/20200510151310.17372-2-hhhawa@amazon.com No, I was not aware of that driver. It's basically the same driver, but limited to a single SoC. Looks like at least some things are better in that driver, read_sysreg_s(ARM_CA57_L2MERRSR_EL1) reads better than my open coded variant. > > Which is an A57 EDAC driver. Looks like it never got upstream though, > but it's not clear why. > > You'll note that it doesn't have a virtual DT node either. Testing the SoC type in an initcall looks odd to me. Wouldn't a dedicated node be preferred? Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1CDAC433E7 for ; Wed, 14 Oct 2020 14:06:11 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5FB5122201 for ; Wed, 14 Oct 2020 14:06:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="S+HYgR86" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5FB5122201 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=n8nTeQCUpCNDjcfhSgeMlhIHP+tmbLp1+HsXj8ITh6E=; b=S+HYgR861TXUbIXlEDs+A0DSq nHOIBV63+/lyHk6UgTAcc49r7AZhOGGO7G3coATSpbicnY9mmqYaqT0XFNPXwuaAV9RX7vHBEuoWX 60JrxEMwDyxSmzCNK3kpIm8G+8Y5wRUZuoyJfFIdkYpncIWr7E1W3XXETueMhfpG45sDVJ1btT++M M/E//7wQunq2uIFmxvQBIFdYSrm4qhWQggF7hbhIN22s5Ap+8pwo64yUl4ZcGx8aynbqa4WfUzbPe fjTttEKzwlpXTASWTMz+clklajhLSxxbhMavPvzCXgI1rs9/vo4AvlAaPQpdipKDR6wDq95nHCToa 8Mrf6U66A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kShOY-0001V6-Rl; Wed, 14 Oct 2020 14:04:46 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kShOX-0001UQ-6x for linux-arm-kernel@lists.infradead.org; Wed, 14 Oct 2020 14:04:45 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kShOI-0001Ik-Lb; Wed, 14 Oct 2020 16:04:30 +0200 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1kShOH-0004SM-4F; Wed, 14 Oct 2020 16:04:29 +0200 Date: Wed, 14 Oct 2020 16:04:29 +0200 From: Sascha Hauer To: Rob Herring Subject: Re: [PATCH v2 0/3] Add L1 and L2 error detection for A53 and A57 Message-ID: <20201014140429.GE13710@pengutronix.de> References: <20201013125033.4749-1-s.hauer@pengutronix.de> <20201014132511.GA1517487@bogus> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201014132511.GA1517487@bogus> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 15:54:31 up 237 days, 21:25, 150 users, load average: 0.21, 0.34, 0.32 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201014_100445_257255_1F344440 X-CRM114-Status: GOOD ( 22.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Tony Luck , Robert Richter , James Morse , kernel@pengutronix.de, Borislav Petkov , York Sun , Mauro Carvalho Chehab , linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 14, 2020 at 08:25:11AM -0500, Rob Herring wrote: > On Tue, Oct 13, 2020 at 02:50:30PM +0200, Sascha Hauer wrote: > > This driver is based on an earlier version from York Sun which can > > be found here: https://lkml.org/lkml/2018/3/14/1203. > > > > At that time the conclusion was that this driver is not suitable for > > mainline as it used IMPLEMENTATION DEFINED CPU registers and also > > NXP specific SMC calls. All this was used for the error injection only, > > for error reporting it is not needed. > > Have you looked at Amazon's version: > http://lore.kernel.org/r/20200510151310.17372-2-hhhawa@amazon.com No, I was not aware of that driver. It's basically the same driver, but limited to a single SoC. Looks like at least some things are better in that driver, read_sysreg_s(ARM_CA57_L2MERRSR_EL1) reads better than my open coded variant. > > Which is an A57 EDAC driver. Looks like it never got upstream though, > but it's not clear why. > > You'll note that it doesn't have a virtual DT node either. Testing the SoC type in an initcall looks odd to me. Wouldn't a dedicated node be preferred? Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel