From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD8C4C433E7 for ; Wed, 14 Oct 2020 15:18:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 621082222A for ; Wed, 14 Oct 2020 15:18:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="Mkhg1oud"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="J4cIGbxk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728756AbgJNPSs (ORCPT ); Wed, 14 Oct 2020 11:18:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39094 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726596AbgJNPSs (ORCPT ); Wed, 14 Oct 2020 11:18:48 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8475CC061755; Wed, 14 Oct 2020 08:18:48 -0700 (PDT) Message-Id: <20201014145215.518912759@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1602688726; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Xqc0nGkuw0k9CjZpwvy2mNqALgS9zNAoil65HHXmBWw=; b=Mkhg1oudooc1D7cLXeBlzAj7hV9tOJlOoUSWKfGCxcNRp6Akbl+i/CyTWi32vKAy7lg0HD MpTNLo8j0c6EvQX5dPujKOlzMfsWpRC/IAGFbyB7J30kUlouGRQC6UxMvviMD1Xi9LI5Gc /tUx+/iW5BkmL6l1c9DqG8PEMBYNYtnNrrLEc6+GyalxeR0rNtSyhrbWYjwHcPC/8G1wnD CipGvLyocVhb8dITN9e/hA/hw4WxMuO9L+LWd7F5MTfY497KVJQTe6u+JI+03auxA5jaGZ rWjukNONzdglu4DG3L22C67B3madfApoVOnOStsZF9GnCVFuDKsguAAGIFMFYw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1602688726; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Xqc0nGkuw0k9CjZpwvy2mNqALgS9zNAoil65HHXmBWw=; b=J4cIGbxkYeb16Mx6vnpQGhkkmyjGQDefyDOdSDcFR6lkamlOV2UI4C4rPB+qkrPUWny9bY +XT22bHmagnyoqAQ== Date: Wed, 14 Oct 2020 16:52:15 +0200 From: Thomas Gleixner To: LKML Cc: Peter Zijlstra , Thomas Winischhofer , Greg Kroah-Hartman , linux-usb@vger.kernel.org, "Ahmed S. Darwish" , Sebastian Andrzej Siewior , Johan Hovold , Mathias Nyman , Valentina Manea , Shuah Khan , Alan Stern , linux-omap@vger.kernel.org, Kukjin Kim , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Felipe Balbi , Duncan Sands Subject: [patch 00/12] UBS: Cleanup in_interupt/in_irq/in_atomic() usage MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Rm9sa3MsCgppbiB0aGUgZGlzY3Vzc2lvbiBhYm91dCBwcmVlbXB0IGNvdW50IGNvbnNpc3RlbmN5 IGFjY3Jvc3Mga2VybmVsIGNvbmZpZ3VyYXRpb25zOgoKICBodHRwczovL2xvcmUua2VybmVsLm9y Zy9yLzIwMjAwOTE0MjA0MjA5LjI1NjI2NjA5M0BsaW51dHJvbml4LmRlLwoKTGludXMgY2xlYXJs eSByZXF1ZXN0ZWQgdGhhdCBjb2RlIGluIGRyaXZlcnMgYW5kIGxpYnJhcmllcyB3aGljaCBjaGFu Z2VzCmJlaGF2aW91ciBiYXNlZCBvbiBleGVjdXRpb24gY29udGV4dCBzaG91bGQgZWl0aGVyIGJl IHNwbGl0IHVwIHNvIHRoYXQKZS5nLiB0YXNrIGNvbnRleHQgaW52b2NhdGlvbnMgYW5kIEJIIGlu dm9jYXRpb25zIGhhdmUgZGlmZmVyZW50IGludGVyZmFjZXMKb3IgaWYgdGhhdCdzIG5vdCBwb3Nz aWJsZSB0aGUgY29udGV4dCBpbmZvcm1hdGlvbiBoYXMgdG8gYmUgcHJvdmlkZWQgYnkgdGhlCmNh bGxlciB3aGljaCBrbm93cyBpbiB3aGljaCBjb250ZXh0IGl0IGlzIGV4ZWN1dGluZy4KClRoaXMg aW5jbHVkZXMgY29uZGl0aW9uYWwgbG9ja2luZywgYWxsb2NhdGlvbiBtb2RlIChHRlBfKikgZGVj aXNpb25zIGFuZAphdm9pZGFuY2Ugb2YgY29kZSBwYXRocyB3aGljaCBtaWdodCBzbGVlcC4KCklu IHRoZSBsb25nIHJ1biwgdXNhZ2Ugb2YgJ3ByZWVtcHRpYmxlLCBpbl8qaXJxIGV0Yy4nIHNob3Vs ZCBiZSBiYW5uZWQgZnJvbQpkcml2ZXIgY29kZSBjb21wbGV0ZWx5LgoKVGhlIHVzYWdlIG9mIHN1 Y2ggY29uc3RydWN0cyBpbiBVU0IgaXMgcmF0aGVyIGxpbWl0ZWQuIE1vc3Qgb2YgaXQgaXMgaW4K ZGVidWcgY29kZSBhbmQgKG1pc2xlYWRpbmcpIGNvbW1lbnRzLiBCdXQgb2YgY291cnNlIHRoZXJl IGFyZSBhbHNvIGEgZmV3CmZldyBidWdzIGluY2x1ZGluZyBvbmUgdW5maXhhYmxlLgoKV2l0aCB0 aGUgZm9sbG93aW5nIHNlcmllcyBhcHBsaWVkLCBVU0IgaXMgY2xlYW4uCgpUaGFua3MsCgoJdGds eAotLS0KIGF0bS91c2JhdG0uYyAgICAgICAgICAgICB8ICAgIDIgCiBjb3JlL2J1ZmZlci5jICAg ICAgICAgICAgfCAgICA2ICstCiBjb3JlL2hjZC1wY2kuYyAgICAgICAgICAgfCAgICA2ICstCiBj b3JlL2hjZC5jICAgICAgICAgICAgICAgfCAgIDIxICsrKystLS0tCiBjb3JlL2h1Yi5jICAgICAg ICAgICAgICAgfCAgICAzIC0KIGNvcmUvbWVzc2FnZS5jICAgICAgICAgICB8ICAgMzUgKysrKysr KysrLS0tLS0KIGNvcmUvdXNiLmMgICAgICAgICAgICAgICB8ICAgIDQgLQogZ2FkZ2V0L3VkYy9j b3JlLmMgICAgICAgIHwgICAgMiAKIGdhZGdldC91ZGMvZHVtbXlfaGNkLmMgICB8ICAgIDUgKy0K IGdhZGdldC91ZGMvcHhhMjd4X3VkYy5jICB8ICAgMTkgKysrKy0tLQogaG9zdC9laGNpLWZzbC5j ICAgICAgICAgIHwgICAgOSArLS0KIGhvc3QvZWhjaS1wbWNtc3AuYyAgICAgICB8ICAgMTUgKysr LS0tCiBob3N0L2lzcDEzNjIuaCAgICAgICAgICAgfCAgICA1ICstCiBob3N0L29oY2ktYXQ5MS5j ICAgICAgICAgfCAgIDExICsrKy0KIGhvc3Qvb2hjaS1vbWFwLmMgICAgICAgICB8ICAgIDcgKy0K IGhvc3Qvb2hjaS1weGEyN3guYyAgICAgICB8ICAgMTEgKystLQogaG9zdC9vaGNpLXMzYzI0MTAu YyAgICAgIHwgICAxMiArKy0tLQogaG9zdC94aGNpLW1lbS5jICAgICAgICAgIHwgICAgMiAKIGhv c3QveGhjaS5jICAgICAgICAgICAgICB8ICAgIDYgLS0KIG1pc2Mvc2lzdXNidmdhL0tjb25maWcg ICB8ICAgIDIgCiBzZXJpYWwvZGlnaV9hY2NlbGVwb3J0LmMgfCAgICA3ICstCiBzZXJpYWwva2V5 c3Bhbl9wZGEuYyAgICAgfCAgMTEyICsrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tCiB1c2JpcC91c2JpcF9jb21tb24uYyAgICAgfCAgICA1IC0tCiAyMyBmaWxl cyBjaGFuZ2VkLCAxNTYgaW5zZXJ0aW9ucygrKSwgMTUxIGRlbGV0aW9ucygtKQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20919C43467 for ; Wed, 14 Oct 2020 15:20:25 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A079C21582 for ; Wed, 14 Oct 2020 15:20:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="xUNK0yB0"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="Mkhg1oud"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="J4cIGbxk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A079C21582 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Subject:To:From:Date:Message-Id: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=2lD9l3Ztoj7wNfAdLZu7CNyyJM+0JhMj+16jSjqZcis=; b=xUNK0yB0F0kOn4u/WHe5eJJSD5 bHc7fXzqpAqiuEtyGKJ4lO4JAmgn6nepsy71hCpbxO+NWXIxorpNdP8Xcwb6qwA5ccciLmXQNTo5s WHb0m8ESUFstaxC2OajTehXcKY7N54WDPoa6QtRTqibqv7UcFh6ZSJ+JQ7+yuMgKzcRE+hIQH4eNE Grnr2k5i0+pcPadP1CLthKbP6QH3hHeNT7O5Rz2EtrdVO86dtP2f7RaKfZ7MrAhar//Qt8BW4JovP dWJ4oLfZrI7keuY/THa3HuFLBfFQMa7H52c1Jr2fpqr6PQkD/oKXzV70+HyPHCMoGZ8B0/DQzZwQJ hPWRM+bg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kSiYH-0004wx-9F; Wed, 14 Oct 2020 15:18:53 +0000 Received: from galois.linutronix.de ([193.142.43.55]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kSiYC-0004vC-O5 for linux-arm-kernel@lists.infradead.org; Wed, 14 Oct 2020 15:18:50 +0000 Message-Id: <20201014145215.518912759@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1602688726; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Xqc0nGkuw0k9CjZpwvy2mNqALgS9zNAoil65HHXmBWw=; b=Mkhg1oudooc1D7cLXeBlzAj7hV9tOJlOoUSWKfGCxcNRp6Akbl+i/CyTWi32vKAy7lg0HD MpTNLo8j0c6EvQX5dPujKOlzMfsWpRC/IAGFbyB7J30kUlouGRQC6UxMvviMD1Xi9LI5Gc /tUx+/iW5BkmL6l1c9DqG8PEMBYNYtnNrrLEc6+GyalxeR0rNtSyhrbWYjwHcPC/8G1wnD CipGvLyocVhb8dITN9e/hA/hw4WxMuO9L+LWd7F5MTfY497KVJQTe6u+JI+03auxA5jaGZ rWjukNONzdglu4DG3L22C67B3madfApoVOnOStsZF9GnCVFuDKsguAAGIFMFYw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1602688726; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Xqc0nGkuw0k9CjZpwvy2mNqALgS9zNAoil65HHXmBWw=; b=J4cIGbxkYeb16Mx6vnpQGhkkmyjGQDefyDOdSDcFR6lkamlOV2UI4C4rPB+qkrPUWny9bY +XT22bHmagnyoqAQ== Date: Wed, 14 Oct 2020 16:52:15 +0200 From: Thomas Gleixner To: LKML Subject: [patch 00/12] UBS: Cleanup in_interupt/in_irq/in_atomic() usage MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201014_111848_901837_8D4C51BA X-CRM114-Status: GOOD ( 10.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Felipe Balbi , linux-usb@vger.kernel.org, Mathias Nyman , Peter Zijlstra , Greg Kroah-Hartman , Sebastian Andrzej Siewior , Thomas Winischhofer , Johan Hovold , Krzysztof Kozlowski , Valentina Manea , linux-samsung-soc@vger.kernel.org, Kukjin Kim , Alan Stern , Duncan Sands , "Ahmed S. Darwish" , linux-omap@vger.kernel.org, Shuah Khan , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Folks, in the discussion about preempt count consistency accross kernel configurations: https://lore.kernel.org/r/20200914204209.256266093@linutronix.de/ Linus clearly requested that code in drivers and libraries which changes behaviour based on execution context should either be split up so that e.g. task context invocations and BH invocations have different interfaces or if that's not possible the context information has to be provided by the caller which knows in which context it is executing. This includes conditional locking, allocation mode (GFP_*) decisions and avoidance of code paths which might sleep. In the long run, usage of 'preemptible, in_*irq etc.' should be banned from driver code completely. The usage of such constructs in USB is rather limited. Most of it is in debug code and (misleading) comments. But of course there are also a few few bugs including one unfixable. With the following series applied, USB is clean. Thanks, tglx --- atm/usbatm.c | 2 core/buffer.c | 6 +- core/hcd-pci.c | 6 +- core/hcd.c | 21 ++++---- core/hub.c | 3 - core/message.c | 35 +++++++++----- core/usb.c | 4 - gadget/udc/core.c | 2 gadget/udc/dummy_hcd.c | 5 +- gadget/udc/pxa27x_udc.c | 19 ++++--- host/ehci-fsl.c | 9 +-- host/ehci-pmcmsp.c | 15 +++--- host/isp1362.h | 5 +- host/ohci-at91.c | 11 +++- host/ohci-omap.c | 7 +- host/ohci-pxa27x.c | 11 ++-- host/ohci-s3c2410.c | 12 ++--- host/xhci-mem.c | 2 host/xhci.c | 6 -- misc/sisusbvga/Kconfig | 2 serial/digi_acceleport.c | 7 +- serial/keyspan_pda.c | 112 ++++++++++++++++++++--------------------------- usbip/usbip_common.c | 5 -- 23 files changed, 156 insertions(+), 151 deletions(-) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel