All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>,
	linux-mtd@lists.infradead.org,
	Sascha Hauer <kernel@pengutronix.de>,
	Lucas Stach <l.stach@pengutronix.de>
Subject: Re: imx27: Unsupported ECC algorithm
Date: Wed, 14 Oct 2020 15:26:59 +0200	[thread overview]
Message-ID: <20201014152659.6ef6a2fc@xps13> (raw)
In-Reply-To: <CAOMZO5Cq6v0OvpLSYwqqpHQFDjviM3mwozHcH35qoOTFvdnJ-w@mail.gmail.com>

Hi Fabio, Sascha, Lucas,

Fabio Estevam <festevam@gmail.com> wrote on Wed, 14 Oct 2020 09:23:06
-0300:

> Hi Lucas,
> 
> On Tue, Oct 13, 2020 at 2:14 PM Lucas Stach <l.stach@pengutronix.de> wrote:
> 
> > Just a heads up: our lab was broken for some time due to a local issue.
> > It's now back to working and the backlog of jobs is being executed on
> > the boards right now, so results should show up in the near furture.  
> 
> Thanks. kernelci results are showing up again.
> 
> Hi Miquel,
> 
> The ECC issues are still present on imx27-phytec-phycard-s-rdk:
> https://storage.kernelci.org/next/master/next-20201013/arm/imx_v4_v5_defconfig/gcc-8/lab-pengutronix/baseline-imx27-phytec-phycard-s-rdk.html
> 
> BTW, ECC errors are also reported on a Freescale Layerscape 2088A RDB Board:
> https://www.spinics.net/lists/iommu/msg49772.html
> 

I supposed the failing division is this one:

        /*
         * Set the number of read / write steps for one page depending on ECC
         * mode.
         */
        ecc->steps = mtd->writesize / ecc->size;
        if (ecc->steps * ecc->size != mtd->writesize) {
                WARN(1, "Invalid ECC parameters\n");
                ret = -EINVAL;
                goto err_nand_manuf_cleanup;
        }

Which produces the warning right after. This would mean that

	ecc->size == 0

But this entry is set before calling nand_scan() in mxcnd_probe() to
512, and that does not make sense.

I guess we should be able to reproduce this error with any board using
the mxc NAND driver with hardware correction (now also called "on
host"). Do you have such a board available to at least verify that the
beginning of my logic is right?

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2020-10-14 13:28 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-16 13:49 imx27: Unsupported ECC algorithm Fabio Estevam
2020-09-17 16:13 ` Miquel Raynal
2020-09-17 16:45   ` Miquel Raynal
2020-09-17 17:12     ` Fabio Estevam
2020-09-21  9:40 ` Sascha Hauer
2020-09-28 15:20   ` Miquel Raynal
2020-09-29 11:39     ` Fabio Estevam
2020-09-29 16:31       ` Fabio Estevam
2020-09-29 17:46         ` Miquel Raynal
2020-09-30 14:58         ` Miquel Raynal
2020-10-01 21:39           ` Fabio Estevam
2020-10-13 17:14             ` Lucas Stach
2020-10-13 17:36               ` Miquel Raynal
2020-10-14 12:23               ` Fabio Estevam
2020-10-14 13:26                 ` Miquel Raynal [this message]
2020-10-15 19:24                   ` Fabio Estevam
2020-10-16  3:04                   ` Han Xu
2020-10-16  6:39                   ` Sascha Hauer
2020-10-16  7:53                     ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201014152659.6ef6a2fc@xps13 \
    --to=miquel.raynal@bootlin.com \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=l.stach@pengutronix.de \
    --cc=linux-mtd@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.