From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC57EC433DF for ; Wed, 14 Oct 2020 17:40:32 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 35E64221EB for ; Wed, 14 Oct 2020 17:40:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Xg/lOlxQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 35E64221EB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6mHwwFiDIcmHo2mSfXAG4Yyv3EvgQ/yTrXaPcd7d+nI=; b=Xg/lOlxQktZDFth2e0Rz3YGMi nnxKEllMmQOnJLEfvFbdGdpn6AsjhU+IkGAJc82mmsuIxNSiUL4LiLOMbugxYk/MYClgSNkUFX6yv 7Rrlri1VLpVI0MhENnu35rTAdR6KA7VWPpFW3KeRqjG+YoRMAfHwiNVpy0qKQxCcIajY3LoCAT2hF J/avMEzh2yB9fdwX7Tkt6PnUx2oiePIR1utHrM9DZBZybFEvCioe5lcvI84EjhU8C4csB2L4TjLLa bZwABDi4nEf+VL4TUo83aPGNLDvUFYeK5//4mpM3j7lNwOEoyE8B9bj+QVEw3HCcULxJS8SzfPEax PgmiSgKTQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kSkk6-0000DV-Ub; Wed, 14 Oct 2020 17:39:15 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kSkk3-0000Ca-PK for linux-arm-kernel@lists.infradead.org; Wed, 14 Oct 2020 17:39:12 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 32359D6E; Wed, 14 Oct 2020 10:39:10 -0700 (PDT) Received: from bogus (unknown [10.57.12.254]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D234B3F71F; Wed, 14 Oct 2020 10:39:08 -0700 (PDT) Date: Wed, 14 Oct 2020 18:39:06 +0100 From: Sudeep Holla To: Florian Fainelli Subject: Re: [PATCH] firmware: arm_scmi: Fix duplicate workqueue name Message-ID: <20201014173906.aytbl4bjbwjwa6wr@bogus> References: <20201014021737.287340-1-f.fainelli@gmail.com> <20201014091806.GB20315@bogus> <20201014130524.cj42wknvzdpgsbsr@bogus> <20201014134819.GA24061@e120937-lin> <20201014160120.4x2l7hozf376gk3l@bogus> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20171215 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201014_133911_903577_976AEED6 X-CRM114-Status: GOOD ( 19.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, Jonathan Cameron , linux-kernel@vger.kernel.org, Cristian Marussi , Sudeep Holla Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCBPY3QgMTQsIDIwMjAgYXQgMTA6MTM6MDRBTSAtMDcwMCwgRmxvcmlhbiBGYWluZWxs aSB3cm90ZToKPiBPbiAxMC8xNC8yMCA5OjE4IEFNLCBTdWRlZXAgSG9sbGEgd3JvdGU6Cj4gPiBP biBXZWQsIE9jdCAxNCwgMjAyMCBhdCAwMjo0ODoxOVBNICswMTAwLCBDcmlzdGlhbiBNYXJ1c3Np IHdyb3RlOgo+ID4gCj4gPiBbLi4uXQo+ID4gCj4gPj4+Cj4gPj4+IEkgaGF2ZSBwdXNoZWQgYSB2 ZXJzaW9uIHdpdGggYWJvdmUgY2hhbmdlIFsxXSwgcGxlYXNlIGNoZWNrIGlmIHlvdSBhcmUKPiA+ Pj4gaGFwcHkgd2l0aCB0aGF0ID8KPiA+Pj4KPiA+Pj4gWzFdIGh0dHBzOi8vZ2l0Lmtlcm5lbC5v cmcvc3VkZWVwLmhvbGxhL2xpbnV4L2MvYjJjZDE1NTQ5Ygo+ID4+Cj4gPj4gSSBhZ3JlZSB3aXRo IHRoZSBuZWVkIHRvIHJldGFpbiBfbm90aWZ5IG5hbWUsIGJ1dCBJJ20gbm90IHNvIHN1cmUgYWJv dXQKPiA+PiB0aGUgYWJvdmUgcGF0Y2guLi53aGljaCBpczoKPiA+Pgo+ID4gCj4gPiBJIGFncmVl LCBJIHRob3VnaHQgYWJvdXQgaXQgYW5kIGp1c3QgY29va2VkIHVwIHRoaXMgYXMgYSBxdWljayBz b2x1dGlvbi4KPiA+IEkgd2lsbCBtb3ZlIHRvIHRoYXQsIGV2ZW4gSSB3YXNuJ3QgaGFwcHkgd2l0 aCB0aGlzIFRCSC4KPiAKPiBUaGUgcmVhc29uIHdoeSBJIHdlbnQgd2l0aCBqdXN0IGRldl9uYW1l KCkgd2FzIHN1Y2ggdGhhdCB0aGUgd29ya3F1ZXVlCj4gbmFtZSBhbmQgdGhlIGRldmljZSBub2Rl cyB1bmRlciAvc3lzIHdvdWxkIHN0cmljdGx5IG1hdGNoLCB3aGljaCBoZWxwcwo+IGFzIGFuIHVz ZXIsIGFuZCBhbHNvIGl0IGF2b2lkZWQgdGhlIHRlbXBvcmFyeSBidWZmZXIgYW5kIGl0cyBzaXpl Cj4gbGltaXRhdGlvbnMuCgpBZ3JlZWQuIEkganVzdCBzaG93ZWQgdGhhdCBhcyBleGFtcGxlIGFu ZCB3YXMgaG9waW5nIHRvIHVzZSBzb21lIG5pY2UKa3N0ciogQVBJcyB0byBhY2hpZXZlIHdoYXQg SSB3YW50ZWQgYnV0IHNvb24gcmVhbGlzZWQgdGhlcmUgZXhpc3RzIG5vbmUuClNvIGFzIHJlcGxp ZWQgZWFybGllciwgSSB3aWxsIHRha2UgdGhpcyBjaGFuZ2UgYXMgaXQgZm9yIG5vdy4gTGV0IHVz CmFkZHJlc3MgdGhpcyBpbiBmdXR1cmUgaWYgaXQgYmVjb21lcyBhbiBpc3N1ZS4KClRoYW5rcyBm b3IgcXVpY2sgdGVzdCwgd2Ugbm93IGtub3cgd2hvbSB0byBib3RoZXIgaWYgd2UgbmVlZCBtb3Jl IHRlc3RpbmcK8J+YiSBhcyBvdXQgaW50ZXJuYWwgcGxhdGZvcm1zIGFyZSBub3QgdGhhdCBncmVh dCB0byBjb3ZlciBhbGwgdGhlIGFzcGVjdHMKd2UgYWRkIGluIHRoZSBzcGVjIGFuZCBldmVuIGlu IHRoZSBrZXJuZWwuCgotLSAKUmVnYXJkcywKU3VkZWVwCgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdAps aW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVh ZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D81CFC433E7 for ; Wed, 14 Oct 2020 17:39:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8636E221EB for ; Wed, 14 Oct 2020 17:39:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731707AbgJNRjL (ORCPT ); Wed, 14 Oct 2020 13:39:11 -0400 Received: from foss.arm.com ([217.140.110.172]:54734 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727924AbgJNRjK (ORCPT ); Wed, 14 Oct 2020 13:39:10 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 32359D6E; Wed, 14 Oct 2020 10:39:10 -0700 (PDT) Received: from bogus (unknown [10.57.12.254]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D234B3F71F; Wed, 14 Oct 2020 10:39:08 -0700 (PDT) Date: Wed, 14 Oct 2020 18:39:06 +0100 From: Sudeep Holla To: Florian Fainelli Cc: Cristian Marussi , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sudeep Holla , Jonathan Cameron Subject: Re: [PATCH] firmware: arm_scmi: Fix duplicate workqueue name Message-ID: <20201014173906.aytbl4bjbwjwa6wr@bogus> References: <20201014021737.287340-1-f.fainelli@gmail.com> <20201014091806.GB20315@bogus> <20201014130524.cj42wknvzdpgsbsr@bogus> <20201014134819.GA24061@e120937-lin> <20201014160120.4x2l7hozf376gk3l@bogus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20171215 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 14, 2020 at 10:13:04AM -0700, Florian Fainelli wrote: > On 10/14/20 9:18 AM, Sudeep Holla wrote: > > On Wed, Oct 14, 2020 at 02:48:19PM +0100, Cristian Marussi wrote: > > > > [...] > > > >>> > >>> I have pushed a version with above change [1], please check if you are > >>> happy with that ? > >>> > >>> [1] https://git.kernel.org/sudeep.holla/linux/c/b2cd15549b > >> > >> I agree with the need to retain _notify name, but I'm not so sure about > >> the above patch...which is: > >> > > > > I agree, I thought about it and just cooked up this as a quick solution. > > I will move to that, even I wasn't happy with this TBH. > > The reason why I went with just dev_name() was such that the workqueue > name and the device nodes under /sys would strictly match, which helps > as an user, and also it avoided the temporary buffer and its size > limitations. Agreed. I just showed that as example and was hoping to use some nice kstr* APIs to achieve what I wanted but soon realised there exists none. So as replied earlier, I will take this change as it for now. Let us address this in future if it becomes an issue. Thanks for quick test, we now know whom to bother if we need more testing 😉 as out internal platforms are not that great to cover all the aspects we add in the spec and even in the kernel. -- Regards, Sudeep