From: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
To: Adrian Hunter <adrian.hunter@intel.com>,
Ulf Hansson <ulf.hansson@linaro.org>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>
Subject: [PATCH] mmc: sdhci: Use Auto CMD Auto Select only when v4_mode is true
Date: Wed, 14 Oct 2020 18:32:30 +0800 [thread overview]
Message-ID: <20201014183212.475a789d@xhacker.debian> (raw)
In-Reply-To: <87a39115-5843-a6a3-7564-e36ae1f16903@intel.com>
Auto CMD Auto Select can only be used when v4_mode is enabled.
Fixes: 427b6514d095 ("mmc: sdhci: Add Auto CMD Auto Select support")
Signed-off-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
---
drivers/mmc/host/sdhci.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index 592a55a34b58..5e0ec5df4074 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -1386,7 +1386,8 @@ static inline void sdhci_auto_cmd_select(struct sdhci_host *host,
* Select' is recommended rather than use of 'Auto CMD12
* Enable' or 'Auto CMD23 Enable'.
*/
- if (host->version >= SDHCI_SPEC_410 && (use_cmd12 || use_cmd23)) {
+ if (host->version >= SDHCI_SPEC_410 && host->v4_mode &&
+ (use_cmd12 || use_cmd23)) {
*mode |= SDHCI_TRNS_AUTO_SEL;
ctrl2 = sdhci_readw(host, SDHCI_HOST_CONTROL2);
--
2.28.0
next prev parent reply other threads:[~2020-10-14 10:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-13 11:08 eMMC performance regression caused by 427b6514d0953bf Jisheng Zhang
2020-10-13 12:32 ` Ulf Hansson
2020-10-13 13:23 ` Adrian Hunter
2020-10-14 10:32 ` Jisheng Zhang [this message]
2020-10-14 19:44 ` [PATCH] mmc: sdhci: Use Auto CMD Auto Select only when v4_mode is true Adrian Hunter
2020-10-15 2:12 ` Jisheng Zhang
2020-10-15 2:38 ` Jisheng Zhang
2020-10-15 5:57 ` Adrian Hunter
2020-10-15 6:24 ` Jisheng Zhang
2020-10-15 8:50 ` Adrian Hunter
2020-10-14 10:42 ` eMMC performance regression caused by 427b6514d0953bf Jisheng Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201014183212.475a789d@xhacker.debian \
--to=jisheng.zhang@synaptics.com \
--cc=adrian.hunter@intel.com \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.