Re: [PATCH v2 1/2] efi: add secure boot get helper

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4019 bytes --]

Hi Chester,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on arm64/for-next/core]
[also build test ERROR on efi/next tip/x86/core v5.9 next-20201013]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Chester-Lin/add-ima_arch-support-for-ARM64/20201014-184221
base:   https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-next/core
config: x86_64-randconfig-r003-20201014 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project e7fe3c6dfede8d5781bd000741c3dea7088307a4)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # https://github.com/0day-ci/linux/commit/d88d2474c8dbc487055a897d379568b92bb3666e
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Chester-Lin/add-ima_arch-support-for-ARM64/20201014-184221
        git checkout d88d2474c8dbc487055a897d379568b92bb3666e
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from arch/x86/mm/fault.c:19:
>> include/linux/efi.h:1090:40: error: incomplete result type 'enum efi_secureboot_mode' in function definition
   static inline enum efi_secureboot_mode efi_get_secureboot_mode(void)
                                          ^
   include/linux/efi.h:1090:20: note: forward declaration of 'enum efi_secureboot_mode'
   static inline enum efi_secureboot_mode efi_get_secureboot_mode(void)
                      ^
>> include/linux/efi.h:1092:9: error: use of undeclared identifier 'efi_secureboot_mode_disabled'
           return efi_secureboot_mode_disabled;
                  ^
   2 errors generated.
--
   In file included from arch/x86/mm/ioremap.c:18:
>> include/linux/efi.h:1090:40: error: incomplete result type 'enum efi_secureboot_mode' in function definition
   static inline enum efi_secureboot_mode efi_get_secureboot_mode(void)
                                          ^
   include/linux/efi.h:1090:20: note: forward declaration of 'enum efi_secureboot_mode'
   static inline enum efi_secureboot_mode efi_get_secureboot_mode(void)
                      ^
>> include/linux/efi.h:1092:9: error: use of undeclared identifier 'efi_secureboot_mode_disabled'
           return efi_secureboot_mode_disabled;
                  ^
   arch/x86/mm/ioremap.c:737:17: warning: no previous prototype for function 'early_memremap_pgprot_adjust' [-Wmissing-prototypes]
   pgprot_t __init early_memremap_pgprot_adjust(resource_size_t phys_addr,
                   ^
   arch/x86/mm/ioremap.c:737:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   pgprot_t __init early_memremap_pgprot_adjust(resource_size_t phys_addr,
   ^
   static 
   1 warning and 2 errors generated.

vim +1090 include/linux/efi.h

  1084	
  1085	#ifdef CONFIG_EFI
  1086	extern bool efi_runtime_disabled(void);
  1087	extern enum efi_secureboot_mode efi_get_secureboot_mode(void);
  1088	#else
  1089	static inline bool efi_runtime_disabled(void) { return true; }
> 1090	static inline enum efi_secureboot_mode efi_get_secureboot_mode(void)
  1091	{
> 1092		return efi_secureboot_mode_disabled;
  1093	}
  1094	#endif
  1095	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 32908 bytes --]