From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Zimmermann Date: Thu, 15 Oct 2020 08:05:57 +0000 Subject: Re: [PATCH] au1100fb: Remove NULL pointer check before clk_enable/disable Message-Id: <20201015100557.402f831f@linux-uq9g> List-Id: References: <20201014082137.23320-1-vulab@iscas.ac.cn> In-Reply-To: <20201014082137.23320-1-vulab@iscas.ac.cn> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Xu Wang Cc: linux-fbdev@vger.kernel.org, b.zolnierkie@samsung.com, jani.nikula@intel.com, daniel.vetter@ffwll.ch, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Hi On Wed, 14 Oct 2020 08:21:37 +0000 Xu Wang wrote: > Because clk_enable, clk_disable, clk_prepare, and clk_unprepare already > checked NULL clock parameter, so the additional checks are unnecessary, > just remove them. All clk_*() functions seem to handle NULL pointers gracefully, so you can also remove these checks from the driver's _probe and _remove functions. Best regards Thomas > > Signed-off-by: Xu Wang > --- > drivers/video/fbdev/au1100fb.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/video/fbdev/au1100fb.c b/drivers/video/fbdev/au1100fb.c > index 37a6512feda0..3659dfbb81c1 100644 > --- a/drivers/video/fbdev/au1100fb.c > +++ b/drivers/video/fbdev/au1100fb.c > @@ -560,8 +560,7 @@ int au1100fb_drv_suspend(struct platform_device *dev, > pm_message_t state) /* Blank the LCD */ > au1100fb_fb_blank(VESA_POWERDOWN, &fbdev->info); > > - if (fbdev->lcdclk) > - clk_disable(fbdev->lcdclk); > + clk_disable(fbdev->lcdclk); > > memcpy(&fbregs, fbdev->regs, sizeof(struct au1100fb_regs)); > > @@ -577,8 +576,7 @@ int au1100fb_drv_resume(struct platform_device *dev) > > memcpy(fbdev->regs, &fbregs, sizeof(struct au1100fb_regs)); > > - if (fbdev->lcdclk) > - clk_enable(fbdev->lcdclk); > + clk_enable(fbdev->lcdclk); > > /* Unblank the LCD */ > au1100fb_fb_blank(VESA_NO_BLANKING, &fbdev->info); -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B61E0C433DF for ; Thu, 15 Oct 2020 08:06:03 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E520322243 for ; Thu, 15 Oct 2020 08:06:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E520322243 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0C9886EC3E; Thu, 15 Oct 2020 08:06:02 +0000 (UTC) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5ED356EC3E for ; Thu, 15 Oct 2020 08:06:00 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 03440AF84; Thu, 15 Oct 2020 08:05:59 +0000 (UTC) Date: Thu, 15 Oct 2020 10:05:57 +0200 From: Thomas Zimmermann To: Xu Wang Subject: Re: [PATCH] au1100fb: Remove NULL pointer check before clk_enable/disable Message-ID: <20201015100557.402f831f@linux-uq9g> In-Reply-To: <20201014082137.23320-1-vulab@iscas.ac.cn> References: <20201014082137.23320-1-vulab@iscas.ac.cn> Organization: SUSE Software Solutions Germany GmbH X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, b.zolnierkie@samsung.com, jani.nikula@intel.com, daniel.vetter@ffwll.ch, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" SGkKCk9uIFdlZCwgMTQgT2N0IDIwMjAgMDg6MjE6MzcgKzAwMDAgWHUgV2FuZyA8dnVsYWJAaXNj YXMuYWMuY24+IHdyb3RlOgoKPiBCZWNhdXNlIGNsa19lbmFibGUsIGNsa19kaXNhYmxlLCBjbGtf cHJlcGFyZSwgYW5kIGNsa191bnByZXBhcmUgYWxyZWFkeQo+IGNoZWNrZWQgTlVMTCBjbG9jayBw YXJhbWV0ZXIsIHNvIHRoZSBhZGRpdGlvbmFsIGNoZWNrcyBhcmUgdW5uZWNlc3NhcnksCj4ganVz dCByZW1vdmUgdGhlbS4KCkFsbCBjbGtfKigpIGZ1bmN0aW9ucyBzZWVtIHRvIGhhbmRsZSBOVUxM IHBvaW50ZXJzIGdyYWNlZnVsbHksIHNvIHlvdSBjYW4KYWxzbyByZW1vdmUgdGhlc2UgY2hlY2tz IGZyb20gdGhlIGRyaXZlcidzIF9wcm9iZSBhbmQgX3JlbW92ZSBmdW5jdGlvbnMuCgpCZXN0IHJl Z2FyZHMKVGhvbWFzCgo+IAo+IFNpZ25lZC1vZmYtYnk6IFh1IFdhbmcgPHZ1bGFiQGlzY2FzLmFj LmNuPgo+IC0tLQo+ICBkcml2ZXJzL3ZpZGVvL2ZiZGV2L2F1MTEwMGZiLmMgfCA2ICsrLS0tLQo+ ICAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQo+IAo+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL3ZpZGVvL2ZiZGV2L2F1MTEwMGZiLmMgYi9kcml2ZXJzL3ZpZGVv L2ZiZGV2L2F1MTEwMGZiLmMKPiBpbmRleCAzN2E2NTEyZmVkYTAuLjM2NTlkZmJiODFjMSAxMDA2 NDQKPiAtLS0gYS9kcml2ZXJzL3ZpZGVvL2ZiZGV2L2F1MTEwMGZiLmMKPiArKysgYi9kcml2ZXJz L3ZpZGVvL2ZiZGV2L2F1MTEwMGZiLmMKPiBAQCAtNTYwLDggKzU2MCw3IEBAIGludCBhdTExMDBm Yl9kcnZfc3VzcGVuZChzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpkZXYsCj4gcG1fbWVzc2FnZV90 IHN0YXRlKSAvKiBCbGFuayB0aGUgTENEICovCj4gIAlhdTExMDBmYl9mYl9ibGFuayhWRVNBX1BP V0VSRE9XTiwgJmZiZGV2LT5pbmZvKTsKPiAgCj4gLQlpZiAoZmJkZXYtPmxjZGNsaykKPiAtCQlj bGtfZGlzYWJsZShmYmRldi0+bGNkY2xrKTsKPiArCWNsa19kaXNhYmxlKGZiZGV2LT5sY2RjbGsp Owo+ICAKPiAgCW1lbWNweSgmZmJyZWdzLCBmYmRldi0+cmVncywgc2l6ZW9mKHN0cnVjdCBhdTEx MDBmYl9yZWdzKSk7Cj4gIAo+IEBAIC01NzcsOCArNTc2LDcgQEAgaW50IGF1MTEwMGZiX2Rydl9y ZXN1bWUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqZGV2KQo+ICAKPiAgCW1lbWNweShmYmRldi0+ cmVncywgJmZicmVncywgc2l6ZW9mKHN0cnVjdCBhdTExMDBmYl9yZWdzKSk7Cj4gIAo+IC0JaWYg KGZiZGV2LT5sY2RjbGspCj4gLQkJY2xrX2VuYWJsZShmYmRldi0+bGNkY2xrKTsKPiArCWNsa19l bmFibGUoZmJkZXYtPmxjZGNsayk7Cj4gIAo+ICAJLyogVW5ibGFuayB0aGUgTENEICovCj4gIAlh dTExMDBmYl9mYl9ibGFuayhWRVNBX05PX0JMQU5LSU5HLCAmZmJkZXYtPmluZm8pOwoKCgotLSAK VGhvbWFzIFppbW1lcm1hbm4KR3JhcGhpY3MgRHJpdmVyIERldmVsb3BlcgpTVVNFIFNvZnR3YXJl IFNvbHV0aW9ucyBHZXJtYW55IEdtYkgKTWF4ZmVsZHN0ci4gNSwgOTA0MDkgTsO8cm5iZXJnLCBH ZXJtYW55CihIUkIgMzY4MDksIEFHIE7DvHJuYmVyZykKR2VzY2jDpGZ0c2bDvGhyZXI6IEZlbGl4 IEltZW5kw7ZyZmZlcgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2 ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C679EC433E7 for ; Thu, 15 Oct 2020 08:08:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 70BF722243 for ; Thu, 15 Oct 2020 08:08:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387696AbgJOIIL convert rfc822-to-8bit (ORCPT ); Thu, 15 Oct 2020 04:08:11 -0400 Received: from mx2.suse.de ([195.135.220.15]:41092 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728048AbgJOIGB (ORCPT ); Thu, 15 Oct 2020 04:06:01 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 03440AF84; Thu, 15 Oct 2020 08:05:59 +0000 (UTC) Date: Thu, 15 Oct 2020 10:05:57 +0200 From: Thomas Zimmermann To: Xu Wang Cc: b.zolnierkie@samsung.com, jani.nikula@intel.com, daniel.vetter@ffwll.ch, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH] au1100fb: Remove NULL pointer check before clk_enable/disable Message-ID: <20201015100557.402f831f@linux-uq9g> In-Reply-To: <20201014082137.23320-1-vulab@iscas.ac.cn> References: <20201014082137.23320-1-vulab@iscas.ac.cn> Organization: SUSE Software Solutions Germany GmbH X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi On Wed, 14 Oct 2020 08:21:37 +0000 Xu Wang wrote: > Because clk_enable, clk_disable, clk_prepare, and clk_unprepare already > checked NULL clock parameter, so the additional checks are unnecessary, > just remove them. All clk_*() functions seem to handle NULL pointers gracefully, so you can also remove these checks from the driver's _probe and _remove functions. Best regards Thomas > > Signed-off-by: Xu Wang > --- > drivers/video/fbdev/au1100fb.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/video/fbdev/au1100fb.c b/drivers/video/fbdev/au1100fb.c > index 37a6512feda0..3659dfbb81c1 100644 > --- a/drivers/video/fbdev/au1100fb.c > +++ b/drivers/video/fbdev/au1100fb.c > @@ -560,8 +560,7 @@ int au1100fb_drv_suspend(struct platform_device *dev, > pm_message_t state) /* Blank the LCD */ > au1100fb_fb_blank(VESA_POWERDOWN, &fbdev->info); > > - if (fbdev->lcdclk) > - clk_disable(fbdev->lcdclk); > + clk_disable(fbdev->lcdclk); > > memcpy(&fbregs, fbdev->regs, sizeof(struct au1100fb_regs)); > > @@ -577,8 +576,7 @@ int au1100fb_drv_resume(struct platform_device *dev) > > memcpy(fbdev->regs, &fbregs, sizeof(struct au1100fb_regs)); > > - if (fbdev->lcdclk) > - clk_enable(fbdev->lcdclk); > + clk_enable(fbdev->lcdclk); > > /* Unblank the LCD */ > au1100fb_fb_blank(VESA_NO_BLANKING, &fbdev->info); -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer