From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Zimmermann Date: Thu, 15 Oct 2020 08:08:27 +0000 Subject: Re: [PATCH] omapfb/dss: Remove redundant null check before clk_prepare_enable/clk_disable_unprepare Message-Id: <20201015100827.1115fa9b@linux-uq9g> List-Id: References: <20201014084920.25813-1-vulab@iscas.ac.cn> In-Reply-To: <20201014084920.25813-1-vulab@iscas.ac.cn> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Xu Wang Cc: linux-fbdev@vger.kernel.org, b.zolnierkie@samsung.com, yuehaibing@huawei.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, pakki001@umn.edu, linux-omap@vger.kernel.org On Wed, 14 Oct 2020 08:49:20 +0000 Xu Wang wrote: > Because clk_prepare_enable() and clk_disable_unprepare() already checked > NULL clock parameter, so the additional checks are unnecessary, just > remove them. > > Signed-off-by: Xu Wang Reviewed-by: Thomas Zimmermann > --- > drivers/video/fbdev/omap2/omapfb/dss/venc.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/video/fbdev/omap2/omapfb/dss/venc.c > b/drivers/video/fbdev/omap2/omapfb/dss/venc.c index > 0b0ad20afd63..8895fb8493d8 100644 --- > a/drivers/video/fbdev/omap2/omapfb/dss/venc.c +++ > b/drivers/video/fbdev/omap2/omapfb/dss/venc.c @@ -890,8 +890,7 @@ static > int venc_remove(struct platform_device *pdev) > static int venc_runtime_suspend(struct device *dev) > { > - if (venc.tv_dac_clk) > - clk_disable_unprepare(venc.tv_dac_clk); > + clk_disable_unprepare(venc.tv_dac_clk); > > dispc_runtime_put(); > > @@ -906,8 +905,7 @@ static int venc_runtime_resume(struct device *dev) > if (r < 0) > return r; > > - if (venc.tv_dac_clk) > - clk_prepare_enable(venc.tv_dac_clk); > + clk_prepare_enable(venc.tv_dac_clk); > > return 0; > } -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCAB7C433E7 for ; Thu, 15 Oct 2020 08:08:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 83DFD2224E for ; Thu, 15 Oct 2020 08:08:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387786AbgJOIIe convert rfc822-to-8bit (ORCPT ); Thu, 15 Oct 2020 04:08:34 -0400 Received: from mx2.suse.de ([195.135.220.15]:45078 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387766AbgJOIIa (ORCPT ); Thu, 15 Oct 2020 04:08:30 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id DED40AE85; Thu, 15 Oct 2020 08:08:28 +0000 (UTC) Date: Thu, 15 Oct 2020 10:08:27 +0200 From: Thomas Zimmermann To: Xu Wang Cc: b.zolnierkie@samsung.com, pakki001@umn.edu, yuehaibing@huawei.com, linux-fbdev@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH] omapfb/dss: Remove redundant null check before clk_prepare_enable/clk_disable_unprepare Message-ID: <20201015100827.1115fa9b@linux-uq9g> In-Reply-To: <20201014084920.25813-1-vulab@iscas.ac.cn> References: <20201014084920.25813-1-vulab@iscas.ac.cn> Organization: SUSE Software Solutions Germany GmbH X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org On Wed, 14 Oct 2020 08:49:20 +0000 Xu Wang wrote: > Because clk_prepare_enable() and clk_disable_unprepare() already checked > NULL clock parameter, so the additional checks are unnecessary, just > remove them. > > Signed-off-by: Xu Wang Reviewed-by: Thomas Zimmermann > --- > drivers/video/fbdev/omap2/omapfb/dss/venc.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/video/fbdev/omap2/omapfb/dss/venc.c > b/drivers/video/fbdev/omap2/omapfb/dss/venc.c index > 0b0ad20afd63..8895fb8493d8 100644 --- > a/drivers/video/fbdev/omap2/omapfb/dss/venc.c +++ > b/drivers/video/fbdev/omap2/omapfb/dss/venc.c @@ -890,8 +890,7 @@ static > int venc_remove(struct platform_device *pdev) > static int venc_runtime_suspend(struct device *dev) > { > - if (venc.tv_dac_clk) > - clk_disable_unprepare(venc.tv_dac_clk); > + clk_disable_unprepare(venc.tv_dac_clk); > > dispc_runtime_put(); > > @@ -906,8 +905,7 @@ static int venc_runtime_resume(struct device *dev) > if (r < 0) > return r; > > - if (venc.tv_dac_clk) > - clk_prepare_enable(venc.tv_dac_clk); > + clk_prepare_enable(venc.tv_dac_clk); > > return 0; > } -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B209C433DF for ; Thu, 15 Oct 2020 08:08:33 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A9A4422243 for ; Thu, 15 Oct 2020 08:08:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A9A4422243 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8B54F6EC3F; Thu, 15 Oct 2020 08:08:31 +0000 (UTC) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 315AF6EC3F for ; Thu, 15 Oct 2020 08:08:30 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id DED40AE85; Thu, 15 Oct 2020 08:08:28 +0000 (UTC) Date: Thu, 15 Oct 2020 10:08:27 +0200 From: Thomas Zimmermann To: Xu Wang Subject: Re: [PATCH] omapfb/dss: Remove redundant null check before clk_prepare_enable/clk_disable_unprepare Message-ID: <20201015100827.1115fa9b@linux-uq9g> In-Reply-To: <20201014084920.25813-1-vulab@iscas.ac.cn> References: <20201014084920.25813-1-vulab@iscas.ac.cn> Organization: SUSE Software Solutions Germany GmbH X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, b.zolnierkie@samsung.com, yuehaibing@huawei.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, pakki001@umn.edu, linux-omap@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gV2VkLCAxNCBPY3QgMjAyMCAwODo0OToyMCArMDAwMCBYdSBXYW5nIDx2dWxhYkBpc2Nhcy5h Yy5jbj4gd3JvdGU6Cgo+IEJlY2F1c2UgY2xrX3ByZXBhcmVfZW5hYmxlKCkgYW5kIGNsa19kaXNh YmxlX3VucHJlcGFyZSgpIGFscmVhZHkgY2hlY2tlZAo+IE5VTEwgY2xvY2sgcGFyYW1ldGVyLCBz byB0aGUgYWRkaXRpb25hbCBjaGVja3MgYXJlIHVubmVjZXNzYXJ5LCBqdXN0Cj4gcmVtb3ZlIHRo ZW0uCj4gCj4gU2lnbmVkLW9mZi1ieTogWHUgV2FuZyA8dnVsYWJAaXNjYXMuYWMuY24+CgpSZXZp ZXdlZC1ieTogVGhvbWFzIFppbW1lcm1hbm4gPHR6aW1tZXJtYW5uQHN1c2UuZGU+Cgo+IC0tLQo+ ICBkcml2ZXJzL3ZpZGVvL2ZiZGV2L29tYXAyL29tYXBmYi9kc3MvdmVuYy5jIHwgNiArKy0tLS0K PiAgMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKPiAKPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy92aWRlby9mYmRldi9vbWFwMi9vbWFwZmIvZHNzL3ZlbmMuYwo+ IGIvZHJpdmVycy92aWRlby9mYmRldi9vbWFwMi9vbWFwZmIvZHNzL3ZlbmMuYyBpbmRleAo+IDBi MGFkMjBhZmQ2My4uODg5NWZiODQ5M2Q4IDEwMDY0NCAtLS0KPiBhL2RyaXZlcnMvdmlkZW8vZmJk ZXYvb21hcDIvb21hcGZiL2Rzcy92ZW5jLmMgKysrCj4gYi9kcml2ZXJzL3ZpZGVvL2ZiZGV2L29t YXAyL29tYXBmYi9kc3MvdmVuYy5jIEBAIC04OTAsOCArODkwLDcgQEAgc3RhdGljCj4gaW50IHZl bmNfcmVtb3ZlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpIAo+ICBzdGF0aWMgaW50IHZl bmNfcnVudGltZV9zdXNwZW5kKHN0cnVjdCBkZXZpY2UgKmRldikKPiAgewo+IC0JaWYgKHZlbmMu dHZfZGFjX2NsaykKPiAtCQljbGtfZGlzYWJsZV91bnByZXBhcmUodmVuYy50dl9kYWNfY2xrKTsK PiArCWNsa19kaXNhYmxlX3VucHJlcGFyZSh2ZW5jLnR2X2RhY19jbGspOwo+ICAKPiAgCWRpc3Bj X3J1bnRpbWVfcHV0KCk7Cj4gIAo+IEBAIC05MDYsOCArOTA1LDcgQEAgc3RhdGljIGludCB2ZW5j X3J1bnRpbWVfcmVzdW1lKHN0cnVjdCBkZXZpY2UgKmRldikKPiAgCWlmIChyIDwgMCkKPiAgCQly ZXR1cm4gcjsKPiAgCj4gLQlpZiAodmVuYy50dl9kYWNfY2xrKQo+IC0JCWNsa19wcmVwYXJlX2Vu YWJsZSh2ZW5jLnR2X2RhY19jbGspOwo+ICsJY2xrX3ByZXBhcmVfZW5hYmxlKHZlbmMudHZfZGFj X2Nsayk7Cj4gIAo+ICAJcmV0dXJuIDA7Cj4gIH0KCgoKLS0gClRob21hcyBaaW1tZXJtYW5uCkdy YXBoaWNzIERyaXZlciBEZXZlbG9wZXIKU1VTRSBTb2Z0d2FyZSBTb2x1dGlvbnMgR2VybWFueSBH bWJICk1heGZlbGRzdHIuIDUsIDkwNDA5IE7DvHJuYmVyZywgR2VybWFueQooSFJCIDM2ODA5LCBB RyBOw7xybmJlcmcpCkdlc2Now6RmdHNmw7xocmVyOiBGZWxpeCBJbWVuZMO2cmZmZXIKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxp bmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==