From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Zimmermann Date: Thu, 15 Oct 2020 08:10:15 +0000 Subject: Re: [PATCH] video: fbdev: sh_mobile_lcdcfb: Remove redundant null check before clk_prepare_enable/cl Message-Id: <20201015101015.6dbd25ce@linux-uq9g> List-Id: References: <20201014085722.26069-1-vulab@iscas.ac.cn> In-Reply-To: <20201014085722.26069-1-vulab@iscas.ac.cn> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Xu Wang Cc: linux-fbdev@vger.kernel.org, arnd@arndb.de, b.zolnierkie@samsung.com, jani.nikula@intel.com, daniel.vetter@ffwll.ch, gustavoars@kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org On Wed, 14 Oct 2020 08:57:22 +0000 Xu Wang wrote: > Because clk_prepare_enable() and clk_disable_unprepare() already checked > NULL clock parameter, so the additional checks are unnecessary, just > remove them. > > Signed-off-by: Xu Wang Reviewed-by: Thomas Zimmermann > --- > drivers/video/fbdev/sh_mobile_lcdcfb.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/video/fbdev/sh_mobile_lcdcfb.c > b/drivers/video/fbdev/sh_mobile_lcdcfb.c index c1043420dbd3..c0952cc96bdb > 100644 --- a/drivers/video/fbdev/sh_mobile_lcdcfb.c > +++ b/drivers/video/fbdev/sh_mobile_lcdcfb.c > @@ -341,8 +341,7 @@ static void lcdc_wait_bit(struct sh_mobile_lcdc_priv > *priv, static void sh_mobile_lcdc_clk_on(struct sh_mobile_lcdc_priv *priv) > { > if (atomic_inc_and_test(&priv->hw_usecnt)) { > - if (priv->dot_clk) > - clk_prepare_enable(priv->dot_clk); > + clk_prepare_enable(priv->dot_clk); > pm_runtime_get_sync(priv->dev); > } > } > @@ -351,8 +350,7 @@ static void sh_mobile_lcdc_clk_off(struct > sh_mobile_lcdc_priv *priv) { > if (atomic_sub_return(1, &priv->hw_usecnt) = -1) { > pm_runtime_put(priv->dev); > - if (priv->dot_clk) > - clk_disable_unprepare(priv->dot_clk); > + clk_disable_unprepare(priv->dot_clk); > } > } > -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93165C433DF for ; Thu, 15 Oct 2020 08:10:20 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2581922243 for ; Thu, 15 Oct 2020 08:10:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2581922243 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 203856E0C1; Thu, 15 Oct 2020 08:10:19 +0000 (UTC) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2C75D6E0C1 for ; Thu, 15 Oct 2020 08:10:18 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id D227EB20A; Thu, 15 Oct 2020 08:10:16 +0000 (UTC) Date: Thu, 15 Oct 2020 10:10:15 +0200 From: Thomas Zimmermann To: Xu Wang Subject: Re: [PATCH] video: fbdev: sh_mobile_lcdcfb: Remove redundant null check before clk_prepare_enable/clk_disable_unprepare Message-ID: <20201015101015.6dbd25ce@linux-uq9g> In-Reply-To: <20201014085722.26069-1-vulab@iscas.ac.cn> References: <20201014085722.26069-1-vulab@iscas.ac.cn> Organization: SUSE Software Solutions Germany GmbH X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, arnd@arndb.de, b.zolnierkie@samsung.com, jani.nikula@intel.com, daniel.vetter@ffwll.ch, gustavoars@kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gV2VkLCAxNCBPY3QgMjAyMCAwODo1NzoyMiArMDAwMCBYdSBXYW5nIDx2dWxhYkBpc2Nhcy5h Yy5jbj4gd3JvdGU6Cgo+IEJlY2F1c2UgY2xrX3ByZXBhcmVfZW5hYmxlKCkgYW5kIGNsa19kaXNh YmxlX3VucHJlcGFyZSgpIGFscmVhZHkgY2hlY2tlZAo+IE5VTEwgY2xvY2sgcGFyYW1ldGVyLCBz byB0aGUgYWRkaXRpb25hbCBjaGVja3MgYXJlIHVubmVjZXNzYXJ5LCBqdXN0Cj4gcmVtb3ZlIHRo ZW0uCj4gCj4gU2lnbmVkLW9mZi1ieTogWHUgV2FuZyA8dnVsYWJAaXNjYXMuYWMuY24+CgpSZXZp ZXdlZC1ieTogVGhvbWFzIFppbW1lcm1hbm4gPHR6aW1tZXJtYW5uQHN1c2UuZGU+Cgo+IC0tLQo+ ICBkcml2ZXJzL3ZpZGVvL2ZiZGV2L3NoX21vYmlsZV9sY2RjZmIuYyB8IDYgKystLS0tCj4gIDEg ZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvdmlkZW8vZmJkZXYvc2hfbW9iaWxlX2xjZGNmYi5jCj4gYi9kcml2ZXJz L3ZpZGVvL2ZiZGV2L3NoX21vYmlsZV9sY2RjZmIuYyBpbmRleCBjMTA0MzQyMGRiZDMuLmMwOTUy Y2M5NmJkYgo+IDEwMDY0NCAtLS0gYS9kcml2ZXJzL3ZpZGVvL2ZiZGV2L3NoX21vYmlsZV9sY2Rj ZmIuYwo+ICsrKyBiL2RyaXZlcnMvdmlkZW8vZmJkZXYvc2hfbW9iaWxlX2xjZGNmYi5jCj4gQEAg LTM0MSw4ICszNDEsNyBAQCBzdGF0aWMgdm9pZCBsY2RjX3dhaXRfYml0KHN0cnVjdCBzaF9tb2Jp bGVfbGNkY19wcml2Cj4gKnByaXYsIHN0YXRpYyB2b2lkIHNoX21vYmlsZV9sY2RjX2Nsa19vbihz dHJ1Y3Qgc2hfbW9iaWxlX2xjZGNfcHJpdiAqcHJpdikKPiAgewo+ICAJaWYgKGF0b21pY19pbmNf YW5kX3Rlc3QoJnByaXYtPmh3X3VzZWNudCkpIHsKPiAtCQlpZiAocHJpdi0+ZG90X2NsaykKPiAt CQkJY2xrX3ByZXBhcmVfZW5hYmxlKHByaXYtPmRvdF9jbGspOwo+ICsJCWNsa19wcmVwYXJlX2Vu YWJsZShwcml2LT5kb3RfY2xrKTsKPiAgCQlwbV9ydW50aW1lX2dldF9zeW5jKHByaXYtPmRldik7 Cj4gIAl9Cj4gIH0KPiBAQCAtMzUxLDggKzM1MCw3IEBAIHN0YXRpYyB2b2lkIHNoX21vYmlsZV9s Y2RjX2Nsa19vZmYoc3RydWN0Cj4gc2hfbW9iaWxlX2xjZGNfcHJpdiAqcHJpdikgewo+ICAJaWYg KGF0b21pY19zdWJfcmV0dXJuKDEsICZwcml2LT5od191c2VjbnQpID09IC0xKSB7Cj4gIAkJcG1f cnVudGltZV9wdXQocHJpdi0+ZGV2KTsKPiAtCQlpZiAocHJpdi0+ZG90X2NsaykKPiAtCQkJY2xr X2Rpc2FibGVfdW5wcmVwYXJlKHByaXYtPmRvdF9jbGspOwo+ICsJCWNsa19kaXNhYmxlX3VucHJl cGFyZShwcml2LT5kb3RfY2xrKTsKPiAgCX0KPiAgfQo+ICAKCgoKLS0gClRob21hcyBaaW1tZXJt YW5uCkdyYXBoaWNzIERyaXZlciBEZXZlbG9wZXIKU1VTRSBTb2Z0d2FyZSBTb2x1dGlvbnMgR2Vy bWFueSBHbWJICk1heGZlbGRzdHIuIDUsIDkwNDA5IE7DvHJuYmVyZywgR2VybWFueQooSFJCIDM2 ODA5LCBBRyBOw7xybmJlcmcpCkdlc2Now6RmdHNmw7xocmVyOiBGZWxpeCBJbWVuZMO2cmZmZXIK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EF8CC433DF for ; Thu, 15 Oct 2020 08:10:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 44A732224E for ; Thu, 15 Oct 2020 08:10:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387894AbgJOIKo convert rfc822-to-8bit (ORCPT ); Thu, 15 Oct 2020 04:10:44 -0400 Received: from mx2.suse.de ([195.135.220.15]:47584 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387827AbgJOIKS (ORCPT ); Thu, 15 Oct 2020 04:10:18 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id D227EB20A; Thu, 15 Oct 2020 08:10:16 +0000 (UTC) Date: Thu, 15 Oct 2020 10:10:15 +0200 From: Thomas Zimmermann To: Xu Wang Cc: b.zolnierkie@samsung.com, gustavoars@kernel.org, arnd@arndb.de, daniel.vetter@ffwll.ch, jani.nikula@intel.com, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] video: fbdev: sh_mobile_lcdcfb: Remove redundant null check before clk_prepare_enable/clk_disable_unprepare Message-ID: <20201015101015.6dbd25ce@linux-uq9g> In-Reply-To: <20201014085722.26069-1-vulab@iscas.ac.cn> References: <20201014085722.26069-1-vulab@iscas.ac.cn> Organization: SUSE Software Solutions Germany GmbH X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 14 Oct 2020 08:57:22 +0000 Xu Wang wrote: > Because clk_prepare_enable() and clk_disable_unprepare() already checked > NULL clock parameter, so the additional checks are unnecessary, just > remove them. > > Signed-off-by: Xu Wang Reviewed-by: Thomas Zimmermann > --- > drivers/video/fbdev/sh_mobile_lcdcfb.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/video/fbdev/sh_mobile_lcdcfb.c > b/drivers/video/fbdev/sh_mobile_lcdcfb.c index c1043420dbd3..c0952cc96bdb > 100644 --- a/drivers/video/fbdev/sh_mobile_lcdcfb.c > +++ b/drivers/video/fbdev/sh_mobile_lcdcfb.c > @@ -341,8 +341,7 @@ static void lcdc_wait_bit(struct sh_mobile_lcdc_priv > *priv, static void sh_mobile_lcdc_clk_on(struct sh_mobile_lcdc_priv *priv) > { > if (atomic_inc_and_test(&priv->hw_usecnt)) { > - if (priv->dot_clk) > - clk_prepare_enable(priv->dot_clk); > + clk_prepare_enable(priv->dot_clk); > pm_runtime_get_sync(priv->dev); > } > } > @@ -351,8 +350,7 @@ static void sh_mobile_lcdc_clk_off(struct > sh_mobile_lcdc_priv *priv) { > if (atomic_sub_return(1, &priv->hw_usecnt) == -1) { > pm_runtime_put(priv->dev); > - if (priv->dot_clk) > - clk_disable_unprepare(priv->dot_clk); > + clk_disable_unprepare(priv->dot_clk); > } > } > -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer