From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D5D5C433E7 for ; Thu, 15 Oct 2020 10:30:04 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8D8082224A for ; Thu, 15 Oct 2020 10:30:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8D8082224A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 84EDC6EC4F; Thu, 15 Oct 2020 10:30:02 +0000 (UTC) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id B65C36EC4F for ; Thu, 15 Oct 2020 10:30:00 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 6C8ACAD1E; Thu, 15 Oct 2020 10:29:59 +0000 (UTC) Date: Thu, 15 Oct 2020 12:29:57 +0200 From: Thomas Zimmermann To: Tian Tao Subject: Re: [PATCH drm/hisilicon v2 2/2] drm/hisilicon: Use the same style of variable type in hibmc_drm_drv Message-ID: <20201015122957.6590adb3@linux-uq9g> In-Reply-To: <1602752417-20598-3-git-send-email-tiantao6@hisilicon.com> References: <1602752417-20598-1-git-send-email-tiantao6@hisilicon.com> <1602752417-20598-3-git-send-email-tiantao6@hisilicon.com> Organization: SUSE Software Solutions Germany GmbH X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: airlied@linux.ie, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linuxarm@huawei.com, xinliang.liu@linaro.org, kraxel@redhat.com, alexander.deucher@amd.com, tglx@linutronix.de Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" SGkKCk9uIFRodSwgMTUgT2N0IDIwMjAgMTc6MDA6MTcgKzA4MDAgVGlhbiBUYW8gPHRpYW50YW82 QGhpc2lsaWNvbi5jb20+IHdyb3RlOgoKPiBDb25zaXN0ZW50bHkgVXNlIHRoZSBzYW1lIHN0eWxl IG9mIHZhcmlhYmxlIHR5cGUgaW4gaGlibWNfZHJtX2Rydi5jIGFuZAo+IGhpYm1jX2RybV9kcnYu aC4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBUaWFuIFRhbyA8dGlhbnRhbzZAaGlzaWxpY29uLmNvbT4K PiBBY2tlZC1ieTogVGhvbWFzIFppbW1lcm1hbm4gPHR6aW1tZXJtYW5uQHN1c2UuZGU+Cj4gLS0t Cj4gIGRyaXZlcnMvZ3B1L2RybS9oaXNpbGljb24vaGlibWMvaGlibWNfZHJtX2Rydi5jIHwgMTMg KysrKysrLS0tLS0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaGlzaWxpY29uL2hpYm1jL2hpYm1jX2Ry bV9kcnYuaCB8ICA4ICsrKystLS0tCj4gIDIgZmlsZXMgY2hhbmdlZCwgMTAgaW5zZXJ0aW9ucygr KSwgMTEgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9oaXNp bGljb24vaGlibWMvaGlibWNfZHJtX2Rydi5jCj4gYi9kcml2ZXJzL2dwdS9kcm0vaGlzaWxpY29u L2hpYm1jL2hpYm1jX2RybV9kcnYuYyBpbmRleCA1NjMyYmNlLi4wYzFiNDBkCj4gMTAwNjQ0IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9oaXNpbGljb24vaGlibWMvaGlibWNfZHJtX2Rydi5jCj4gKysr IGIvZHJpdmVycy9ncHUvZHJtL2hpc2lsaWNvbi9oaWJtYy9oaWJtY19kcm1fZHJ2LmMKPiBAQCAt MTIxLDEyICsxMjEsMTEgQEAgc3RhdGljIHZvaWQgaGlibWNfa21zX2Zpbmkoc3RydWN0IGhpYm1j X2RybV9wcml2YXRlCj4gKnByaXYpIC8qCj4gICAqIEl0IGNhbiBvcGVyYXRlIGluIG9uZSBvZiB0 aHJlZSBtb2RlczogMCwgMSBvciBTbGVlcC4KPiAgICovCj4gLXZvaWQgaGlibWNfc2V0X3Bvd2Vy X21vZGUoc3RydWN0IGhpYm1jX2RybV9wcml2YXRlICpwcml2LAo+IC0JCQkgIHVuc2lnbmVkIGlu dCBwb3dlcl9tb2RlKQo+ICt2b2lkIGhpYm1jX3NldF9wb3dlcl9tb2RlKHN0cnVjdCBoaWJtY19k cm1fcHJpdmF0ZSAqcHJpdiwgdTMyIHBvd2VyX21vZGUpCj4gIHsKPiAtCXVuc2lnbmVkIGludCBj b250cm9sX3ZhbHVlID0gMDsKPiArCXUzMiBjb250cm9sX3ZhbHVlID0gMDsKPiAgCXZvaWQgX19p b21lbSAgICptbWlvID0gcHJpdi0+bW1pbzsKPiAtCXVuc2lnbmVkIGludCBpbnB1dCA9IDE7Cj4g Kwl1MzIgaW5wdXQgPSAxOwo+ICAKPiAgCWlmIChwb3dlcl9tb2RlID4gSElCTUNfUFdfTU9ERV9D VExfTU9ERV9TTEVFUCkKPiAgCQlyZXR1cm47Cj4gQEAgLTE0NCw4ICsxNDMsOCBAQCB2b2lkIGhp Ym1jX3NldF9wb3dlcl9tb2RlKHN0cnVjdCBoaWJtY19kcm1fcHJpdmF0ZQo+ICpwcml2LCAKPiAg dm9pZCBoaWJtY19zZXRfY3VycmVudF9nYXRlKHN0cnVjdCBoaWJtY19kcm1fcHJpdmF0ZSAqcHJp diwgdW5zaWduZWQgaW50Cj4gZ2F0ZSkgewo+IC0JdW5zaWduZWQgaW50IGdhdGVfcmVnOwo+IC0J dW5zaWduZWQgaW50IG1vZGU7Cj4gKwl1MzIgZ2F0ZV9yZWc7Cj4gKwl1MzIgbW9kZTsKPiAgCXZv aWQgX19pb21lbSAgICptbWlvID0gcHJpdi0+bW1pbzsKPiAgCj4gIAkvKiBHZXQgY3VycmVudCBw b3dlciBtb2RlLiAqLwo+IEBAIC0xNzAsNyArMTY5LDcgQEAgdm9pZCBoaWJtY19zZXRfY3VycmVu dF9nYXRlKHN0cnVjdCBoaWJtY19kcm1fcHJpdmF0ZQo+ICpwcml2LCB1bnNpZ25lZCBpbnQgZ2F0 ZSkgCj4gIHN0YXRpYyB2b2lkIGhpYm1jX2h3X2NvbmZpZyhzdHJ1Y3QgaGlibWNfZHJtX3ByaXZh dGUgKnByaXYpCj4gIHsKPiAtCXVuc2lnbmVkIGludCByZWc7Cj4gKwl1MzIgcmVnOwo+ICAKPiAg CS8qIE9uIGhhcmR3YXJlIHJlc2V0LCBwb3dlciBtb2RlIDAgaXMgZGVmYXVsdC4gKi8KPiAgCWhp Ym1jX3NldF9wb3dlcl9tb2RlKHByaXYsIEhJQk1DX1BXX01PREVfQ1RMX01PREVfTU9ERTApOwo+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaGlzaWxpY29uL2hpYm1jL2hpYm1jX2RybV9k cnYuaAo+IGIvZHJpdmVycy9ncHUvZHJtL2hpc2lsaWNvbi9oaWJtYy9oaWJtY19kcm1fZHJ2Lmgg aW5kZXggNmE2MzUwMi4uNWM0MDMwZAo+IDEwMDY0NCAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaGlz aWxpY29uL2hpYm1jL2hpYm1jX2RybV9kcnYuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9oaXNp bGljb24vaGlibWMvaGlibWNfZHJtX2Rydi5oCj4gQEAgLTMzLDggKzMzLDggQEAgc3RydWN0IGhp Ym1jX2RybV9wcml2YXRlIHsKPiAgCS8qIGh3ICovCj4gIAl2b2lkIF9faW9tZW0gICAqbW1pbzsK PiAgCXZvaWQgX19pb21lbSAgICpmYl9tYXA7Cj4gLQl1bnNpZ25lZCBsb25nICBmYl9iYXNlOwo+ IC0JdW5zaWduZWQgbG9uZyAgZmJfc2l6ZTsKPiArCXU2NCAgZmJfYmFzZTsKPiArCXU2NCAgZmJf c2l6ZTsKCk5vIGNvbW1lbnQgb24gd2h5IHU2NCBpcyBiZXR0ZXIgdGhhbiByZXNvdXJjZV9zaXpl X3QgPwoKQmVzdCByZWdhcmRzClRob21hcwoKPiAgCj4gIAkvKiBkcm0gKi8KPiAgCXN0cnVjdCBk cm1fZGV2aWNlICAqZGV2Owo+IEBAIC01Niw5ICs1Niw5IEBAIHN0YXRpYyBpbmxpbmUgc3RydWN0 IGhpYm1jX2RybV9wcml2YXRlCj4gKnRvX2hpYm1jX2RybV9wcml2YXRlKHN0cnVjdCBkcm1fZGV2 aWNlICogfQo+ICAKPiAgdm9pZCBoaWJtY19zZXRfcG93ZXJfbW9kZShzdHJ1Y3QgaGlibWNfZHJt X3ByaXZhdGUgKnByaXYsCj4gLQkJCSAgdW5zaWduZWQgaW50IHBvd2VyX21vZGUpOwo+ICsJCQkg IHUzMiBwb3dlcl9tb2RlKTsKPiAgdm9pZCBoaWJtY19zZXRfY3VycmVudF9nYXRlKHN0cnVjdCBo aWJtY19kcm1fcHJpdmF0ZSAqcHJpdiwKPiAtCQkJICAgIHVuc2lnbmVkIGludCBnYXRlKTsKPiAr CQkJICAgIHUzMiBnYXRlKTsKPiAgCj4gIGludCBoaWJtY19kZV9pbml0KHN0cnVjdCBoaWJtY19k cm1fcHJpdmF0ZSAqcHJpdik7Cj4gIGludCBoaWJtY192ZGFjX2luaXQoc3RydWN0IGhpYm1jX2Ry bV9wcml2YXRlICpwcml2KTsKCgoKLS0gClRob21hcyBaaW1tZXJtYW5uCkdyYXBoaWNzIERyaXZl ciBEZXZlbG9wZXIKU1VTRSBTb2Z0d2FyZSBTb2x1dGlvbnMgR2VybWFueSBHbWJICk1heGZlbGRz dHIuIDUsIDkwNDA5IE7DvHJuYmVyZywgR2VybWFueQooSFJCIDM2ODA5LCBBRyBOw7xybmJlcmcp Ckdlc2Now6RmdHNmw7xocmVyOiBGZWxpeCBJbWVuZMO2cmZmZXIKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmkt ZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE1DFC433DF for ; Thu, 15 Oct 2020 10:30:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7762D22249 for ; Thu, 15 Oct 2020 10:30:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728938AbgJOKaC convert rfc822-to-8bit (ORCPT ); Thu, 15 Oct 2020 06:30:02 -0400 Received: from mx2.suse.de ([195.135.220.15]:38702 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728292AbgJOKaB (ORCPT ); Thu, 15 Oct 2020 06:30:01 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 6C8ACAD1E; Thu, 15 Oct 2020 10:29:59 +0000 (UTC) Date: Thu, 15 Oct 2020 12:29:57 +0200 From: Thomas Zimmermann To: Tian Tao Cc: , , , , , , , , Subject: Re: [PATCH drm/hisilicon v2 2/2] drm/hisilicon: Use the same style of variable type in hibmc_drm_drv Message-ID: <20201015122957.6590adb3@linux-uq9g> In-Reply-To: <1602752417-20598-3-git-send-email-tiantao6@hisilicon.com> References: <1602752417-20598-1-git-send-email-tiantao6@hisilicon.com> <1602752417-20598-3-git-send-email-tiantao6@hisilicon.com> Organization: SUSE Software Solutions Germany GmbH X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi On Thu, 15 Oct 2020 17:00:17 +0800 Tian Tao wrote: > Consistently Use the same style of variable type in hibmc_drm_drv.c and > hibmc_drm_drv.h. > > Signed-off-by: Tian Tao > Acked-by: Thomas Zimmermann > --- > drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 13 ++++++------- > drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h | 8 ++++---- > 2 files changed, 10 insertions(+), 11 deletions(-) > > diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c > b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c index 5632bce..0c1b40d > 100644 --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c > +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c > @@ -121,12 +121,11 @@ static void hibmc_kms_fini(struct hibmc_drm_private > *priv) /* > * It can operate in one of three modes: 0, 1 or Sleep. > */ > -void hibmc_set_power_mode(struct hibmc_drm_private *priv, > - unsigned int power_mode) > +void hibmc_set_power_mode(struct hibmc_drm_private *priv, u32 power_mode) > { > - unsigned int control_value = 0; > + u32 control_value = 0; > void __iomem *mmio = priv->mmio; > - unsigned int input = 1; > + u32 input = 1; > > if (power_mode > HIBMC_PW_MODE_CTL_MODE_SLEEP) > return; > @@ -144,8 +143,8 @@ void hibmc_set_power_mode(struct hibmc_drm_private > *priv, > void hibmc_set_current_gate(struct hibmc_drm_private *priv, unsigned int > gate) { > - unsigned int gate_reg; > - unsigned int mode; > + u32 gate_reg; > + u32 mode; > void __iomem *mmio = priv->mmio; > > /* Get current power mode. */ > @@ -170,7 +169,7 @@ void hibmc_set_current_gate(struct hibmc_drm_private > *priv, unsigned int gate) > static void hibmc_hw_config(struct hibmc_drm_private *priv) > { > - unsigned int reg; > + u32 reg; > > /* On hardware reset, power mode 0 is default. */ > hibmc_set_power_mode(priv, HIBMC_PW_MODE_CTL_MODE_MODE0); > diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h > b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h index 6a63502..5c4030d > 100644 --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h > +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h > @@ -33,8 +33,8 @@ struct hibmc_drm_private { > /* hw */ > void __iomem *mmio; > void __iomem *fb_map; > - unsigned long fb_base; > - unsigned long fb_size; > + u64 fb_base; > + u64 fb_size; No comment on why u64 is better than resource_size_t ? Best regards Thomas > > /* drm */ > struct drm_device *dev; > @@ -56,9 +56,9 @@ static inline struct hibmc_drm_private > *to_hibmc_drm_private(struct drm_device * } > > void hibmc_set_power_mode(struct hibmc_drm_private *priv, > - unsigned int power_mode); > + u32 power_mode); > void hibmc_set_current_gate(struct hibmc_drm_private *priv, > - unsigned int gate); > + u32 gate); > > int hibmc_de_init(struct hibmc_drm_private *priv); > int hibmc_vdac_init(struct hibmc_drm_private *priv); -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer