From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>,
"Dipl. Ing. Sergey Brester" <serg.brester@sebres.de>,
git@vger.kernel.org
Subject: Re: [PATCH] fast-import: fix over-allocation of marks storage
Date: Fri, 16 Oct 2020 02:37:35 +0000 [thread overview]
Message-ID: <20201016023735.GD490427@camp.crustytoothpaste.net> (raw)
In-Reply-To: <20201015185853.GA1108210@coredump.intra.peff.net>
[-- Attachment #1: Type: text/plain, Size: 940 bytes --]
On 2020-10-15 at 18:58:53, Jeff King wrote:
> On Thu, Oct 15, 2020 at 11:35:28AM -0700, Junio C Hamano wrote:
> > I do not know if an issue-tracker would have helped, though. The
> > issue was discovered and discussed there the day before:
> >
> > https://lore.kernel.org/git/xmqqimg5o5fq.fsf@gitster.c.googlers.com/
>
> Doh, and I was so proud of myself for diagnosing and fixing it. ;)
Well, you did write a great commit message and patch with functional
tests.
> Looking over the thread, I don't see any problems pointed out (though
> as your diff below shows, the original patch missed the re-ordering
> required for the submodule mapping call).
>
> So I'd prefer my patch because of that fix and because of the tests.
Yeah, I'm fine with taking your patch as well. Thanks for the tests,
which I think help us avoid future regressions here.
--
brian m. carlson (he/him or they/them)
Houston, Texas, US
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 263 bytes --]
next prev parent reply other threads:[~2020-10-16 2:38 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-14 9:22 git fast-import leaks memory drastically, so crashes with out of memory by attempt to import 22MB export dump Dipl. Ing. Sergey Brester
2020-10-15 1:26 ` Jeff King
2020-10-15 11:50 ` Dipl. Ing. Sergey Brester
2020-10-15 15:38 ` [PATCH] fast-import: fix over-allocation of marks storage Jeff King
2020-10-15 17:29 ` Junio C Hamano
2020-10-15 17:34 ` Junio C Hamano
2020-10-15 18:09 ` Dipl. Ing. Sergey Brester
2020-10-15 18:35 ` Junio C Hamano
2020-10-15 18:58 ` Jeff King
2020-10-15 19:13 ` Junio C Hamano
2020-10-16 2:37 ` brian m. carlson [this message]
2020-10-15 19:05 ` Jeff King
2020-10-15 19:06 ` Jeff King
2020-10-16 3:18 ` brian m. carlson
2020-10-16 20:25 ` Jeff King
2020-10-15 19:17 ` Dipl. Ing. Sergey Brester
2020-10-15 20:15 ` Junio C Hamano
2020-10-15 17:57 ` René Scharfe
2020-10-15 15:52 ` git fast-import leaks memory drastically, so crashes with out of memory by attempt to import 22MB export dump René Scharfe
2020-10-15 16:19 ` Dipl. Ing. Sergey Brester
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201016023735.GD490427@camp.crustytoothpaste.net \
--to=sandals@crustytoothpaste.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=serg.brester@sebres.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.