From: Greg KH <gregkh@linuxfoundation.org>
To: kiransuren@osuosl.org, kirank.suren@gmail.com
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: android: ashmem: changed struct file_operations to const file_operations
Date: Fri, 16 Oct 2020 07:17:57 +0200 [thread overview]
Message-ID: <20201016051757.GA463503@kroah.com> (raw)
In-Reply-To: <20201016051111.1947-1-kirank.suren@gmail.com>
On Fri, Oct 16, 2020 at 01:11:11AM -0400, kiransuren@osuosl.org wrote:
> From: kiransuren <kirank.suren@gmail.com>
This does not match your signed-off-by line :(
>
> Fixed a coding style issue.
What issue? Always be specific.
>
> Signed-off-by: Kiran Surendran <kirank.suren@gmail.com>
> ---
> drivers/staging/android/ashmem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c
> index 10b4be1f3e78..f2b67c4fe8d2 100644
> --- a/drivers/staging/android/ashmem.c
> +++ b/drivers/staging/android/ashmem.c
> @@ -376,7 +376,7 @@ ashmem_vmfile_get_unmapped_area(struct file *file, unsigned long addr,
>
> static int ashmem_mmap(struct file *file, struct vm_area_struct *vma)
> {
> - static struct file_operations vmfile_fops;
> + static const file_operations vmfile_fops;
Why did you not test-build your patch before sending it out?
Don't you think that is a big rude?
Please be more careful.
greg k-h
next prev parent reply other threads:[~2020-10-16 5:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20201016051111.1947-1-kirank.suren@gmail.com>
2020-10-16 5:16 ` [PATCH] Staging: android: ashmem: changed struct file_operations to const file_operations Randy Dunlap
2020-10-16 5:17 ` Greg KH [this message]
[not found] ` <CAMHzSAHVtv+BuYgCAdbB26J3EHTdEyH3ZZUfP-g3zftppzJOkw@mail.gmail.com>
2020-10-16 6:18 ` Greg KH
2020-10-16 6:20 ` kernel test robot
2020-10-16 6:20 ` kernel test robot
2020-10-16 7:34 ` kernel test robot
2020-10-16 7:34 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201016051757.GA463503@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=kirank.suren@gmail.com \
--cc=kiransuren@osuosl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.