From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: David Gow <davidgow@google.com>
Cc: "open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
Brendan Higgins <brendanhiggins@google.com>,
KUnit Development <kunit-dev@googlegroups.com>,
Shuah Khan <skhan@linuxfoundation.org>,
Mark Brown <broonie@kernel.org>,
Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Subject: Re: [PATCH v2 2/3] lib/linear_ranges_kunit: Follow new file name convention for KUnit tests
Date: Fri, 16 Oct 2020 12:29:56 +0300 [thread overview]
Message-ID: <20201016092956.GI4077@smile.fi.intel.com> (raw)
In-Reply-To: <CABVgOSkA2mTpH7nXnL21zrAyi38xW_K=YnD85995u0+MLoDt5Q@mail.gmail.com>
On Fri, Oct 16, 2020 at 01:02:20PM +0800, David Gow wrote:
> On Fri, Oct 16, 2020 at 2:44 AM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > Follow new file name convention for the KUnit tests.
> > Since we have lib/*test*.c in a few variations,
> > use 'kunit' suffix to distinguish usual test cases
> > with KUnit-based ones.
> >
> > Cc: Mark Brown <broonie@kernel.org>
> > Cc: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Thanks. This looks good to me from an "I tested it and it worked" and
> a "matches the naming guidelines" point of view.
>
> (Since the naming documentation isn't actually in Linus' branch yet,
> I'll drop a link to it here:
> https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/tree/Documentation/dev-tools/kunit/style.rst?h=kunit
> )
>
> I'm not the test author though, and the naming doc does explicitly
> leave the possibility of keeping the old filenames for tests if
> there's a particularly good reason to (e.g., a lot depending on the
> module name).
Can you point out to this? Briefly looking into I haven't found that.
> I'm not aware of any such thing, and so am in favour of
> the rename, but will defer to the test authors on that point if they
> object.
> Either way,
> Reviewed-by: David Gow <davidgow@google.com>
Thanks!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-10-16 9:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-15 18:44 [PATCH v2 1/3] lib/list_kunit: Follow new file name convention for KUnit tests Andy Shevchenko
2020-10-15 18:44 ` [PATCH v2 2/3] lib/linear_ranges_kunit: " Andy Shevchenko
2020-10-16 5:02 ` David Gow
2020-10-16 9:29 ` Andy Shevchenko [this message]
2020-10-17 6:57 ` David Gow
2020-10-16 10:38 ` Mark Brown
2020-10-16 11:03 ` Andy Shevchenko
2020-10-16 11:10 ` Andy Shevchenko
2020-10-16 11:12 ` Mark Brown
2020-10-15 18:44 ` [PATCH v2 3/3] lib/bits_kunit: " Andy Shevchenko
2020-10-16 5:07 ` David Gow
2020-10-16 4:53 ` [PATCH v2 1/3] lib/list_kunit: " David Gow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201016092956.GI4077@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=brendanhiggins@google.com \
--cc=broonie@kernel.org \
--cc=davidgow@google.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.