From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Zimmermann Date: Fri, 16 Oct 2020 09:53:31 +0000 Subject: Re: [PATCH] omapfb/dss: Remove redundant null check before clk_prepare_enable/clk_disable_unprepare Message-Id: <20201016115331.0dd4341e@linux-uq9g> List-Id: References: <20201014084920.25813-1-vulab@iscas.ac.cn> <20201015100827.1115fa9b@linux-uq9g> In-Reply-To: <20201015100827.1115fa9b@linux-uq9g> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Xu Wang Cc: linux-fbdev@vger.kernel.org, b.zolnierkie@samsung.com, yuehaibing@huawei.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, pakki001@umn.edu, linux-omap@vger.kernel.org On Thu, 15 Oct 2020 10:08:27 +0200 Thomas Zimmermann wrote: > On Wed, 14 Oct 2020 08:49:20 +0000 Xu Wang wrote: > > > Because clk_prepare_enable() and clk_disable_unprepare() already checked > > NULL clock parameter, so the additional checks are unnecessary, just > > remove them. > > > > Signed-off-by: Xu Wang > > Reviewed-by: Thomas Zimmermann > Merged into drm-misc-next. Thanks! > > --- > > drivers/video/fbdev/omap2/omapfb/dss/venc.c | 6 ++---- > > 1 file changed, 2 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/video/fbdev/omap2/omapfb/dss/venc.c > > b/drivers/video/fbdev/omap2/omapfb/dss/venc.c index > > 0b0ad20afd63..8895fb8493d8 100644 --- > > a/drivers/video/fbdev/omap2/omapfb/dss/venc.c +++ > > b/drivers/video/fbdev/omap2/omapfb/dss/venc.c @@ -890,8 +890,7 @@ static > > int venc_remove(struct platform_device *pdev) > > static int venc_runtime_suspend(struct device *dev) > > { > > - if (venc.tv_dac_clk) > > - clk_disable_unprepare(venc.tv_dac_clk); > > + clk_disable_unprepare(venc.tv_dac_clk); > > > > dispc_runtime_put(); > > > > @@ -906,8 +905,7 @@ static int venc_runtime_resume(struct device *dev) > > if (r < 0) > > return r; > > > > - if (venc.tv_dac_clk) > > - clk_prepare_enable(venc.tv_dac_clk); > > + clk_prepare_enable(venc.tv_dac_clk); > > > > return 0; > > } > > > -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE9E2C43457 for ; Fri, 16 Oct 2020 09:53:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7DE8C20FC3 for ; Fri, 16 Oct 2020 09:53:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405485AbgJPJxg convert rfc822-to-8bit (ORCPT ); Fri, 16 Oct 2020 05:53:36 -0400 Received: from mx2.suse.de ([195.135.220.15]:42070 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2406400AbgJPJxg (ORCPT ); Fri, 16 Oct 2020 05:53:36 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 1A87CACF1; Fri, 16 Oct 2020 09:53:34 +0000 (UTC) Date: Fri, 16 Oct 2020 11:53:31 +0200 From: Thomas Zimmermann To: Xu Wang Cc: b.zolnierkie@samsung.com, pakki001@umn.edu, yuehaibing@huawei.com, linux-fbdev@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH] omapfb/dss: Remove redundant null check before clk_prepare_enable/clk_disable_unprepare Message-ID: <20201016115331.0dd4341e@linux-uq9g> In-Reply-To: <20201015100827.1115fa9b@linux-uq9g> References: <20201014084920.25813-1-vulab@iscas.ac.cn> <20201015100827.1115fa9b@linux-uq9g> Organization: SUSE Software Solutions Germany GmbH X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org On Thu, 15 Oct 2020 10:08:27 +0200 Thomas Zimmermann wrote: > On Wed, 14 Oct 2020 08:49:20 +0000 Xu Wang wrote: > > > Because clk_prepare_enable() and clk_disable_unprepare() already checked > > NULL clock parameter, so the additional checks are unnecessary, just > > remove them. > > > > Signed-off-by: Xu Wang > > Reviewed-by: Thomas Zimmermann > Merged into drm-misc-next. Thanks! > > --- > > drivers/video/fbdev/omap2/omapfb/dss/venc.c | 6 ++---- > > 1 file changed, 2 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/video/fbdev/omap2/omapfb/dss/venc.c > > b/drivers/video/fbdev/omap2/omapfb/dss/venc.c index > > 0b0ad20afd63..8895fb8493d8 100644 --- > > a/drivers/video/fbdev/omap2/omapfb/dss/venc.c +++ > > b/drivers/video/fbdev/omap2/omapfb/dss/venc.c @@ -890,8 +890,7 @@ static > > int venc_remove(struct platform_device *pdev) > > static int venc_runtime_suspend(struct device *dev) > > { > > - if (venc.tv_dac_clk) > > - clk_disable_unprepare(venc.tv_dac_clk); > > + clk_disable_unprepare(venc.tv_dac_clk); > > > > dispc_runtime_put(); > > > > @@ -906,8 +905,7 @@ static int venc_runtime_resume(struct device *dev) > > if (r < 0) > > return r; > > > > - if (venc.tv_dac_clk) > > - clk_prepare_enable(venc.tv_dac_clk); > > + clk_prepare_enable(venc.tv_dac_clk); > > > > return 0; > > } > > > -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E75C6C43467 for ; Fri, 16 Oct 2020 09:53:39 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 871E12073A for ; Fri, 16 Oct 2020 09:53:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 871E12073A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8C4656EA90; Fri, 16 Oct 2020 09:53:36 +0000 (UTC) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8B5116EA90 for ; Fri, 16 Oct 2020 09:53:35 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 1A87CACF1; Fri, 16 Oct 2020 09:53:34 +0000 (UTC) Date: Fri, 16 Oct 2020 11:53:31 +0200 From: Thomas Zimmermann To: Xu Wang Subject: Re: [PATCH] omapfb/dss: Remove redundant null check before clk_prepare_enable/clk_disable_unprepare Message-ID: <20201016115331.0dd4341e@linux-uq9g> In-Reply-To: <20201015100827.1115fa9b@linux-uq9g> References: <20201014084920.25813-1-vulab@iscas.ac.cn> <20201015100827.1115fa9b@linux-uq9g> Organization: SUSE Software Solutions Germany GmbH X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, b.zolnierkie@samsung.com, yuehaibing@huawei.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, pakki001@umn.edu, linux-omap@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gVGh1LCAxNSBPY3QgMjAyMCAxMDowODoyNyArMDIwMCBUaG9tYXMgWmltbWVybWFubiA8dHpp bW1lcm1hbm5Ac3VzZS5kZT4Kd3JvdGU6Cgo+IE9uIFdlZCwgMTQgT2N0IDIwMjAgMDg6NDk6MjAg KzAwMDAgWHUgV2FuZyA8dnVsYWJAaXNjYXMuYWMuY24+IHdyb3RlOgo+IAo+ID4gQmVjYXVzZSBj bGtfcHJlcGFyZV9lbmFibGUoKSBhbmQgY2xrX2Rpc2FibGVfdW5wcmVwYXJlKCkgYWxyZWFkeSBj aGVja2VkCj4gPiBOVUxMIGNsb2NrIHBhcmFtZXRlciwgc28gdGhlIGFkZGl0aW9uYWwgY2hlY2tz IGFyZSB1bm5lY2Vzc2FyeSwganVzdAo+ID4gcmVtb3ZlIHRoZW0uCj4gPiAKPiA+IFNpZ25lZC1v ZmYtYnk6IFh1IFdhbmcgPHZ1bGFiQGlzY2FzLmFjLmNuPgo+IAo+IFJldmlld2VkLWJ5OiBUaG9t YXMgWmltbWVybWFubiA8dHppbW1lcm1hbm5Ac3VzZS5kZT4KPiAKCk1lcmdlZCBpbnRvIGRybS1t aXNjLW5leHQuIFRoYW5rcyEKCj4gPiAtLS0KPiA+ICBkcml2ZXJzL3ZpZGVvL2ZiZGV2L29tYXAy L29tYXBmYi9kc3MvdmVuYy5jIHwgNiArKy0tLS0KPiA+ICAxIGZpbGUgY2hhbmdlZCwgMiBpbnNl cnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy92 aWRlby9mYmRldi9vbWFwMi9vbWFwZmIvZHNzL3ZlbmMuYwo+ID4gYi9kcml2ZXJzL3ZpZGVvL2Zi ZGV2L29tYXAyL29tYXBmYi9kc3MvdmVuYy5jIGluZGV4Cj4gPiAwYjBhZDIwYWZkNjMuLjg4OTVm Yjg0OTNkOCAxMDA2NDQgLS0tCj4gPiBhL2RyaXZlcnMvdmlkZW8vZmJkZXYvb21hcDIvb21hcGZi L2Rzcy92ZW5jLmMgKysrCj4gPiBiL2RyaXZlcnMvdmlkZW8vZmJkZXYvb21hcDIvb21hcGZiL2Rz cy92ZW5jLmMgQEAgLTg5MCw4ICs4OTAsNyBAQCBzdGF0aWMKPiA+IGludCB2ZW5jX3JlbW92ZShz dHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KSAKPiA+ICBzdGF0aWMgaW50IHZlbmNfcnVudGlt ZV9zdXNwZW5kKHN0cnVjdCBkZXZpY2UgKmRldikKPiA+ICB7Cj4gPiAtCWlmICh2ZW5jLnR2X2Rh Y19jbGspCj4gPiAtCQljbGtfZGlzYWJsZV91bnByZXBhcmUodmVuYy50dl9kYWNfY2xrKTsKPiA+ ICsJY2xrX2Rpc2FibGVfdW5wcmVwYXJlKHZlbmMudHZfZGFjX2Nsayk7Cj4gPiAgCj4gPiAgCWRp c3BjX3J1bnRpbWVfcHV0KCk7Cj4gPiAgCj4gPiBAQCAtOTA2LDggKzkwNSw3IEBAIHN0YXRpYyBp bnQgdmVuY19ydW50aW1lX3Jlc3VtZShzdHJ1Y3QgZGV2aWNlICpkZXYpCj4gPiAgCWlmIChyIDwg MCkKPiA+ICAJCXJldHVybiByOwo+ID4gIAo+ID4gLQlpZiAodmVuYy50dl9kYWNfY2xrKQo+ID4g LQkJY2xrX3ByZXBhcmVfZW5hYmxlKHZlbmMudHZfZGFjX2Nsayk7Cj4gPiArCWNsa19wcmVwYXJl X2VuYWJsZSh2ZW5jLnR2X2RhY19jbGspOwo+ID4gIAo+ID4gIAlyZXR1cm4gMDsKPiA+ICB9Cj4g Cj4gCj4gCgoKCi0tIApUaG9tYXMgWmltbWVybWFubgpHcmFwaGljcyBEcml2ZXIgRGV2ZWxvcGVy ClNVU0UgU29mdHdhcmUgU29sdXRpb25zIEdlcm1hbnkgR21iSApNYXhmZWxkc3RyLiA1LCA5MDQw OSBOw7xybmJlcmcsIEdlcm1hbnkKKEhSQiAzNjgwOSwgQUcgTsO8cm5iZXJnKQpHZXNjaMOkZnRz ZsO8aHJlcjogRmVsaXggSW1lbmTDtnJmZmVyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2RyaS1kZXZlbAo=