From: Kees Cook <keescook@chromium.org>
To: Matteo Croce <mcroce@linux.microsoft.com>
Cc: linux-kernel@vger.kernel.org, Guenter Roeck <linux@roeck-us.net>,
Petr Mladek <pmladek@suse.com>, Arnd Bergmann <arnd@arndb.de>,
Mike Rapoport <rppt@kernel.org>,
Pavel Tatashin <pasha.tatashin@soleen.com>,
Robin Holt <robinmholt@gmail.com>,
Fabian Frederick <fabf@skynet.be>,
stable@vger.kernel.org
Subject: Re: [PATCH 2/2] reboot: fix parsing of reboot cpu number
Date: Fri, 16 Oct 2020 12:26:54 -0700 [thread overview]
Message-ID: <202010161226.B136CDC8@keescook> (raw)
In-Reply-To: <20201016180907.171957-3-mcroce@linux.microsoft.com>
On Fri, Oct 16, 2020 at 08:09:07PM +0200, Matteo Croce wrote:
> From: Matteo Croce <mcroce@microsoft.com>
>
> The kernel cmdline reboot= argument allows to specify the CPU used
> for rebooting, with the syntax `s####` among the other flags, e.g.
>
> reboot=soft,s4
> reboot=warm,s31,force
>
> In the early days the parsing was done with simple_strtoul(), later
> deprecated in favor of the safer kstrtoint() which handles overflow.
>
> But kstrtoint() returns -EINVAL if there are non-digit characters
> in a string, so if this flag is not the last given, it's silently
> ignored as well as the subsequent ones.
>
> To fix it, revert the usage of simple_strtoul(), which is no longer
> deprecated, and restore the old behaviour.
It is? Is there a reference, because this was never updated:
https://www.kernel.org/doc/html/latest/process/deprecated.html#simple-strtol-simple-strtoll-simple-strtoul-simple-strtoull
--
Kees Cook
next prev parent reply other threads:[~2020-10-16 19:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-16 18:09 [PATCH 0/2] fix parsing of reboot= cmdline Matteo Croce
2020-10-16 18:09 ` [PATCH 1/2] reboot: fix overflow parsing reboot cpu number Matteo Croce
2020-10-16 19:25 ` Kees Cook
2020-10-16 19:45 ` Pavel Tatashin
2020-10-19 13:18 ` Petr Mladek
2020-10-16 18:09 ` [PATCH 2/2] reboot: fix parsing of " Matteo Croce
2020-10-16 19:26 ` Kees Cook [this message]
2020-10-16 21:34 ` Matteo Croce
2020-10-16 19:46 ` Pavel Tatashin
2020-10-19 13:49 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202010161226.B136CDC8@keescook \
--to=keescook@chromium.org \
--cc=arnd@arndb.de \
--cc=fabf@skynet.be \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mcroce@linux.microsoft.com \
--cc=pasha.tatashin@soleen.com \
--cc=pmladek@suse.com \
--cc=robinmholt@gmail.com \
--cc=rppt@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.