From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1200C433E7 for ; Fri, 16 Oct 2020 12:32:30 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 490AF2076A for ; Fri, 16 Oct 2020 12:32:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="1qffQ9LE"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="mEBb9RxU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 490AF2076A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GvMx5l4gGIevUAwmbX1hRqZNuaKXrW2cdWiIalLcCgY=; b=1qffQ9LEPpNjcLBJFOmjefQqJ SUWzdYQVuL2yEcO7MESO3wr7YckBbgp5E2Lrzsxa3wA5HEkjgTJaYuDUNJlVvC0fgCYegV9tC1R4e 1dvxY6PzD7YgSlKtCsg0KoyXCjQlRtAKRzlHPtuPbXYrK+1I5rbqULM3LytumcqH1yh/EhmXIXGGS s2kCacchc5JMBwnYOGV8ZoLr0FVP9Rpl2YHvDjVrvbvNw1odfyw9oe+XteyE56FMtB0pUZ6CXjP6L e7mrSchwLU7y2Z8UFzFdvrrtlKRNkVbyLNDGcVCT61jMjZwevvayD/v2GpHrL2GFiC3jyKuPKkF7D xkw62svPg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kTOsw-0001c2-O3; Fri, 16 Oct 2020 12:31:02 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kTOsu-0001bf-8Z for linux-arm-kernel@lists.infradead.org; Fri, 16 Oct 2020 12:31:00 +0000 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C42212083B; Fri, 16 Oct 2020 12:30:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602851458; bh=z2GZAv/vtO0AdPjaruvSmGJhhEi8SvV6/CPcRlCH0z0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mEBb9RxULdq6AGCGiwUnIR+zyk8tKv9Qe8zuocSau5/6fD85VWrMXuQePsGU3Icuq 1LW2Nz8b1vUOgQrgXJCO5qIZeXWlAHlCBkbAxV5tj5dn1vxy7+hyY5MCARxiuMlYWK lAV7I2QTT5xbgIBoXFsssnOTwKF8OgrZ562ophJ0= Date: Fri, 16 Oct 2020 13:30:50 +0100 From: Mark Brown To: Miroslav Benes Subject: Re: [RFC PATCH 3/3] arm64: stacktrace: Implement reliable stacktrace Message-ID: <20201016123050.GD5274@sirena.org.uk> References: <20201012172605.10715-1-broonie@kernel.org> <20201012172605.10715-4-broonie@kernel.org> <20201015155756.GE4390@sirena.org.uk> MIME-Version: 1.0 In-Reply-To: X-Cookie: Pournelle must die! User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201016_083100_412637_3CAE74E3 X-CRM114-Status: GOOD ( 20.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, jpoimboe@redhat.com Content-Type: multipart/mixed; boundary="===============5451020915844426511==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============5451020915844426511== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="mJm6k4Vb/yFcL9ZU" Content-Disposition: inline --mJm6k4Vb/yFcL9ZU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 16, 2020 at 12:13:14PM +0200, Miroslav Benes wrote: > On Thu, 15 Oct 2020, Mark Brown wrote: > > On Thu, Oct 15, 2020 at 03:33:44PM +0200, Miroslav Benes wrote: > > > I think it would be nice to check if frame.pc is a valid text address= here > > > before it is consumed next. > > I'm wondering if it might be better to do have the generic code do this > > in consume_entry() or something, it doesn't seem arch specific? > Maybe. There is currently no special consume_entry() for the reliable=20 > interface, but I think there is no reason not to introduce one. =2E..[Existing implementations handle it]... > So I don't know if it is worth it. My thinking was that it's not a huge cost even if it's redundant for the existing implementations and it's one less thing that people could miss. --mJm6k4Vb/yFcL9ZU Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl+JknkACgkQJNaLcl1U h9Apuwf/ckb85WUmcr+CXblAWdZpTlDQiR+0mI9l0psBufWPtXyTjtIZQ+ILqqMc biSgKH/L6Adjg449LPwpXmxZuXvE6GnFecgDYdyvpSSMv+M/HSluguyoLx02U5Lc ViTn7PotDOfqtLAxn6ixwwAbFGeqIX5BvG3lFBNRiwWgBcioUS8v7XsJPldlslVb akSQdDQNFT2dmOEx7XHkQ/BB5JA595OCsHybL22r/avJ0RIeY4CJlGJMuj567h5P 5OtC7ZIh0tG/PRj2G9PZa9dZaL9gKMImcF2kwhLz3ESnx3TsfOt0kPzikcHMC+UK 83j8cycbFrRQUUvNYHu0z2QndU4idg== =OTmU -----END PGP SIGNATURE----- --mJm6k4Vb/yFcL9ZU-- --===============5451020915844426511== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============5451020915844426511==--