From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Zimmermann Date: Fri, 16 Oct 2020 10:56:25 +0000 Subject: Re: [PATCH] video: fbdev: sh_mobile_lcdcfb: Remove redundant null check before clk_prepare_enable/cl Message-Id: <20201016125625.7d2b5bd7@linux-uq9g> List-Id: References: <20201014085722.26069-1-vulab@iscas.ac.cn> <20201015101015.6dbd25ce@linux-uq9g> In-Reply-To: <20201015101015.6dbd25ce@linux-uq9g> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Xu Wang Cc: linux-fbdev@vger.kernel.org, arnd@arndb.de, b.zolnierkie@samsung.com, jani.nikula@intel.com, daniel.vetter@ffwll.ch, gustavoars@kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org On Thu, 15 Oct 2020 10:10:15 +0200 Thomas Zimmermann wrote: > On Wed, 14 Oct 2020 08:57:22 +0000 Xu Wang wrote: > > > Because clk_prepare_enable() and clk_disable_unprepare() already checked > > NULL clock parameter, so the additional checks are unnecessary, just > > remove them. > > > > Signed-off-by: Xu Wang > > Reviewed-by: Thomas Zimmermann > Merged into drm-misc-next. Thanks! > > --- > > drivers/video/fbdev/sh_mobile_lcdcfb.c | 6 ++---- > > 1 file changed, 2 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/video/fbdev/sh_mobile_lcdcfb.c > > b/drivers/video/fbdev/sh_mobile_lcdcfb.c index c1043420dbd3..c0952cc96bdb > > 100644 --- a/drivers/video/fbdev/sh_mobile_lcdcfb.c > > +++ b/drivers/video/fbdev/sh_mobile_lcdcfb.c > > @@ -341,8 +341,7 @@ static void lcdc_wait_bit(struct sh_mobile_lcdc_priv > > *priv, static void sh_mobile_lcdc_clk_on(struct sh_mobile_lcdc_priv *priv) > > { > > if (atomic_inc_and_test(&priv->hw_usecnt)) { > > - if (priv->dot_clk) > > - clk_prepare_enable(priv->dot_clk); > > + clk_prepare_enable(priv->dot_clk); > > pm_runtime_get_sync(priv->dev); > > } > > } > > @@ -351,8 +350,7 @@ static void sh_mobile_lcdc_clk_off(struct > > sh_mobile_lcdc_priv *priv) { > > if (atomic_sub_return(1, &priv->hw_usecnt) = -1) { > > pm_runtime_put(priv->dev); > > - if (priv->dot_clk) > > - clk_disable_unprepare(priv->dot_clk); > > + clk_disable_unprepare(priv->dot_clk); > > } > > } > > > > > -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC3BAC433E7 for ; Fri, 16 Oct 2020 10:56:30 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 30582207F7 for ; Fri, 16 Oct 2020 10:56:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 30582207F7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4BFEE6EB29; Fri, 16 Oct 2020 10:56:29 +0000 (UTC) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2044A6EB29 for ; Fri, 16 Oct 2020 10:56:28 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id CD1D7AF2C; Fri, 16 Oct 2020 10:56:26 +0000 (UTC) Date: Fri, 16 Oct 2020 12:56:25 +0200 From: Thomas Zimmermann To: Xu Wang Subject: Re: [PATCH] video: fbdev: sh_mobile_lcdcfb: Remove redundant null check before clk_prepare_enable/clk_disable_unprepare Message-ID: <20201016125625.7d2b5bd7@linux-uq9g> In-Reply-To: <20201015101015.6dbd25ce@linux-uq9g> References: <20201014085722.26069-1-vulab@iscas.ac.cn> <20201015101015.6dbd25ce@linux-uq9g> Organization: SUSE Software Solutions Germany GmbH X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, arnd@arndb.de, b.zolnierkie@samsung.com, jani.nikula@intel.com, daniel.vetter@ffwll.ch, gustavoars@kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gVGh1LCAxNSBPY3QgMjAyMCAxMDoxMDoxNSArMDIwMCBUaG9tYXMgWmltbWVybWFubiA8dHpp bW1lcm1hbm5Ac3VzZS5kZT4Kd3JvdGU6Cgo+IE9uIFdlZCwgMTQgT2N0IDIwMjAgMDg6NTc6MjIg KzAwMDAgWHUgV2FuZyA8dnVsYWJAaXNjYXMuYWMuY24+IHdyb3RlOgo+IAo+ID4gQmVjYXVzZSBj bGtfcHJlcGFyZV9lbmFibGUoKSBhbmQgY2xrX2Rpc2FibGVfdW5wcmVwYXJlKCkgYWxyZWFkeSBj aGVja2VkCj4gPiBOVUxMIGNsb2NrIHBhcmFtZXRlciwgc28gdGhlIGFkZGl0aW9uYWwgY2hlY2tz IGFyZSB1bm5lY2Vzc2FyeSwganVzdAo+ID4gcmVtb3ZlIHRoZW0uCj4gPiAKPiA+IFNpZ25lZC1v ZmYtYnk6IFh1IFdhbmcgPHZ1bGFiQGlzY2FzLmFjLmNuPgo+IAo+IFJldmlld2VkLWJ5OiBUaG9t YXMgWmltbWVybWFubiA8dHppbW1lcm1hbm5Ac3VzZS5kZT4KPiAKCk1lcmdlZCBpbnRvIGRybS1t aXNjLW5leHQuIFRoYW5rcyEKCj4gPiAtLS0KPiA+ICBkcml2ZXJzL3ZpZGVvL2ZiZGV2L3NoX21v YmlsZV9sY2RjZmIuYyB8IDYgKystLS0tCj4gPiAgMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9u cygrKSwgNCBkZWxldGlvbnMoLSkKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvdmlkZW8v ZmJkZXYvc2hfbW9iaWxlX2xjZGNmYi5jCj4gPiBiL2RyaXZlcnMvdmlkZW8vZmJkZXYvc2hfbW9i aWxlX2xjZGNmYi5jIGluZGV4IGMxMDQzNDIwZGJkMy4uYzA5NTJjYzk2YmRiCj4gPiAxMDA2NDQg LS0tIGEvZHJpdmVycy92aWRlby9mYmRldi9zaF9tb2JpbGVfbGNkY2ZiLmMKPiA+ICsrKyBiL2Ry aXZlcnMvdmlkZW8vZmJkZXYvc2hfbW9iaWxlX2xjZGNmYi5jCj4gPiBAQCAtMzQxLDggKzM0MSw3 IEBAIHN0YXRpYyB2b2lkIGxjZGNfd2FpdF9iaXQoc3RydWN0IHNoX21vYmlsZV9sY2RjX3ByaXYK PiA+ICpwcml2LCBzdGF0aWMgdm9pZCBzaF9tb2JpbGVfbGNkY19jbGtfb24oc3RydWN0IHNoX21v YmlsZV9sY2RjX3ByaXYgKnByaXYpCj4gPiAgewo+ID4gIAlpZiAoYXRvbWljX2luY19hbmRfdGVz dCgmcHJpdi0+aHdfdXNlY250KSkgewo+ID4gLQkJaWYgKHByaXYtPmRvdF9jbGspCj4gPiAtCQkJ Y2xrX3ByZXBhcmVfZW5hYmxlKHByaXYtPmRvdF9jbGspOwo+ID4gKwkJY2xrX3ByZXBhcmVfZW5h YmxlKHByaXYtPmRvdF9jbGspOwo+ID4gIAkJcG1fcnVudGltZV9nZXRfc3luYyhwcml2LT5kZXYp Owo+ID4gIAl9Cj4gPiAgfQo+ID4gQEAgLTM1MSw4ICszNTAsNyBAQCBzdGF0aWMgdm9pZCBzaF9t b2JpbGVfbGNkY19jbGtfb2ZmKHN0cnVjdAo+ID4gc2hfbW9iaWxlX2xjZGNfcHJpdiAqcHJpdikg ewo+ID4gIAlpZiAoYXRvbWljX3N1Yl9yZXR1cm4oMSwgJnByaXYtPmh3X3VzZWNudCkgPT0gLTEp IHsKPiA+ICAJCXBtX3J1bnRpbWVfcHV0KHByaXYtPmRldik7Cj4gPiAtCQlpZiAocHJpdi0+ZG90 X2NsaykKPiA+IC0JCQljbGtfZGlzYWJsZV91bnByZXBhcmUocHJpdi0+ZG90X2Nsayk7Cj4gPiAr CQljbGtfZGlzYWJsZV91bnByZXBhcmUocHJpdi0+ZG90X2Nsayk7Cj4gPiAgCX0KPiA+ICB9Cj4g PiAgCj4gCj4gCj4gCgoKCi0tIApUaG9tYXMgWmltbWVybWFubgpHcmFwaGljcyBEcml2ZXIgRGV2 ZWxvcGVyClNVU0UgU29mdHdhcmUgU29sdXRpb25zIEdlcm1hbnkgR21iSApNYXhmZWxkc3RyLiA1 LCA5MDQwOSBOw7xybmJlcmcsIEdlcm1hbnkKKEhSQiAzNjgwOSwgQUcgTsO8cm5iZXJnKQpHZXNj aMOkZnRzZsO8aHJlcjogRmVsaXggSW1lbmTDtnJmZmVyCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVs QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C5BFC433DF for ; Fri, 16 Oct 2020 10:56:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 43ADA2145D for ; Fri, 16 Oct 2020 10:56:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2395562AbgJPK43 convert rfc822-to-8bit (ORCPT ); Fri, 16 Oct 2020 06:56:29 -0400 Received: from mx2.suse.de ([195.135.220.15]:35088 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2395510AbgJPK42 (ORCPT ); Fri, 16 Oct 2020 06:56:28 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id CD1D7AF2C; Fri, 16 Oct 2020 10:56:26 +0000 (UTC) Date: Fri, 16 Oct 2020 12:56:25 +0200 From: Thomas Zimmermann To: Xu Wang Cc: linux-fbdev@vger.kernel.org, arnd@arndb.de, b.zolnierkie@samsung.com, jani.nikula@intel.com, daniel.vetter@ffwll.ch, gustavoars@kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] video: fbdev: sh_mobile_lcdcfb: Remove redundant null check before clk_prepare_enable/clk_disable_unprepare Message-ID: <20201016125625.7d2b5bd7@linux-uq9g> In-Reply-To: <20201015101015.6dbd25ce@linux-uq9g> References: <20201014085722.26069-1-vulab@iscas.ac.cn> <20201015101015.6dbd25ce@linux-uq9g> Organization: SUSE Software Solutions Germany GmbH X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 15 Oct 2020 10:10:15 +0200 Thomas Zimmermann wrote: > On Wed, 14 Oct 2020 08:57:22 +0000 Xu Wang wrote: > > > Because clk_prepare_enable() and clk_disable_unprepare() already checked > > NULL clock parameter, so the additional checks are unnecessary, just > > remove them. > > > > Signed-off-by: Xu Wang > > Reviewed-by: Thomas Zimmermann > Merged into drm-misc-next. Thanks! > > --- > > drivers/video/fbdev/sh_mobile_lcdcfb.c | 6 ++---- > > 1 file changed, 2 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/video/fbdev/sh_mobile_lcdcfb.c > > b/drivers/video/fbdev/sh_mobile_lcdcfb.c index c1043420dbd3..c0952cc96bdb > > 100644 --- a/drivers/video/fbdev/sh_mobile_lcdcfb.c > > +++ b/drivers/video/fbdev/sh_mobile_lcdcfb.c > > @@ -341,8 +341,7 @@ static void lcdc_wait_bit(struct sh_mobile_lcdc_priv > > *priv, static void sh_mobile_lcdc_clk_on(struct sh_mobile_lcdc_priv *priv) > > { > > if (atomic_inc_and_test(&priv->hw_usecnt)) { > > - if (priv->dot_clk) > > - clk_prepare_enable(priv->dot_clk); > > + clk_prepare_enable(priv->dot_clk); > > pm_runtime_get_sync(priv->dev); > > } > > } > > @@ -351,8 +350,7 @@ static void sh_mobile_lcdc_clk_off(struct > > sh_mobile_lcdc_priv *priv) { > > if (atomic_sub_return(1, &priv->hw_usecnt) == -1) { > > pm_runtime_put(priv->dev); > > - if (priv->dot_clk) > > - clk_disable_unprepare(priv->dot_clk); > > + clk_disable_unprepare(priv->dot_clk); > > } > > } > > > > > -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer