From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
Cc: guaneryu@gmail.com, fstests@vger.kernel.org
Subject: Re: [PATCH 1/2] xfs/521: use _try_scratch_mount instead of _scratch_mount
Date: Fri, 16 Oct 2020 08:32:10 -0700 [thread overview]
Message-ID: <20201016153210.GA9830@magnolia> (raw)
In-Reply-To: <1602840684-25524-1-git-send-email-xuyang2018.jy@cn.fujitsu.com>
On Fri, Oct 16, 2020 at 05:31:23PM +0800, Yang Xu wrote:
> Here will check the return code of mount option. So update it
> to use _try_scratch_mount.
>
> Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
Looks good to me,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> tests/xfs/521 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/xfs/521 b/tests/xfs/521
> index 3aaa1296..e6c417b8 100755
> --- a/tests/xfs/521
> +++ b/tests/xfs/521
> @@ -49,7 +49,7 @@ echo "Format and mount 100m rt volume"
> export USE_EXTERNAL=yes
> export SCRATCH_RTDEV=$rtdev
> _scratch_mkfs -r size=100m > $seqres.full
> -_scratch_mount || _notrun "Could not mount scratch with synthetic rt volume"
> +_try_scratch_mount || _notrun "Could not mount scratch with synthetic rt volume"
>
> testdir=$SCRATCH_MNT/test-$seq
> mkdir $testdir
> --
> 2.23.0
>
>
>
prev parent reply other threads:[~2020-10-16 15:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-16 9:31 [PATCH 1/2] xfs/521: use _try_scratch_mount instead of _scratch_mount Yang Xu
2020-10-16 9:31 ` [PATCH 2/2] generic/402: " Yang Xu
2020-10-16 15:33 ` Darrick J. Wong
2020-10-18 10:10 ` Eryu Guan
2020-10-19 2:05 ` Yang Xu
2020-10-19 3:01 ` [PATCH v2] generic/402: Drop useless fail message Yang Xu
2020-10-19 16:03 ` Darrick J. Wong
2020-10-16 15:32 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201016153210.GA9830@magnolia \
--to=darrick.wong@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=xuyang2018.jy@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.