All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@nvidia.com>
To: Alex Dewar <alex.dewar90@gmail.com>
Cc: Zhu Yanjun <yanjunz@nvidia.com>,
	Doug Ledford <dledford@redhat.com>,
	Bob Pearson <rpearsonhpe@gmail.com>, <linux-rdma@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] RDMA/rxe: Fix possible NULL pointer dereference
Date: Fri, 16 Oct 2020 14:04:24 -0300	[thread overview]
Message-ID: <20201016170424.GA161687@nvidia.com> (raw)
In-Reply-To: <20201012165229.59257-1-alex.dewar90@gmail.com>

On Mon, Oct 12, 2020 at 05:52:30PM +0100, Alex Dewar wrote:
> skb_clone() is called without checking if the returned pointer is NULL
> before it is dereferenced. Fix by adding an additional error check.
> 
> Fixes: e7ec96fc7932 ("RDMA/rxe: Fix skb lifetime in rxe_rcv_mcast_pkt()")
> Addresses-Coverity-ID: 1497804: Null pointer dereferences (NULL_RETURNS)
> Signed-off-by: Alex Dewar <alex.dewar90@gmail.com>
> ---
>  drivers/infiniband/sw/rxe/rxe_recv.c | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)

I took Bob's version of this since it is a little bit simpler

Thanks,
Jason

      parent reply	other threads:[~2020-10-16 17:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-12 16:52 [PATCH] RDMA/rxe: Fix possible NULL pointer dereference Alex Dewar
     [not found] ` <DM6PR12MB3516EC1E0F28EB8F9B970F24D5050@DM6PR12MB3516.namprd12.prod.outlook.com>
2020-10-14  0:37   ` FW: " Zhu Yanjun
2020-10-16 17:04 ` Jason Gunthorpe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201016170424.GA161687@nvidia.com \
    --to=jgg@nvidia.com \
    --cc=alex.dewar90@gmail.com \
    --cc=dledford@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=rpearsonhpe@gmail.com \
    --cc=yanjunz@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.