From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Ian Kumlien <ian.kumlien@gmail.com>,
anthony.l.nguyen@intel.com, David Miller <davem@davemloft.net>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
kernel-team@fb.com,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: Re: [PATCH net] ixgbe: fix probing of multi-port devices with one MDIO
Date: Fri, 16 Oct 2020 17:48:07 -0700 [thread overview]
Message-ID: <20201016174807.000036d6@intel.com> (raw)
In-Reply-To: <20201016170126.21b1cad5@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Jakub Kicinski wrote:
> On Sat, 17 Oct 2020 01:50:59 +0200 Ian Kumlien wrote:
> > On Sat, Oct 17, 2020 at 1:20 AM Jakub Kicinski <kuba@kernel.org> wrote:
> > > Ian reports that after upgrade from v5.8.14 to v5.9 only one
> > > of his 4 ixgbe netdevs appear in the system.
> > >
> > > Quoting the comment on ixgbe_x550em_a_has_mii():
> > > * Returns true if hw points to lowest numbered PCI B:D.F x550_em_a device in
> > > * the SoC. There are up to 4 MACs sharing a single MDIO bus on the x550em_a,
> > > * but we only want to register one MDIO bus.
> > >
> > > This matches the symptoms, since the return value from
> > > ixgbe_mii_bus_init() is no longer ignored we need to handle
> > > the higher ports of x550em without an error.
> >
> > Nice, that fixes it!
> >
> > You can add a:
> > Tested-by: Ian Kumlien <ian.kumlien@gmail.com>
>
> Will do, thanks!
>
> Tony, should I apply directly to net?
Thank you Kuba!
Seems like a pretty straight forward bug-fix. I recommend
you apply it directly.
Acked-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
next prev parent reply other threads:[~2020-10-17 5:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-16 23:20 [PATCH net] ixgbe: fix probing of multi-port devices with one MDIO Jakub Kicinski
2020-10-16 23:50 ` Ian Kumlien
2020-10-17 0:01 ` Jakub Kicinski
2020-10-17 0:48 ` Jesse Brandeburg [this message]
2020-10-18 20:04 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201016174807.000036d6@intel.com \
--to=jesse.brandeburg@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=davem@davemloft.net \
--cc=ian.kumlien@gmail.com \
--cc=kernel-team@fb.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.