All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vaishnav M A <vaishnav@beagleboard.org>
To: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de,
	pmeerw@pmeerw.net, alexandru.ardelean@analog.com,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: jkridner@beagleboard.org, drew@beagleboard.org,
	robertcnelson@beagleboard.org, rajkovic@mikroe.com
Subject: [PATCH] iio: light: vcnl4035 add i2c_device_id
Date: Sat, 17 Oct 2020 00:14:59 +0530	[thread overview]
Message-ID: <20201016184422.GA15952@ubuntu> (raw)


This patch aims to add i2c_device_id for the
vcnl4035 driver, while going through the initial driver
submission patches, noticed that the i2c_device_id was removed
on suggestion (https://lore.kernel.org/patchwork/patch/970970/),
will it be possible to consider this patch add the i2c_device_id,
so that the device can be instantiated using i2c_new_client_device
or say from the userspace?.This will be really helpful in cases
where the device tree based description is not possible now(Eg. 
a device on a gbphy i2c adapter created by greybus).

The particular usecase here is described over this RFC Patch
for the mikroBUS driver:
https://lore.kernel.org/patchwork/patch/1290148/

Thanks and Regards,

Vaishnav M A

Signed-off-by: Vaishnav M A <vaishnav@beagleboard.org>
---
 drivers/iio/light/vcnl4035.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/iio/light/vcnl4035.c b/drivers/iio/light/vcnl4035.c
index 765c44adac57..73a28e30dddc 100644
--- a/drivers/iio/light/vcnl4035.c
+++ b/drivers/iio/light/vcnl4035.c
@@ -652,6 +652,12 @@ static const struct dev_pm_ops vcnl4035_pm_ops = {
 			   vcnl4035_runtime_resume, NULL)
 };
 
+static const struct i2c_device_id vcnl4035_id[] = {
+	{ "vcnl4035", 0},
+	{ }
+};
+MODULE_DEVICE_TABLE(i2c, vcnl4035_id);
+
 static const struct of_device_id vcnl4035_of_match[] = {
 	{ .compatible = "vishay,vcnl4035", },
 	{ }
@@ -666,6 +672,7 @@ static struct i2c_driver vcnl4035_driver = {
 	},
 	.probe  = vcnl4035_probe,
 	.remove	= vcnl4035_remove,
+	.id_table = vcnl4035_id,
 };
 
 module_i2c_driver(vcnl4035_driver);
-- 
2.25.1


             reply	other threads:[~2020-10-16 18:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-16 18:44 Vaishnav M A [this message]
2020-10-18 11:21 ` [PATCH] iio: light: vcnl4035 add i2c_device_id Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201016184422.GA15952@ubuntu \
    --to=vaishnav@beagleboard.org \
    --cc=alexandru.ardelean@analog.com \
    --cc=drew@beagleboard.org \
    --cc=jic23@kernel.org \
    --cc=jkridner@beagleboard.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    --cc=rajkovic@mikroe.com \
    --cc=robertcnelson@beagleboard.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.