All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zdenek Kabelac <zkabelac@sourceware.org>
To: lvm-devel@redhat.com
Subject: stable-2.02 - tests: check in_sync prints also dm status
Date: Fri, 16 Oct 2020 19:11:28 +0000 (GMT)	[thread overview]
Message-ID: <20201016191128.225EC396EC6B@sourceware.org> (raw)

Gitweb:        https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=4ebc8875d3f09cd446d1001361dc81af4cb8ded3
Commit:        4ebc8875d3f09cd446d1001361dc81af4cb8ded3
Parent:        0881ba9e9f32144d5a538b9920367c494513d23a
Author:        Zdenek Kabelac <zkabelac@redhat.com>
AuthorDate:    Sat Sep 12 19:04:56 2020 +0200
Committer:     Zdenek Kabelac <zkabelac@redhat.com>
CommitterDate: Fri Oct 16 17:07:59 2020 +0200

tests: check in_sync prints also dm status

It's more useful to see how the progress of status checking is moving.
---
 test/lib/check.sh | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/test/lib/check.sh b/test/lib/check.sh
index 8637619f4..4deb78a74 100644
--- a/test/lib/check.sh
+++ b/test/lib/check.sh
@@ -216,7 +216,7 @@ in_sync() {
 		idx=6
 		type=${a[3]}
 		if [ "${a[$(( idx + 1 ))]}" != "idle" ]; then
-			echo "$lvm_name ($type$snap) is not in-sync"
+			echo "$lvm_name ($type$snap) is not in-sync    " "${a[@]}"
 			return 1
 		fi
 		;;
@@ -234,19 +234,19 @@ in_sync() {
 	c=${a[$idx]##*/}
 
 	if [ "$b" -eq 0 ] || [ "$b" != "$c" ]; then
-		echo "$lvm_name ($type$snap) is not in-sync"
+		echo "$lvm_name ($type$snap) is not in-sync    " "${a[@]}"
 		return 1
 	fi
 
 	if [[ ${a[$(( idx - 1 ))]} =~ a ]] ; then
 		[ "$ignore_a" = 0 ] && \
 			die "$lvm_name ($type$snap) in-sync, but 'a' characters in health status"
-		echo "$lvm_name ($type$snap) is not in-sync"
+		echo "$lvm_name ($type$snap) is not in-sync    " "${a[@]}"
 		[ "$ignore_a" = 1 ] && return 0
 		return 1
 	fi
 
-	echo "$lvm_name ($type$snap) is in-sync" "${a[@]}"
+	echo "$lvm_name ($type$snap) is in-sync    " "${a[@]}"
 }
 
 active() {



                 reply	other threads:[~2020-10-16 19:11 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201016191128.225EC396EC6B@sourceware.org \
    --to=zkabelac@sourceware.org \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.