From: Jason Gunthorpe <jgg@nvidia.com>
To: Bob Pearson <rpearsonhpe@gmail.com>
Cc: <linux-rdma@vger.kernel.org>
Subject: Re: Move the definitions for rxe_av.network_type to uAPI
Date: Fri, 16 Oct 2020 17:31:54 -0300 [thread overview]
Message-ID: <20201016203154.GR6219@nvidia.com> (raw)
In-Reply-To: <96dfe365-bd38-4022-8019-e337f168af47@gmail.com>
On Fri, Oct 16, 2020 at 03:20:50PM -0500, Bob Pearson wrote:
> Jason,
>
> Your recent commit:
>
> commit e0d696d201dd5d31813787d9b61a42fc459eee89
> Author: Jason Gunthorpe <jgg@ziepe.ca>
> Date: Thu Oct 15 20:42:18 2020 -0300
>
> RDMA/rxe: Move the definitions for rxe_av.network_type to uAPI
>
> has some problems and so far I am having trouble making it work sensibly.
>
> What you have done is to make the network_type field in rxe_av be private,
> (i.e. RXE_NETWORK_TYPE_XXX instead of RDMA_NETWORK_XXX). You then defined these
> private enums in rdma_uverbs_rxe.h. The problem is that there are more than one
> source of AVs those:
Bah, I missed rxe_av_fill_ip_info(), still it should just transcode
for now.
> There was also a confusion between V6 and V4. I will submit a small patch that
> fixes that and makes the enums the same again which is more efficient than transocding
> them.
Bah again. People need to check the stuff I write at 9pm :P
Jason
prev parent reply other threads:[~2020-10-16 20:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-16 20:20 Move the definitions for rxe_av.network_type to uAPI Bob Pearson
2020-10-16 20:31 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201016203154.GR6219@nvidia.com \
--to=jgg@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=rpearsonhpe@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.