From: Nigel Christian <nigel.l.christian@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: [PATCH] hw_random : platform_get_irq() already prints an error
Date: Sun, 18 Oct 2020 05:49:12 +0000 [thread overview]
Message-ID: <20201018054912.GA76941@fedora-thirty-three> (raw)
coccicheck
drivers/char//hw_random/imx-rngc.c:256:2-9: line 256 is redundant because platform_get_irq() already prints an error
Signed-off-by: Nigel Christian <nigel.l.christian@gmail.com>
---
drivers/char/hw_random/imx-rngc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/char/hw_random/imx-rngc.c b/drivers/char/hw_random/imx-rngc.c
index 61c844baf26e..69f13ff1bbec 100644
--- a/drivers/char/hw_random/imx-rngc.c
+++ b/drivers/char/hw_random/imx-rngc.c
@@ -253,7 +253,6 @@ static int imx_rngc_probe(struct platform_device *pdev)
irq = platform_get_irq(pdev, 0);
if (irq <= 0) {
- dev_err(&pdev->dev, "Couldn't get irq %d\n", irq);
return irq;
}
--
2.28.0
next reply other threads:[~2020-10-18 5:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-18 5:49 Nigel Christian [this message]
2020-10-18 10:53 ` [PATCH] hw_random : platform_get_irq() already prints an error Julia Lawall
2020-10-27 11:22 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201018054912.GA76941@fedora-thirty-three \
--to=nigel.l.christian@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.