From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/transmission: drop second patch
Date: Sun, 18 Oct 2020 18:40:57 +0200 [thread overview]
Message-ID: <20201018164057.GA3466@scaer> (raw)
In-Reply-To: <20201017194639.3919479-1-fontaine.fabrice@gmail.com>
Fabrice, All,
On 2020-10-17 21:46 +0200, Fabrice Fontaine spake thusly:
> transmission in version 3.00 is building fine on musl and upstream
> thinks that this patch is not needed anymore:
> https://github.com/transmission/transmission/pull/1156
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Applied to master, after expanding about the reason this is now correct.
I also updated the patch to jsut drop the code instead of commenting it
out, and by restoring CR/LF line endings as used by upstream.
Thanks!
Regards,
Yann E. MORIN.
> ---
> ...clude.patch => 0002-fix-utp-include.patch} | 0
> .../0002-musl-missing-header.patch | 36 -------------------
> 2 files changed, 36 deletions(-)
> rename package/transmission/{0003-fix-utp-include.patch => 0002-fix-utp-include.patch} (100%)
> delete mode 100644 package/transmission/0002-musl-missing-header.patch
>
> diff --git a/package/transmission/0003-fix-utp-include.patch b/package/transmission/0002-fix-utp-include.patch
> similarity index 100%
> rename from package/transmission/0003-fix-utp-include.patch
> rename to package/transmission/0002-fix-utp-include.patch
> diff --git a/package/transmission/0002-musl-missing-header.patch b/package/transmission/0002-musl-missing-header.patch
> deleted file mode 100644
> index ebb74cbffb..0000000000
> --- a/package/transmission/0002-musl-missing-header.patch
> +++ /dev/null
> @@ -1,36 +0,0 @@
> -Fix musl build
> -
> -Downloaded from
> -https://cgit.gentoo.org/proj/musl.git/tree/net-p2p/transmission/files/transmission-2.84-musl-missing-header.patch
> -
> -Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> -
> -
> -libtransmission/transmission.h: add missing <sys/types.h>
> -
> -transmission.h and several files including it, like bitfield.c and fdlimits.h
> -make reference to ssize_t, off_t and other types defined in <sys/types.h> but
> -never include the header. By including <sys/types.h> in transmission.h, the
> -required type definitions are propagated to all files that need them.
> -
> -Not including <sys/types.h> on glibc and uClibc systems does not pose a problem
> -because of the way the headers stack in those C Standard Libraries, but on musl
> -excluding <sys/types.h> leads to compile time failure.
> -
> -For the POSIX specs, see
> -
> -http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/sys_types.h.html
> -
> -Signed-of-by: Anthony G. Basile <blueness@gentoo.org>
> -
> -diff -Naur transmission-2.84.orig/libtransmission/transmission.h transmission-2.84/libtransmission/transmission.h
> ---- transmission-2.84.orig/libtransmission/transmission.h 2014-07-01 13:09:01.682910744 -0400
> -+++ transmission-2.84/libtransmission/transmission.h 2015-07-19 03:11:07.379219181 -0400
> -@@ -28,6 +28,7 @@
> -
> - #include <inttypes.h> /* uintN_t */
> - #include <time.h> /* time_t */
> -+#include <sys/types.h>
> -
> - #ifdef WIN32
> - #define __USE_MINGW_ANSI_STDIO 1
> --
> 2.28.0
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2020-10-18 16:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-17 19:46 [Buildroot] [PATCH 1/1] package/transmission: drop second patch Fabrice Fontaine
2020-10-17 21:59 ` Yann E. MORIN
2020-10-18 16:40 ` Yann E. MORIN [this message]
2020-10-18 19:50 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201018164057.GA3466@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.