From: Chandan Babu R <chandanrlinux@gmail.com>
To: linux-xfs@vger.kernel.org
Cc: Chandan Babu R <chandanrlinux@gmail.com>,
darrick.wong@oracle.com, david@fromorbit.com, hch@infradead.org,
Christoph Hellwig <hch@lst.de>
Subject: [PATCH V7 06/14] xfs: Check for extent overflow when writing to unwritten extent
Date: Mon, 19 Oct 2020 12:10:40 +0530 [thread overview]
Message-ID: <20201019064048.6591-7-chandanrlinux@gmail.com> (raw)
In-Reply-To: <20201019064048.6591-1-chandanrlinux@gmail.com>
A write to a sub-interval of an existing unwritten extent causes
the original extent to be split into 3 extents
i.e. | Unwritten | Real | Unwritten |
Hence extent count can increase by 2.
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Chandan Babu R <chandanrlinux@gmail.com>
---
fs/xfs/libxfs/xfs_inode_fork.h | 8 ++++++++
fs/xfs/xfs_iomap.c | 5 +++++
2 files changed, 13 insertions(+)
diff --git a/fs/xfs/libxfs/xfs_inode_fork.h b/fs/xfs/libxfs/xfs_inode_fork.h
index fd93fdc67ee4..afb647e1e3fa 100644
--- a/fs/xfs/libxfs/xfs_inode_fork.h
+++ b/fs/xfs/libxfs/xfs_inode_fork.h
@@ -70,6 +70,14 @@ struct xfs_ifork {
#define XFS_IEXT_DIR_MANIP_CNT(mp) \
((XFS_DA_NODE_MAXDEPTH + 1 + 1) * (mp)->m_dir_geo->fsbcount)
+/*
+ * A write to a sub-interval of an existing unwritten extent causes the original
+ * extent to be split into 3 extents
+ * i.e. | Unwritten | Real | Unwritten |
+ * Hence extent count can increase by 2.
+ */
+#define XFS_IEXT_WRITE_UNWRITTEN_CNT (2)
+
/*
* Fork handling.
*/
diff --git a/fs/xfs/xfs_iomap.c b/fs/xfs/xfs_iomap.c
index a302a96823b8..2aa788379611 100644
--- a/fs/xfs/xfs_iomap.c
+++ b/fs/xfs/xfs_iomap.c
@@ -566,6 +566,11 @@ xfs_iomap_write_unwritten(
if (error)
goto error_on_bmapi_transaction;
+ error = xfs_iext_count_may_overflow(ip, XFS_DATA_FORK,
+ XFS_IEXT_WRITE_UNWRITTEN_CNT);
+ if (error)
+ goto error_on_bmapi_transaction;
+
/*
* Modify the unwritten extent state of the buffer.
*/
--
2.28.0
next prev parent reply other threads:[~2020-10-19 6:41 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 6:40 [PATCH V7 00/14] Bail out if transaction can cause extent count to overflow Chandan Babu R
2020-10-19 6:40 ` [PATCH V7 01/14] xfs: Add helper for checking per-inode extent count overflow Chandan Babu R
2020-10-24 19:28 ` Allison Henderson
2020-10-19 6:40 ` [PATCH V7 02/14] xfs: Check for extent overflow when trivally adding a new extent Chandan Babu R
2020-10-24 19:28 ` Allison Henderson
2020-10-19 6:40 ` [PATCH V7 03/14] xfs: Check for extent overflow when punching a hole Chandan Babu R
2020-10-24 19:28 ` Allison Henderson
2020-10-19 6:40 ` [PATCH V7 04/14] xfs: Check for extent overflow when adding/removing xattrs Chandan Babu R
2020-10-24 19:29 ` Allison Henderson
2020-10-19 6:40 ` [PATCH V7 05/14] xfs: Check for extent overflow when adding/removing dir entries Chandan Babu R
2020-10-24 20:18 ` Allison Henderson
2020-10-19 6:40 ` Chandan Babu R [this message]
2020-10-24 20:18 ` [PATCH V7 06/14] xfs: Check for extent overflow when writing to unwritten extent Allison Henderson
2020-10-19 6:40 ` [PATCH V7 07/14] xfs: Check for extent overflow when moving extent from cow to data fork Chandan Babu R
2020-10-24 20:18 ` Allison Henderson
2020-10-19 6:40 ` [PATCH V7 08/14] xfs: Check for extent overflow when remapping an extent Chandan Babu R
2020-10-24 20:32 ` Allison Henderson
2020-10-26 23:10 ` Darrick J. Wong
2020-10-19 6:40 ` [PATCH V7 09/14] xfs: Check for extent overflow when swapping extents Chandan Babu R
2020-10-24 20:41 ` Allison Henderson
2020-10-19 6:40 ` [PATCH V7 10/14] xfs: Introduce error injection to reduce maximum inode fork extent count Chandan Babu R
2020-10-24 20:44 ` Allison Henderson
2020-10-19 6:40 ` [PATCH V7 11/14] xfs: Remove duplicate assert statement in xfs_bmap_btalloc() Chandan Babu R
2020-10-24 22:21 ` Allison Henderson
2020-10-26 23:11 ` Darrick J. Wong
2020-10-19 6:40 ` [PATCH V7 12/14] xfs: Compute bmap extent alignments in a separate function Chandan Babu R
2020-10-24 22:25 ` Allison Henderson
2020-10-19 6:40 ` [PATCH V7 13/14] xfs: Process allocated extent " Chandan Babu R
2020-10-24 23:15 ` Allison Henderson
2020-10-19 6:40 ` [PATCH V7 14/14] xfs: Introduce error injection to allocate only minlen size extents for files Chandan Babu R
2020-10-25 1:22 ` Allison Henderson
2020-10-26 3:23 ` Chandan Babu R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201019064048.6591-7-chandanrlinux@gmail.com \
--to=chandanrlinux@gmail.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.