All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	kraxel@redhat.com,
	"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
	Bruce Rogers <brogers@suse.com>
Subject: Re: [PATCH] meson: Only install icons and qemu.desktop if have_system
Date: Mon, 19 Oct 2020 09:11:28 +0100	[thread overview]
Message-ID: <20201019081128.GC236912@redhat.com> (raw)
In-Reply-To: <CAAdtpL73mOJM1Jp45fh_CrN45eQ4ezLnEzUzMGTjUYNKZufQPA@mail.gmail.com>

On Fri, Oct 16, 2020 at 10:26:16AM +0200, Philippe Mathieu-Daudé wrote:
> Le jeu. 15 oct. 2020 22:22, Bruce Rogers <brogers@suse.com> a écrit :
> 
> > These files are not needed for a linux-user only install.
> 
> 
> > Signed-off-by: Bruce Rogers <brogers@suse.com>
> > ---
> >  ui/meson.build | 7 +++++--
> >  1 file changed, 5 insertions(+), 2 deletions(-)
> >
> > diff --git a/ui/meson.build b/ui/meson.build
> > index 78ad792ffb..fb36d305ca 100644
> > --- a/ui/meson.build
> > +++ b/ui/meson.build
> > @@ -113,8 +113,11 @@ if have_system or xkbcommon.found()
> >  endif
> >
> >  subdir('shader')
> > -subdir('icons')
> >
> > -install_data('qemu.desktop', install_dir: config_host['qemu_desktopdir'])
> > +if have_system
> >
> 
> Some tools could have an icon, QSD later?

The icons are only needed for the tools with graphical display (ie SDL)
right now.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



      reply	other threads:[~2020-10-19  8:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-15 20:18 [PATCH] meson: Only install icons and qemu.desktop if have_system Bruce Rogers
2020-10-16  7:35 ` Paolo Bonzini
2020-10-16  8:26 ` Philippe Mathieu-Daudé
2020-10-19  8:11   ` Daniel P. Berrangé [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201019081128.GC236912@redhat.com \
    --to=berrange@redhat.com \
    --cc=brogers@suse.com \
    --cc=f4bug@amsat.org \
    --cc=kraxel@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.