Re: [PATCH iproute2-next 2/2] m_mpls: add mac_push action

[Guillaume Nault <gnault@redhat.com>]

On Sat, Oct 17, 2020 at 09:23:52AM -0600, David Ahern wrote:
> On 10/13/20 8:32 AM, Guillaume Nault wrote:
> > @@ -41,12 +44,12 @@ static void usage(void)
> >  
> >  static bool can_modify_mpls_fields(unsigned int action)
> >  {
> > -	return action == TCA_MPLS_ACT_PUSH || action == TCA_MPLS_ACT_MODIFY;
> > +	return action == TCA_MPLS_ACT_PUSH || action == TCA_MPLS_ACT_MAC_PUSH || action == TCA_MPLS_ACT_MODIFY;
> >  }
> >  
> > -static bool can_modify_ethtype(unsigned int action)
> > +static bool can_set_ethtype(unsigned int action)
> >  {
> > -	return action == TCA_MPLS_ACT_PUSH || action == TCA_MPLS_ACT_POP;
> > +	return action == TCA_MPLS_ACT_PUSH || action == TCA_MPLS_ACT_MAC_PUSH || action == TCA_MPLS_ACT_POP;
> >  }
> >  
> >  static bool is_valid_label(__u32 label)
> 
> nit: please wrap the lines with the new action.

Will do.

> Besides the nit, very nice and complete change set - man page, help, and
>  tests.

Thanks!