From: Minchan Kim <minchan@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Mikhail Gavrilov <mikhail.v.gavrilov@gmail.com>,
Linux List Kernel Mailing <linux-kernel@vger.kernel.org>,
linux-block@vger.kernel.org,
Mike Galbraith <umgwanakikbuti@gmail.com>,
ngupta@vflare.org, sergey.senozhatsky.work@gmail.com,
bigeasy@linutronix.de, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] zram: Fix __zram_bvec_{read,write}() locking order
Date: Mon, 19 Oct 2020 07:08:30 -0700 [thread overview]
Message-ID: <20201019140830.GA3118409@google.com> (raw)
In-Reply-To: <20201019101353.GJ2628@hirez.programming.kicks-ass.net>
On Mon, Oct 19, 2020 at 12:13:53PM +0200, Peter Zijlstra wrote:
>
> Mikhail reported a lockdep spat detailing how __zram_bvec_read() and
> __zram_bvec_write() use zstrm->lock and zspage->lock in opposite order.
>
> Reported-by: Mikhail Gavrilov <mikhail.v.gavrilov@gmail.com>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> Tested-by: Mikhail Gavrilov <mikhail.v.gavrilov@gmail.com>
Acked-by: Minchan Kim <minchan@kernel.org>
Thanks for the fix.
next prev parent reply other threads:[~2020-10-19 14:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-16 6:21 swapon/913 is trying to acquire lock at zcomp_stream_get+0x5/0x90 [zram] but task is already holding lock at zs_map_object+0x7a/0x2e0 Mikhail Gavrilov
2020-10-16 12:40 ` Peter Zijlstra
2020-10-16 14:00 ` Mikhail Gavrilov
2020-10-16 15:33 ` Minchan Kim
2020-10-19 10:13 ` [PATCH] zram: Fix __zram_bvec_{read,write}() locking order Peter Zijlstra
2020-10-19 14:08 ` Minchan Kim [this message]
2020-10-19 15:29 ` Sebastian Andrzej Siewior
2020-10-19 15:32 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201019140830.GA3118409@google.com \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=bigeasy@linutronix.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikhail.v.gavrilov@gmail.com \
--cc=ngupta@vflare.org \
--cc=peterz@infradead.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=umgwanakikbuti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.