From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 699EEC43467 for ; Mon, 19 Oct 2020 20:49:27 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7A1E1223FD for ; Mon, 19 Oct 2020 20:49:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="e4G4AGBg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7A1E1223FD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 950AF16F3; Mon, 19 Oct 2020 22:48:32 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 950AF16F3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1603140562; bh=oi8wGhEsvuY/SFHt/nDa0WBwIEEttQAUKB/mGGvThRA=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=e4G4AGBgeaev+y+Rxyzusfao61UIzR+fVqHf1gIVsdrQZFoAuam9SlOQm4pT+KauD lo4VeQ1kGF9TxXmKPk1b7rW5r/4j2eU22o8xHtNdduLIBd7gC6OBV+0a8hMxMM1Y4j gvFs6qBQDRZPTIJepftIOsR/Bp60Cj+eVd8Q9hvA= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 825ACF801D5; Mon, 19 Oct 2020 22:48:31 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 60243F80247; Mon, 19 Oct 2020 22:48:29 +0200 (CEST) Received: from mail-oo1-f67.google.com (mail-oo1-f67.google.com [209.85.161.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 3E216F801A3 for ; Mon, 19 Oct 2020 22:48:25 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 3E216F801A3 Received: by mail-oo1-f67.google.com with SMTP id l18so261747ooa.9 for ; Mon, 19 Oct 2020 13:48:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=fxa3uzHmULeVmNdtF5y01CM2QpDZ2ApdIjLlwOHG4sY=; b=P2m67sya1mL7qbaaE4yUsX+kK7KMemMZs2jDxfvqcQN/z1fhjfEZ2fwfdD9Ui4yOf5 wZ9FtnSUTfa1CUcVuHlItOUHLJCox1z+txPk3f/MRKqRHGjZveXXZrlpwFN4lbfWP8x7 R275Tfc7/VU3x9scLFCJ43AzQpSdebwcWyzEezeWzZAvAjGMr5uWkhDm1+xtaDuu1cWh 4sEEEs21dSo0FycFAn1Yocg7kt3r/OrteNr5OwIjhsjq5YDTqeX7rkry272c1YafUlcw QeAeZK+g5FS9yKWmXaMKaPJ8WJcE87cG+EQeP7UvX3t3LGt22E6c0wYNz/8IxrpA6rfZ U4vg== X-Gm-Message-State: AOAM5305gZ4pZt15MNYaPZFJLNRaYy9h8WO+dErD/BaWPXIWiKngyQzs QBtAbpCWchCyVu9sNs59Mw== X-Google-Smtp-Source: ABdhPJwl/iQfkO5suixU4PBWEHxz8p2fHudaNaiDXdTvQ5KBbgmlpr2GV9/HQXy//V7q3Emcotkdtw== X-Received: by 2002:a4a:dc0d:: with SMTP id p13mr1278563oov.2.1603140504163; Mon, 19 Oct 2020 13:48:24 -0700 (PDT) Received: from xps15 (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id j191sm237505oib.52.2020.10.19.13.48.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Oct 2020 13:48:23 -0700 (PDT) Received: (nullmailer pid 3577895 invoked by uid 1000); Mon, 19 Oct 2020 20:48:21 -0000 Date: Mon, 19 Oct 2020 15:48:21 -0500 From: Rob Herring To: Richard Fitzgerald Subject: Re: [PATCH 0/7] Add dts for Rpi4 + Cirrus Lochnagar and codecs Message-ID: <20201019204821.GA3569507@bogus> References: <20201014145418.31838-1-rf@opensource.cirrus.com> <20201014185632.GD4580@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, Mark Brown , linux-arm-kernel@lists.infradead.org, nsaenzjulienne@suse.de, linux-rpi-kernel@lists.infradead.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, Oct 16, 2020 at 02:30:08PM +0100, Richard Fitzgerald wrote: > On 14/10/2020 19:56, Mark Brown wrote: > > On Wed, Oct 14, 2020 at 03:54:11PM +0100, Richard Fitzgerald wrote: > > > This set of patches provides support for using the Cirrus Logic > > > Lochnagar audio development platform plus Cirrus Logic Madera/Arizona > > > codecs with the simple-card machine driver and a Raspberry Pi4. The > > > ultimate aim is to provide the dts file but some updates are needed to > > > the simple-card machine driver. > > > > Why extend simple-card and not the more modern and flexible > > audio-graph-card? > > > > I'm struggling to understand how to use audio-graph-card where there are > multiple alternative codecs. The host I2S endpoint has to point back to > the codec endpoint, like this: > > cpu_i2s_ep_cs47l15: endpoint { > remote-endpoint = <&cs47l15_aif1>; > }; > > But obviously that depends on which codec node was enabled. Listing > multiple endpoints makes the whole port node disabled if any remote > endpoint is in a disabled node. I've tried adding status="disabled" > to endpoints or multiple port definitions with status="disabled" but > I haven't figured out a solution. Multiple endpoints is what you should do. And 'status' goes in the device nodes (not the graph nodes). Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2EB1C433DF for ; Mon, 19 Oct 2020 20:49:57 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 47761223FB for ; Mon, 19 Oct 2020 20:49:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WixSOdeO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 47761223FB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4d6I1DWsWkAOfdqqIJHKEYfSLxQ2TqkmanHswFvVM7w=; b=WixSOdeOH3ZESAHPiP2jv2za/ +q0O1cpMsdSoPtzXqvBNQoULmuzE5ovhJLl+fZ3agzaoNH/fN1eppxUHRWSUfJoOhTWXnO+0hK4qc p2RPcgM64/kU5PhpqCQaOQwesEWEbKY+KRVicyHturkVNTH9FlRBZp16yc51tGsUvT2Afdjtzze2u 5xpCqmx9j3nxtqRqA3Fm5tTy3et1tJ+XIP/z4ChYF1CY/KQ1fDISnk+1FXaNOGTBGPNv7IZAt3mGh YcZNvn1suO+lhazjdSE/O8ogASjI1L9qHmxJXKVpvKYJi8hKlxv6XulBI85ZL5hD+eTfzSZ+2CUbJ BKSvfcjhw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kUc4y-0006Kq-5W; Mon, 19 Oct 2020 20:48:28 +0000 Received: from mail-oo1-f65.google.com ([209.85.161.65]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kUc4v-0006KM-0T; Mon, 19 Oct 2020 20:48:25 +0000 Received: by mail-oo1-f65.google.com with SMTP id f19so270306oot.4; Mon, 19 Oct 2020 13:48:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=fxa3uzHmULeVmNdtF5y01CM2QpDZ2ApdIjLlwOHG4sY=; b=WF9v4TsPrILI39KxmKYPSaKDmkLMKeTplVoKENzqvsp+4DlxaTxNOwDO5moNtv/kUh GossVAHArIAfK3ktuXZ8Xofk4KifrjujPo8cSsDMgoYw432eSw1uW1PiArmDc7eO0kb0 aX0RR2CTbN7uuMNw0dIrnNM99V25Rn99StVYNKZjxg4TAeHBq1Mu7pBiH0FxakOvMCay TIvUuQRkY7BKKZwrhu8VV85QCcbclXzZizO8dGb8EHPOFzIJZuZ0+AHr1rJl/AuodvRV DyYTFQ5WyCnqQSPYH1kj5/RoIKykig3sEswfMrmcDG+50MuVl/KS/BV1KaXm9CC6dbyK 0STw== X-Gm-Message-State: AOAM530QP14Qwu14Xc8K3A0Zc5F69mmHWsGKBzERLB1ft3ODs/cZsKMx e99DFlRNMcbmUA4p9vQbbA== X-Google-Smtp-Source: ABdhPJwl/iQfkO5suixU4PBWEHxz8p2fHudaNaiDXdTvQ5KBbgmlpr2GV9/HQXy//V7q3Emcotkdtw== X-Received: by 2002:a4a:dc0d:: with SMTP id p13mr1278563oov.2.1603140504163; Mon, 19 Oct 2020 13:48:24 -0700 (PDT) Received: from xps15 (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id j191sm237505oib.52.2020.10.19.13.48.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Oct 2020 13:48:23 -0700 (PDT) Received: (nullmailer pid 3577895 invoked by uid 1000); Mon, 19 Oct 2020 20:48:21 -0000 Date: Mon, 19 Oct 2020 15:48:21 -0500 From: Rob Herring To: Richard Fitzgerald Subject: Re: [PATCH 0/7] Add dts for Rpi4 + Cirrus Lochnagar and codecs Message-ID: <20201019204821.GA3569507@bogus> References: <20201014145418.31838-1-rf@opensource.cirrus.com> <20201014185632.GD4580@sirena.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201019_164825_068126_44CE0F20 X-CRM114-Status: GOOD ( 20.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, Mark Brown , linux-arm-kernel@lists.infradead.org, nsaenzjulienne@suse.de, linux-rpi-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 16, 2020 at 02:30:08PM +0100, Richard Fitzgerald wrote: > On 14/10/2020 19:56, Mark Brown wrote: > > On Wed, Oct 14, 2020 at 03:54:11PM +0100, Richard Fitzgerald wrote: > > > This set of patches provides support for using the Cirrus Logic > > > Lochnagar audio development platform plus Cirrus Logic Madera/Arizona > > > codecs with the simple-card machine driver and a Raspberry Pi4. The > > > ultimate aim is to provide the dts file but some updates are needed to > > > the simple-card machine driver. > > > > Why extend simple-card and not the more modern and flexible > > audio-graph-card? > > > > I'm struggling to understand how to use audio-graph-card where there are > multiple alternative codecs. The host I2S endpoint has to point back to > the codec endpoint, like this: > > cpu_i2s_ep_cs47l15: endpoint { > remote-endpoint = <&cs47l15_aif1>; > }; > > But obviously that depends on which codec node was enabled. Listing > multiple endpoints makes the whole port node disabled if any remote > endpoint is in a disabled node. I've tried adding status="disabled" > to endpoints or multiple port definitions with status="disabled" but > I haven't figured out a solution. Multiple endpoints is what you should do. And 'status' goes in the device nodes (not the graph nodes). Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43379C433E7 for ; Mon, 19 Oct 2020 20:48:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CE657223EA for ; Mon, 19 Oct 2020 20:48:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603140505; bh=oi8wGhEsvuY/SFHt/nDa0WBwIEEttQAUKB/mGGvThRA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=NmUXyWDDBh3VxjORP7QWyF/tuumJGDsdmoxYNA7r7lu0w1RuaV3hkK5droydC+t8u 3zhba678r0zOaN3fNT5aggXYtHbYvQwDwhufctBGO/0ScJdrwAH/00k9SGVsgTIV/e tj5WILvuu1o6IIKzxILwfc+FFkiXUmqMONJGWJUQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727082AbgJSUsZ (ORCPT ); Mon, 19 Oct 2020 16:48:25 -0400 Received: from mail-oo1-f67.google.com ([209.85.161.67]:39964 "EHLO mail-oo1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727007AbgJSUsZ (ORCPT ); Mon, 19 Oct 2020 16:48:25 -0400 Received: by mail-oo1-f67.google.com with SMTP id w7so267436oow.7; Mon, 19 Oct 2020 13:48:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=fxa3uzHmULeVmNdtF5y01CM2QpDZ2ApdIjLlwOHG4sY=; b=Va2X7wBuu+NBS4fj2JxIadcxzkqIo8mUISO+Oyy57HAI9+lxrvx2mgsdyiwlPrSw8s nwEuNG8gFhb1wRtOBTg/Wv2shnk1OWm4xQ6nDykpYlxE/dfQlJxKxLTfG+OVePf6EOjc JKqXwolpGT7Bj1ZZjhV+r1m021AdaycW7G4sEYtAeZoosnw0a3dCP7Xx2tLOQmDbqnox P3vfxqms48sq0rrbnvcWb+hrGI6KAf8H8RfHzDJ5tpRhrsi+L5984atDO5tzNaU5T1mU mdm+nvKwCj+y/EUmYeTT+SzWauwnOqVytnKs14cms1E0kIOLUP5u3pVbwYfRbN3PEOZd ftzw== X-Gm-Message-State: AOAM532Gvt87raJf2QMrhNAlIUzPE3dX97mjhIWD57jJx/8IVSuaAgF3 lClEwTMhUVJXGAKcnZCsRdcDfVQ6Ew== X-Google-Smtp-Source: ABdhPJwl/iQfkO5suixU4PBWEHxz8p2fHudaNaiDXdTvQ5KBbgmlpr2GV9/HQXy//V7q3Emcotkdtw== X-Received: by 2002:a4a:dc0d:: with SMTP id p13mr1278563oov.2.1603140504163; Mon, 19 Oct 2020 13:48:24 -0700 (PDT) Received: from xps15 (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id j191sm237505oib.52.2020.10.19.13.48.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Oct 2020 13:48:23 -0700 (PDT) Received: (nullmailer pid 3577895 invoked by uid 1000); Mon, 19 Oct 2020 20:48:21 -0000 Date: Mon, 19 Oct 2020 15:48:21 -0500 From: Rob Herring To: Richard Fitzgerald Cc: Mark Brown , nsaenzjulienne@suse.de, patches@opensource.cirrus.com, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org Subject: Re: [PATCH 0/7] Add dts for Rpi4 + Cirrus Lochnagar and codecs Message-ID: <20201019204821.GA3569507@bogus> References: <20201014145418.31838-1-rf@opensource.cirrus.com> <20201014185632.GD4580@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Oct 16, 2020 at 02:30:08PM +0100, Richard Fitzgerald wrote: > On 14/10/2020 19:56, Mark Brown wrote: > > On Wed, Oct 14, 2020 at 03:54:11PM +0100, Richard Fitzgerald wrote: > > > This set of patches provides support for using the Cirrus Logic > > > Lochnagar audio development platform plus Cirrus Logic Madera/Arizona > > > codecs with the simple-card machine driver and a Raspberry Pi4. The > > > ultimate aim is to provide the dts file but some updates are needed to > > > the simple-card machine driver. > > > > Why extend simple-card and not the more modern and flexible > > audio-graph-card? > > > > I'm struggling to understand how to use audio-graph-card where there are > multiple alternative codecs. The host I2S endpoint has to point back to > the codec endpoint, like this: > > cpu_i2s_ep_cs47l15: endpoint { > remote-endpoint = <&cs47l15_aif1>; > }; > > But obviously that depends on which codec node was enabled. Listing > multiple endpoints makes the whole port node disabled if any remote > endpoint is in a disabled node. I've tried adding status="disabled" > to endpoints or multiple port definitions with status="disabled" but > I haven't figured out a solution. Multiple endpoints is what you should do. And 'status' goes in the device nodes (not the graph nodes). Rob