From: Andrew Lunn <andrew@lunn.ch>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Vladimir Oltean <vladimir.oltean@nxp.com>,
netdev@vger.kernel.org, f.fainelli@gmail.com,
vivien.didelot@gmail.com
Subject: Re: [PATCH net] net: dsa: reference count the host mdb addresses
Date: Tue, 20 Oct 2020 02:07:46 +0200 [thread overview]
Message-ID: <20201020000746.GR456889@lunn.ch> (raw)
In-Reply-To: <20201019165514.1fe7d8f3@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Mon, Oct 19, 2020 at 04:55:14PM -0700, Jakub Kicinski wrote:
> On Fri, 16 Oct 2020 00:27:11 +0300 Vladimir Oltean wrote:
> > Currently any DSA switch that implements the multicast ops (properly,
> > that is) gets these errors after just sitting for a while, with at least
> > 2 ports bridged:
> >
> > [ 286.013814] mscc_felix 0000:00:00.5 swp3: failed (err=-2) to del object (id=3)
> >
> > The reason has to do with this piece of code:
> >
> > netdev_for_each_lower_dev(dev, lower_dev, iter)
> > br_mdb_switchdev_host_port(dev, lower_dev, mp, type);
>
> We need a review on this one, anyone?
Hi Jakub
Thanks for the reminder. It has been on my TODO list since i got back
from vacation.
Andrew
next prev parent reply other threads:[~2020-10-20 0:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-15 21:27 [PATCH net] net: dsa: reference count the host mdb addresses Vladimir Oltean
2020-10-19 23:55 ` Jakub Kicinski
2020-10-20 0:07 ` Andrew Lunn [this message]
2020-10-20 0:13 ` Jakub Kicinski
2020-10-20 0:06 ` Andrew Lunn
2020-10-20 0:28 ` Vladimir Oltean
2020-10-20 2:11 ` Florian Fainelli
2020-11-27 21:41 ` Vladimir Oltean
2020-11-27 23:58 ` Tobias Waldekranz
2020-11-28 0:27 ` Vladimir Oltean
2020-11-28 9:34 ` Tobias Waldekranz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201020000746.GR456889@lunn.ch \
--to=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.