From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Daniel Latypov <dlatypov@google.com>
Cc: brendanhiggins@google.com, davidgow@google.com,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
skhan@linuxfoundation.org
Subject: Re: [PATCH] lib: add basic KUnit test for lib/math
Date: Tue, 20 Oct 2020 11:09:43 +0300 [thread overview]
Message-ID: <20201020080943.GY4077@smile.fi.intel.com> (raw)
In-Reply-To: <20201019224556.3536790-1-dlatypov@google.com>
On Mon, Oct 19, 2020 at 03:45:56PM -0700, Daniel Latypov wrote:
> Add basic test coverage for files that don't require any config options:
> * gcd.c
> * lcm.c
> * int_sqrt.c
> * reciprocal_div.c
> (Ignored int_pow.c since it's a simple textbook algorithm.)
>
> These tests aren't particularly interesting, but
> * they're chosen as easy to understand examples of how to write tests
> * provides a place to add tests for any new files in this dir
> * written so adding new test cases to cover edge cases should be easy
Is documentation not enough?
I have recently wrote my first KUnit test and I found documentation pretty good
for the start. I think we actually need more complex examples in the code (and
useful).
So, I'm in doubt these test are a good point to start with.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-10-20 8:08 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 22:45 [PATCH] lib: add basic KUnit test for lib/math Daniel Latypov
2020-10-20 0:45 ` kernel test robot
2020-10-20 0:45 ` kernel test robot
2020-10-20 8:09 ` Andy Shevchenko [this message]
2020-10-20 16:13 ` Daniel Latypov
2020-10-21 3:40 ` David Gow
2020-10-21 17:47 ` Daniel Latypov
2020-10-22 15:06 ` Andy Shevchenko
2020-10-22 16:26 ` Daniel Latypov
2020-10-22 18:51 ` Brendan Higgins
2020-10-22 19:10 ` Andy Shevchenko
2020-10-22 19:12 ` Andy Shevchenko
2020-10-22 18:53 ` Brendan Higgins
2020-10-22 19:05 ` Andy Shevchenko
2020-10-22 21:21 ` Brendan Higgins
2020-10-23 9:02 ` Andy Shevchenko
2020-11-02 14:51 ` kernel test robot
2020-11-02 14:51 ` kernel test robot
2020-11-03 1:32 ` kernel test robot
2020-11-03 1:32 ` kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2020-11-02 3:42 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201020080943.GY4077@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=brendanhiggins@google.com \
--cc=davidgow@google.com \
--cc=dlatypov@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.